* [PATCH] arm64: dts: mt7986: set Wifi Leds low-active for BPI-R3
@ 2023-02-05 17:48 Frank Wunderlich
2023-02-06 20:20 ` Matthias Brugger
0 siblings, 1 reply; 5+ messages in thread
From: Frank Wunderlich @ 2023-02-05 17:48 UTC (permalink / raw)
To: linux-mediatek
Cc: Frank Wunderlich, Rob Herring, Krzysztof Kozlowski,
Matthias Brugger, AngeloGioacchino Del Regno, devicetree,
linux-kernel, linux-arm-kernel
From: Frank Wunderlich <frank-w@public-files.de>
Leds for Wifi are low-active, so add property to devicetree.
Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
index 33bd6febc160..2b028141f1f7 100644
--- a/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
+++ b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
@@ -446,5 +446,9 @@ &wifi {
pinctrl-names = "default", "dbdc";
pinctrl-0 = <&wf_2g_5g_pins>, <&wf_led_pins>;
pinctrl-1 = <&wf_dbdc_pins>, <&wf_led_pins>;
+
+ led {
+ led-active-low;
+ };
};
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: mt7986: set Wifi Leds low-active for BPI-R3
2023-02-05 17:48 [PATCH] arm64: dts: mt7986: set Wifi Leds low-active for BPI-R3 Frank Wunderlich
@ 2023-02-06 20:20 ` Matthias Brugger
2023-02-07 15:17 ` AngeloGioacchino Del Regno
0 siblings, 1 reply; 5+ messages in thread
From: Matthias Brugger @ 2023-02-06 20:20 UTC (permalink / raw)
To: Frank Wunderlich, linux-mediatek
Cc: Frank Wunderlich, Rob Herring, Krzysztof Kozlowski,
AngeloGioacchino Del Regno, devicetree, linux-kernel,
linux-arm-kernel
On 05/02/2023 18:48, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
>
> Leds for Wifi are low-active, so add property to devicetree.
>
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> ---
> arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
> index 33bd6febc160..2b028141f1f7 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
> @@ -446,5 +446,9 @@ &wifi {
> pinctrl-names = "default", "dbdc";
> pinctrl-0 = <&wf_2g_5g_pins>, <&wf_led_pins>;
> pinctrl-1 = <&wf_dbdc_pins>, <&wf_led_pins>;
> +
> + led {
> + led-active-low;
> + };
The binding is missing this property also the driver implements it. Could you
please update the bindind description properly?
Thanks
Matthias
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: mt7986: set Wifi Leds low-active for BPI-R3
2023-02-06 20:20 ` Matthias Brugger
@ 2023-02-07 15:17 ` AngeloGioacchino Del Regno
2023-05-22 8:26 ` Aw: " Frank Wunderlich
0 siblings, 1 reply; 5+ messages in thread
From: AngeloGioacchino Del Regno @ 2023-02-07 15:17 UTC (permalink / raw)
To: Matthias Brugger, Frank Wunderlich, linux-mediatek
Cc: Frank Wunderlich, Rob Herring, Krzysztof Kozlowski, devicetree,
linux-kernel, linux-arm-kernel
Il 06/02/23 21:20, Matthias Brugger ha scritto:
>
>
> On 05/02/2023 18:48, Frank Wunderlich wrote:
>> From: Frank Wunderlich <frank-w@public-files.de>
>>
>> Leds for Wifi are low-active, so add property to devicetree.
>>
>> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
>> ---
>> arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
>> b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
>> index 33bd6febc160..2b028141f1f7 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
>> +++ b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
>> @@ -446,5 +446,9 @@ &wifi {
>> pinctrl-names = "default", "dbdc";
>> pinctrl-0 = <&wf_2g_5g_pins>, <&wf_led_pins>;
>> pinctrl-1 = <&wf_dbdc_pins>, <&wf_led_pins>;
>> +
>> + led {
>> + led-active-low;
>> + };
>
> The binding is missing this property also the driver implements it. Could you
> please update the bindind description properly?
> Thanks
> Matthias
After and only after [1] is picked,
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
[1]:
https://patchwork.kernel.org/project/linux-mediatek/patch/20230207133504.21826-1-linux@fw-web.de/
^ permalink raw reply [flat|nested] 5+ messages in thread* Aw: Re: [PATCH] arm64: dts: mt7986: set Wifi Leds low-active for BPI-R3
2023-02-07 15:17 ` AngeloGioacchino Del Regno
@ 2023-05-22 8:26 ` Frank Wunderlich
2023-05-29 16:07 ` Matthias Brugger
0 siblings, 1 reply; 5+ messages in thread
From: Frank Wunderlich @ 2023-05-22 8:26 UTC (permalink / raw)
To: Matthias Brugger
Cc: Frank Wunderlich, linux-mediatek, Rob Herring,
Krzysztof Kozlowski, devicetree, linux-kernel, linux-arm-kernel,
AngeloGioacchino Del Regno
> Gesendet: Dienstag, 07. Februar 2023 um 17:17 Uhr
> Von: "AngeloGioacchino Del Regno" <angelogioacchino.delregno@collabora.com>
> Il 06/02/23 21:20, Matthias Brugger ha scritto:
> >
> >
> > On 05/02/2023 18:48, Frank Wunderlich wrote:
> >> From: Frank Wunderlich <frank-w@public-files.de>
> >>
> >> Leds for Wifi are low-active, so add property to devicetree.
> >>
> >> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> >> ---
> >> arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts | 4 ++++
> >> 1 file changed, 4 insertions(+)
> >>
> >> diff --git a/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
> >> b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
> >> index 33bd6febc160..2b028141f1f7 100644
> >> --- a/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
> >> +++ b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
> >> @@ -446,5 +446,9 @@ &wifi {
> >> pinctrl-names = "default", "dbdc";
> >> pinctrl-0 = <&wf_2g_5g_pins>, <&wf_led_pins>;
> >> pinctrl-1 = <&wf_dbdc_pins>, <&wf_led_pins>;
> >> +
> >> + led {
> >> + led-active-low;
> >> + };
> >
> > The binding is missing this property also the driver implements it. Could you
> > please update the bindind description properly?
> > Thanks
> > Matthias
>
>
> After and only after [1] is picked,
>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>
> [1]:
> https://patchwork.kernel.org/project/linux-mediatek/patch/20230207133504.21826-1-linux@fw-web.de/
Hi Matthias,
Can you take this patch into your tree? binding is already merged
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml#n114
regards Frank
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: Aw: Re: [PATCH] arm64: dts: mt7986: set Wifi Leds low-active for BPI-R3
2023-05-22 8:26 ` Aw: " Frank Wunderlich
@ 2023-05-29 16:07 ` Matthias Brugger
0 siblings, 0 replies; 5+ messages in thread
From: Matthias Brugger @ 2023-05-29 16:07 UTC (permalink / raw)
To: Frank Wunderlich
Cc: Frank Wunderlich, linux-mediatek, Rob Herring,
Krzysztof Kozlowski, devicetree, linux-kernel, linux-arm-kernel,
AngeloGioacchino Del Regno
On 22/05/2023 10:26, Frank Wunderlich wrote:
>> Gesendet: Dienstag, 07. Februar 2023 um 17:17 Uhr
>> Von: "AngeloGioacchino Del Regno" <angelogioacchino.delregno@collabora.com>
>> Il 06/02/23 21:20, Matthias Brugger ha scritto:
>>>
>>>
>>> On 05/02/2023 18:48, Frank Wunderlich wrote:
>>>> From: Frank Wunderlich <frank-w@public-files.de>
>>>>
>>>> Leds for Wifi are low-active, so add property to devicetree.
>>>>
>>>> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
>>>> ---
>>>> arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts | 4 ++++
>>>> 1 file changed, 4 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
>>>> b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
>>>> index 33bd6febc160..2b028141f1f7 100644
>>>> --- a/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
>>>> +++ b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
>>>> @@ -446,5 +446,9 @@ &wifi {
>>>> pinctrl-names = "default", "dbdc";
>>>> pinctrl-0 = <&wf_2g_5g_pins>, <&wf_led_pins>;
>>>> pinctrl-1 = <&wf_dbdc_pins>, <&wf_led_pins>;
>>>> +
>>>> + led {
>>>> + led-active-low;
>>>> + };
>>>
>>> The binding is missing this property also the driver implements it. Could you
>>> please update the bindind description properly?
>>> Thanks
>>> Matthias
>>
>>
>> After and only after [1] is picked,
>>
>> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>>
>> [1]:
>> https://patchwork.kernel.org/project/linux-mediatek/patch/20230207133504.21826-1-linux@fw-web.de/
>
> Hi Matthias,
>
> Can you take this patch into your tree? binding is already merged
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml#n114
>
Applied now :)
Regards,
Matthias
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-05-29 16:07 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-05 17:48 [PATCH] arm64: dts: mt7986: set Wifi Leds low-active for BPI-R3 Frank Wunderlich
2023-02-06 20:20 ` Matthias Brugger
2023-02-07 15:17 ` AngeloGioacchino Del Regno
2023-05-22 8:26 ` Aw: " Frank Wunderlich
2023-05-29 16:07 ` Matthias Brugger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).