Devicetree
 help / color / mirror / Atom feed
From: Bjorn Andersson <andersson@kernel.org>
To: Mukesh Ojha <quic_mojha@quicinc.com>
Cc: Konrad Dybcio <konrad.dybcio@linaro.org>,
	agross@kernel.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: qcom: sm8450: Add IMEM and PIL info region
Date: Mon, 6 Feb 2023 13:04:55 -0800	[thread overview]
Message-ID: <20230206210455.xgrvtvknkor4nllx@ripper> (raw)
In-Reply-To: <d1dc0c9b-eab2-0287-d0a2-ead44ecee5ce@quicinc.com>

On Mon, Feb 06, 2023 at 08:06:13PM +0530, Mukesh Ojha wrote:
> 
> 
> On 2/4/2023 3:07 AM, Konrad Dybcio wrote:
> > 
> > 
> > On 3.02.2023 18:04, Mukesh Ojha wrote:
> > > Add a simple-mfd representing IMEM on SM8450 and define the PIL
> > > relocation info region, so that post mortem tools will be able
> > > to locate the loaded remoteprocs.
> > > 
> > > Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
> > > ---
> >  From XBL:
> > 
> > 0x14680000, 0x0002A000, "IMEM Base"
> > 
> > Is there anything in that wider address range that would interest
> > us? I recall Alex once dug into that when diving into IPA, but
> > I can not recall the conclusion..
> Spec-wise, yes IPA do own these 0x146A8000 - 0x146AA000 .
> But, not sure what they use it for.
> 

The DT should not reflect the organization structure. Let's see if Alex
have any input on this.

Thanks,
Bjorn

> -Mukesh
> > 
> > Konrad
> > >   arch/arm64/boot/dts/qcom/sm8450.dtsi | 15 +++++++++++++++
> > >   1 file changed, 15 insertions(+)
> > > 
> > > diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> > > index 5704750..474ea1b 100644
> > > --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
> > > +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> > > @@ -3536,6 +3536,21 @@
> > >   			};
> > >   		};
> > > +		sram@146aa000 {
> > > +			compatible = "qcom,sm8450-imem", "syscon", "simple-mfd";
> > > +			reg = <0 0x146aa000 0 0x1000>;
> > > +
> > > +			#address-cells = <1>;
> > > +			#size-cells = <1>;
> > > +
> > > +			ranges = <0 0 0x146aa000 0x1000>;
> > > +
> > > +			pil-reloc@94c {
> > > +				compatible = "qcom,pil-reloc-info";
> > > +				reg = <0x94c 0xc8>;
> > > +			};
> > > +		};
> > > +
> > >   		apps_rsc: rsc@17a00000 {
> > >   			label = "apps_rsc";
> > >   			compatible = "qcom,rpmh-rsc";

  reply	other threads:[~2023-02-06 21:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-03 17:04 [PATCH 1/2] dt-bindings: sram: qcom,imem: document sm8450 Mukesh Ojha
2023-02-03 17:04 ` [PATCH 2/2] arm64: dts: qcom: sm8450: Add IMEM and PIL info region Mukesh Ojha
2023-02-03 17:51   ` Krzysztof Kozlowski
2023-02-03 21:37   ` Konrad Dybcio
2023-02-06 14:36     ` Mukesh Ojha
2023-02-06 21:04       ` Bjorn Andersson [this message]
2023-02-14 12:34         ` Mukesh Ojha
2023-02-14 14:28           ` Alex Elder
2023-02-03 17:52 ` [PATCH 1/2] dt-bindings: sram: qcom,imem: document sm8450 Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230206210455.xgrvtvknkor4nllx@ripper \
    --to=andersson@kernel.org \
    --cc=agross@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_mojha@quicinc.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox