From: Frank Rowand <frowand.list@gmail.com>
To: Rob Herring <robh+dt@kernel.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 6/7] of: add consistency check to of_node_release()
Date: Mon, 13 Feb 2023 12:57:01 -0600 [thread overview]
Message-ID: <20230213185702.395776-7-frowand.list@gmail.com> (raw)
In-Reply-To: <20230213185702.395776-1-frowand.list@gmail.com>
Add an additional consistency check to of_node_release(), which is
called when the reference count of a devicetree node is decremented
to zero. The node's children should have been deleted before the
node is deleted so check that no children exist.
Signed-off-by: Frank Rowand <frowand.list@gmail.com>
---
drivers/of/dynamic.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/of/dynamic.c b/drivers/of/dynamic.c
index dbcbc41f3465..657a65006056 100644
--- a/drivers/of/dynamic.c
+++ b/drivers/of/dynamic.c
@@ -377,6 +377,10 @@ void of_node_release(struct kobject *kobj)
__func__, node);
}
+ if (node->child)
+ pr_err("ERROR: %s() unexpected children for %pOF/%s\n",
+ __func__, node->parent, node->full_name);
+
property_list_free(node->properties);
property_list_free(node->deadprops);
fwnode_links_purge(of_fwnode_handle(node));
--
Frank Rowand <frowand.list@gmail.com>
next prev parent reply other threads:[~2023-02-13 18:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-13 18:56 [PATCH 0/7] of: unittest: new node lifecycle tests Frank Rowand
2023-02-13 18:56 ` [PATCH 1/7] of: prepare to add processing of EXPECT_NOT to of_unittest_expect Frank Rowand
2023-02-13 18:56 ` [PATCH 2/7] of: " Frank Rowand
2023-02-13 18:56 ` [PATCH 3/7] of: update kconfig unittest help Frank Rowand
2023-02-13 18:56 ` [PATCH 4/7] of: unittest: add node lifecycle tests Frank Rowand
2023-02-26 0:07 ` Guenter Roeck
2023-02-26 19:50 ` Frank Rowand
2023-02-26 21:42 ` Frank Rowand
2023-02-13 18:57 ` [PATCH 5/7] of: do not use "%pOF" printk format on node with refcount of zero Frank Rowand
2023-02-13 19:23 ` Frank Rowand
2023-02-13 19:27 ` Frank Rowand
2023-02-13 18:57 ` Frank Rowand [this message]
2023-02-13 18:57 ` [PATCH 7/7] of: dynamic: add lifecycle docbook info to node creation functions Frank Rowand
2023-02-17 21:44 ` [PATCH 0/7] of: unittest: new node lifecycle tests Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230213185702.395776-7-frowand.list@gmail.com \
--to=frowand.list@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).