[PATCH v2 1/3] dt-bindings: power: supply: pm8941-coincell: Add PM8998 compatible

[PATCH v2 1/3] dt-bindings: power: supply: pm8941-coincell: Add PM8998 compatible

[Konrad Dybcio]

Add a specific compatible for the coincell charger present on PM8998.

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
v1 -> v2:

- Pick up ab

 .../bindings/power/supply/qcom,pm8941-coincell.yaml       | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml b/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml
index 0450f4dd4e51..b7b58aed3f3c 100644
--- a/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml
+++ b/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml
@@ -16,7 +16,13 @@ maintainers:
 
 properties:
   compatible:
-    const: qcom,pm8941-coincell
+    oneOf:
+      - items:
+          - enum:
+              - qcom,pm8998-coincell
+          - const: qcom,pm8941-coincell
+
+      - const: qcom,pm8941-coincell
 
   reg:
     maxItems: 1
-- 
2.39.1

[PATCH v2 2/3] dt-bindings: power: supply: pm8941-coincell: Don't require charging properties

[Konrad Dybcio]

It's fine for these properties to be absent, as the driver doesn't fail
without them and functions with settings inherited from the reset/previous
stage bootloader state.

Fixes: 6c463222a21d ("dt-bindings: power: supply: pm8941-coincell: Convert to DT schema format")
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
v1 -> v2:

- Describe the behaviour when the properties are absent

 .../bindings/power/supply/qcom,pm8941-coincell.yaml  | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml b/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml
index b7b58aed3f3c..1d2405bea109 100644
--- a/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml
+++ b/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml
@@ -28,12 +28,18 @@ properties:
     maxItems: 1
 
   qcom,rset-ohms:
-    description: resistance (in ohms) for current-limiting resistor
+    description: |
+      Resistance (in ohms) for current-limiting resistor. If unspecified,
+      inherit the previous configuration (e.g. from bootloader or hardware
+      default value).
     enum: [ 800, 1200, 1700, 2100 ]
 
   qcom,vset-millivolts:
     $ref: /schemas/types.yaml#/definitions/uint32
-    description: voltage (in millivolts) to apply for charging
+    description: |
+      Voltage (in millivolts) to apply for charging. If unspecified, inherit
+      the previous configuration (e.g. from bootloader or hardware default
+      value).
     enum: [ 2500, 3000, 3100, 3200 ]
 
   qcom,charger-disable:
@@ -43,8 +49,6 @@ properties:
 required:
   - compatible
   - reg
-  - qcom,rset-ohms
-  - qcom,vset-millivolts
 
 additionalProperties: false
 
-- 
2.39.1

Re: [PATCH v2 2/3] dt-bindings: power: supply: pm8941-coincell: Don't require charging properties

[Krzysztof Kozlowski]

On 14/02/2023 10:08, Konrad Dybcio wrote:
> It's fine for these properties to be absent, as the driver doesn't fail
> without them and functions with settings inherited from the reset/previous
> stage bootloader state.
> 
> Fixes: 6c463222a21d ("dt-bindings: power: supply: pm8941-coincell: Convert to DT schema format")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH v2 2/3] dt-bindings: power: supply: pm8941-coincell: Don't require charging properties

[Sebastian Reichel]

[-- Attachment #1: Type: text/plain, Size: 586 bytes --]

Hi,

On Wed, Feb 15, 2023 at 08:04:00PM +0100, Krzysztof Kozlowski wrote:
> On 14/02/2023 10:08, Konrad Dybcio wrote:
> > It's fine for these properties to be absent, as the driver doesn't fail
> > without them and functions with settings inherited from the reset/previous
> > stage bootloader state.
> > 
> > Fixes: 6c463222a21d ("dt-bindings: power: supply: pm8941-coincell: Convert to DT schema format")
> > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> 
> 
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Thanks, queued.

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[PATCH v2 3/3] arm64: dts: qcom: pm8998: Add a specific compatible for coincell chg

[Konrad Dybcio]

Add a PM8998-specific compatibel to the coincell charger and keep the
PM8941 one as fallback.

Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
v1 -> v2:

No changes

 arch/arm64/boot/dts/qcom/pm8998.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/pm8998.dtsi b/arch/arm64/boot/dts/qcom/pm8998.dtsi
index adbba9f4089a..340033ac3186 100644
--- a/arch/arm64/boot/dts/qcom/pm8998.dtsi
+++ b/arch/arm64/boot/dts/qcom/pm8998.dtsi
@@ -72,7 +72,7 @@ pm8998_temp: temp-alarm@2400 {
 		};
 
 		pm8998_coincell: charger@2800 {
-			compatible = "qcom,pm8941-coincell";
+			compatible = "qcom,pm8998-coincell", "qcom,pm8941-coincell";
 			reg = <0x2800>;
 
 			status = "disabled";
-- 
2.39.1

Re: [PATCH v2 3/3] arm64: dts: qcom: pm8998: Add a specific compatible for coincell chg

[Marijn Suijten]

On 2023-02-14 10:08:49, Konrad Dybcio wrote:
> Add a PM8998-specific compatibel to the coincell charger and keep the

I know you've been taking Dutch lessons, compatibel is a Dutch word :)

> PM8941 one as fallback.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org>

> ---
> v1 -> v2:
> 
> No changes
> 
>  arch/arm64/boot/dts/qcom/pm8998.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/pm8998.dtsi b/arch/arm64/boot/dts/qcom/pm8998.dtsi
> index adbba9f4089a..340033ac3186 100644
> --- a/arch/arm64/boot/dts/qcom/pm8998.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm8998.dtsi
> @@ -72,7 +72,7 @@ pm8998_temp: temp-alarm@2400 {
>  		};
>  
>  		pm8998_coincell: charger@2800 {
> -			compatible = "qcom,pm8941-coincell";
> +			compatible = "qcom,pm8998-coincell", "qcom,pm8941-coincell";
>  			reg = <0x2800>;
>  
>  			status = "disabled";
> -- 
> 2.39.1
> 

Re: [PATCH v2 1/3] dt-bindings: power: supply: pm8941-coincell: Add PM8998 compatible

[Sebastian Reichel]

[-- Attachment #1: Type: text/plain, Size: 1208 bytes --]

Hi,

On Tue, Feb 14, 2023 at 10:08:47AM +0100, Konrad Dybcio wrote:
> Add a specific compatible for the coincell charger present on PM8998.
> 
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---

Thanks, queued.

-- Sebastian

> v1 -> v2:
> 
> - Pick up ab
> 
>  .../bindings/power/supply/qcom,pm8941-coincell.yaml       | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml b/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml
> index 0450f4dd4e51..b7b58aed3f3c 100644
> --- a/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml
> +++ b/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml
> @@ -16,7 +16,13 @@ maintainers:
>  
>  properties:
>    compatible:
> -    const: qcom,pm8941-coincell
> +    oneOf:
> +      - items:
> +          - enum:
> +              - qcom,pm8998-coincell
> +          - const: qcom,pm8941-coincell
> +
> +      - const: qcom,pm8941-coincell
>  
>    reg:
>      maxItems: 1
> -- 
> 2.39.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: (subset) [PATCH v2 1/3] dt-bindings: power: supply: pm8941-coincell: Add PM8998 compatible

[Bjorn Andersson]

On Tue, 14 Feb 2023 10:08:47 +0100, Konrad Dybcio wrote:
> Add a specific compatible for the coincell charger present on PM8998.
> 
> 

Applied, thanks!

[3/3] arm64: dts: qcom: pm8998: Add a specific compatible for coincell chg
      commit: 0d589dc92fca4679186a949194fc7c452d37c575

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>