From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED9F8C05027 for ; Tue, 14 Feb 2023 17:18:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232918AbjBNRSP (ORCPT ); Tue, 14 Feb 2023 12:18:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232731AbjBNRRu (ORCPT ); Tue, 14 Feb 2023 12:17:50 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 99DE33019D for ; Tue, 14 Feb 2023 09:15:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676394917; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=n5Xftcuk/SSD+V/l0GWpcX6zdIVXO92U2DSCgVqWJgE=; b=Z2KYp0nF/CHRnQl3YaiCGP0IATca9XiQIEe2PlxhAZRUzQnj10NMrGcyKn68FFmVxikPQu snSwWVzWgSks1j1kWm5SL8FkEzWSM5+Q4a8HfgEVxcCN+CNy3vzXa3LaeqRf7n4qLW6TMH Fw9RCJha/FXUigOB9GB29firrHC8iuY= Received: from mail-oi1-f198.google.com (mail-oi1-f198.google.com [209.85.167.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-671-VTh8EYxsPkuxV8VKwVqtDg-1; Tue, 14 Feb 2023 12:15:15 -0500 X-MC-Unique: VTh8EYxsPkuxV8VKwVqtDg-1 Received: by mail-oi1-f198.google.com with SMTP id bk1-20020a0568081a0100b0037da9ddc2b8so1057538oib.4 for ; Tue, 14 Feb 2023 09:15:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=n5Xftcuk/SSD+V/l0GWpcX6zdIVXO92U2DSCgVqWJgE=; b=7D0Zg2G/K0+ZB/q48jVv26iJ/J6o++5p708WC6UAAdqf2TzZgPGTniaU3jdRVrrgDM fs/wzWXqvTvBYHplPjezohdkj3gvVPyowZdosWaohU2UBnTaMFg3NKRfaD70YjFw68E0 GFq6djTYUgH3iCAtzhbSp+jyznsenRaDgo+xJ/Noh/CZ4Q2npWEakiw80wCXu2Ty7s4L NDH77wpkL8chG/OTkK60MyvdIJga1CDKGLEuOz/aMTkpHfiCFj5irtmRxSjBrgpQGmxX MWdT5dgL3ON6h6LHtYuU6ukAUvQ1UECD23ctpY8/80ZDkQ7CkP7EwAUfXSupXHpsS5sB cJRg== X-Gm-Message-State: AO0yUKUyoR3lqr8mNpSBSp+oph0a/gPBBWs5FaIE6XAdDx2MUjHsXanA 1czw+cgezDyOw5L1BS9zrLvenhdvbp2nWVDNT2UD5S1MDBjFLLi3+awB5vPAkAeS5MJBbtbfLhu TmlFkNX9L5OCeaIwmBK/NauIXZaB7OdKi98c5V8V7kqynQZaReTriH4VAjjzG1AEC6jzCvRobTX owuctZDA== X-Received: by 2002:a05:6870:9a1e:b0:16e:23e5:5b65 with SMTP id fo30-20020a0568709a1e00b0016e23e55b65mr1210916oab.7.1676394914588; Tue, 14 Feb 2023 09:15:14 -0800 (PST) X-Google-Smtp-Source: AK7set8MrMmgViCnPoo/Cyzeh/QLl1zgh3Dd4LDFZA4q8Hj6ALu8f1u78rAjAarpF/d1TfQ/qvZVrw== X-Received: by 2002:a05:6870:9a1e:b0:16e:23e5:5b65 with SMTP id fo30-20020a0568709a1e00b0016e23e55b65mr1210882oab.7.1676394914258; Tue, 14 Feb 2023 09:15:14 -0800 (PST) Received: from halaney-x13s.redhat.com ([2600:1700:1ff0:d0e0::21]) by smtp.gmail.com with ESMTPSA id h18-20020a9d6a52000000b00688449397d3sm6581786otn.15.2023.02.14.09.15.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Feb 2023 09:15:13 -0800 (PST) From: Andrew Halaney To: devicetree@vger.kernel.org Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, alexandre.torgue@foss.st.com, peppe.cavallaro@st.com, joabreu@synopsys.com, mripard@kernel.org, shenwei.wang@nxp.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Andrew Halaney Subject: [PATCH v2 2/2] arm64: dts: imx8dxl-evk: Fix eqos phy reset gpio Date: Tue, 14 Feb 2023 11:15:05 -0600 Message-Id: <20230214171505.224602-2-ahalaney@redhat.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230214171505.224602-1-ahalaney@redhat.com> References: <20230214171505.224602-1-ahalaney@redhat.com> MIME-Version: 1.0 Content-type: text/plain Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The deprecated property is named snps,reset-gpio, but this devicetree used snps,reset-gpios instead which results in the reset not being used and the following make dtbs_check error: ./arch/arm64/boot/dts/freescale/imx8dxl-evk.dtb: ethernet@5b050000: 'snps,reset-gpio' is a dependency of 'snps,reset-delays-us' From schema: ./Documentation/devicetree/bindings/net/snps,dwmac.yaml Use the preferred method of defining the reset gpio in the phy node itself. Note that this drops the 10 us pre-delay, but prior this wasn't used at all and a pre-delay doesn't make much sense in this context so it should be fine. Fixes: 8dd495d12374 ("arm64: dts: freescale: add support for i.MX8DXL EVK board") Signed-off-by: Andrew Halaney --- Changes since v1: * Moved the reset into the ethernet-phy node itself instead of fixing the deprecated usage (for that reason I did not collect Fabio's review tag) arch/arm64/boot/dts/freescale/imx8dxl-evk.dts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts b/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts index 1bcf228a22b8..852420349c01 100644 --- a/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts +++ b/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts @@ -121,8 +121,6 @@ &eqos { phy-handle = <ðphy0>; nvmem-cells = <&fec_mac1>; nvmem-cell-names = "mac-address"; - snps,reset-gpios = <&pca6416_1 2 GPIO_ACTIVE_LOW>; - snps,reset-delays-us = <10 20 200000>; status = "okay"; mdio { @@ -136,6 +134,9 @@ ethphy0: ethernet-phy@0 { eee-broken-1000t; qca,disable-smarteee; qca,disable-hibernation-mode; + reset-gpios = <&pca6416_1 2 GPIO_ACTIVE_LOW>; + reset-assert-us = <20>; + reset-deassert-us = <200000>; vddio-supply = <&vddio0>; vddio0: vddio-regulator { -- 2.39.1