From: Rob Herring <robh@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: Alexander Sverdlin <alexander.sverdlin@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
devicetree@vger.kernel.org,
Hartley Sweeten <hsweeten@visionengravers.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: sound: ep93xx: Add I2S and AC'97 descriptions
Date: Wed, 15 Feb 2023 13:16:48 -0600 [thread overview]
Message-ID: <20230215191648.GA408047-robh@kernel.org> (raw)
In-Reply-To: <Y+uiaqvdIL4IpRlC@sirena.org.uk>
On Tue, Feb 14, 2023 at 03:02:02PM +0000, Mark Brown wrote:
> On Tue, Feb 14, 2023 at 03:26:14PM +0100, Alexander Sverdlin wrote:
> > On Tue, 2023-02-14 at 15:11 +0100, Krzysztof Kozlowski wrote:
>
> > > OK, but then I like the example - if datasheet would use name
> > > "clk_clk_this_is_clk" would you still find it meaningful?
>
> > > Every clock input in clocks is a clock. There is usually no need to say
> > > that a clock is a clock...
>
> > I see you point, but this is legacy code (sound/soc/cirrus/ep93xx-i2s.c)
> > which took these names back in platform data times... I also see that
> > rather majority of *i2s*.yaml use something "*clk", so maybe it could
> > be accepted for legacy code?
>
> Even ignoring the whole legacy thing these are industry standard
> names for the clocks - they are pretty much universally named and
> referred to with the clk suffix. I can't see what removing it
> would accomplish other than reducing clarity.
Agreed.
If a clock is called "Nclk" then I think that is fine. If it is
foo_bar_clk, then yes, 'foo_bar' is preferred.
Rob
next prev parent reply other threads:[~2023-02-15 19:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-12 23:21 [PATCH 1/2] dt-bindings: sound: ep93xx: Add I2S and AC'97 descriptions Alexander Sverdlin
2023-02-12 23:21 ` [PATCH 2/2] ASoC: ep93xx: Add OF support Alexander Sverdlin
2023-02-14 10:58 ` [PATCH 1/2] dt-bindings: sound: ep93xx: Add I2S and AC'97 descriptions Krzysztof Kozlowski
2023-02-14 13:02 ` Alexander Sverdlin
2023-02-14 14:11 ` Krzysztof Kozlowski
2023-02-14 14:26 ` Alexander Sverdlin
2023-02-14 15:02 ` Mark Brown
2023-02-15 19:16 ` Rob Herring [this message]
2023-02-15 19:19 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230215191648.GA408047-robh@kernel.org \
--to=robh@kernel.org \
--cc=alexander.sverdlin@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hsweeten@visionengravers.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).