devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Aradhya Bhatia <a-bhatia1@ti.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Tomi Valkeinen <tomba@kernel.org>,
	Samuel Holland <samuel@sholland.org>,
	Linux Clock List <linux-clk@vger.kernel.org>,
	Devicetree List <devicetree@vger.kernel.org>,
	Linux Kernel List <linux-kernel@vger.kernel.org>,
	Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
	Devarsh Thakkar <devarsht@ti.com>, Jai Luthra <j-luthra@ti.com>
Subject: Re: [PATCH v2 1/2] dt-bindings: clock: Add binding documentation for TI AM62 DSS Clock
Date: Wed, 15 Feb 2023 13:44:36 -0600	[thread overview]
Message-ID: <20230215194436.GA452485-robh@kernel.org> (raw)
In-Reply-To: <20230213115954.553-2-a-bhatia1@ti.com>

On Mon, Feb 13, 2023 at 05:29:53PM +0530, Aradhya Bhatia wrote:
> Add DT bindings for DSS clock divider of TI's AM62 family of SoCs.

Subject: Drop 'binding documentation for '

> 
> Signed-off-by: Aradhya Bhatia <a-bhatia1@ti.com>
> ---
>  .../clock/ti,am62-dss-vp0-div-clk.yaml        | 44 +++++++++++++++++++
>  1 file changed, 44 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/clock/ti,am62-dss-vp0-div-clk.yaml
> 
> diff --git a/Documentation/devicetree/bindings/clock/ti,am62-dss-vp0-div-clk.yaml b/Documentation/devicetree/bindings/clock/ti,am62-dss-vp0-div-clk.yaml
> new file mode 100644
> index 000000000000..310d2a989d5b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/ti,am62-dss-vp0-div-clk.yaml
> @@ -0,0 +1,44 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/ti,am62-dss-vp0-div-clk.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: TI AM62 DSS - OLDI Divider Clock
> +
> +maintainers:
> +  - Aradhya Bhatia <a-bhatia1@ti.com>
> +
> +properties:
> +  compatible:
> +    items:
> +      - const: ti,am62-dss-vp0-div-clk

What's wrong with 'fixed-factor-clock' binding?

> +
> +  "#clock-cells":
> +    const: 0
> +
> +  clocks:
> +    maxItems: 1
> +
> +  clock-div:
> +    description: Fixed divider
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    minimum: 1
> +
> +required:
> +  - compatible
> +  - clocks
> +  - "#clock-cells"
> +  - clock-div
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    clock {
> +      compatible = "ti,am62-dss-vp0-div-clk";
> +      clocks = <&parent_clock>;
> +      #clock-cells = <0>;
> +      clock-div = <7>;
> +    };
> +...
> -- 
> 2.39.1
> 

  reply	other threads:[~2023-02-15 19:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-13 11:59 [PATCH v2 0/2] Introduce support for AM62 DSS VP0 Divider Clock Aradhya Bhatia
2023-02-13 11:59 ` [PATCH v2 1/2] dt-bindings: clock: Add binding documentation for TI AM62 DSS Clock Aradhya Bhatia
2023-02-15 19:44   ` Rob Herring [this message]
2023-02-13 11:59 ` [PATCH v2 2/2] clk: keystone: Add support AM62 DSS clock divider Aradhya Bhatia
2023-03-03 18:02   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230215194436.GA452485-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=a-bhatia1@ti.com \
    --cc=devarsht@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=j-luthra@ti.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=nm@ti.com \
    --cc=samuel@sholland.org \
    --cc=sboyd@kernel.org \
    --cc=ssantosh@kernel.org \
    --cc=tomba@kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).