From: Andre Przywara <andre.przywara@arm.com>
To: Bastian Germann <bage@debian.org>
Cc: Wilken Gottwalt <wilken.gottwalt@posteo.net>,
Ohad Ben-Cohen <ohad@wizery.com>,
Bjorn Andersson <andersson@kernel.org>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Chen-Yu Tsai <wens@csie.org>,
Samuel Holland <samuel@sholland.org>,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 4/5] dt-bindings: hwlock: sun6i: Add a64 compatible string
Date: Wed, 15 Feb 2023 20:49:06 +0000 [thread overview]
Message-ID: <20230215204906.511699f4@slackpad.lan> (raw)
In-Reply-To: <20230215203711.6293-5-bage@debian.org>
On Wed, 15 Feb 2023 21:37:09 +0100
Bastian Germann <bage@debian.org> wrote:
> Add an allwinner,sun50i-a64-hwspinlock compatible string to the device
> tree binding. The A31 and A64 have compatible hwspinlocks.
>
> Signed-off-by: Bastian Germann <bage@debian.org>
> ---
> .../bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml b/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml
> index 6cdfe22deb3c..281c285282a1 100644
> --- a/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml
> +++ b/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml
> @@ -15,7 +15,9 @@ description:
>
> properties:
> compatible:
> - const: allwinner,sun6i-a31-hwspinlock
> + items:
> + - const: allwinner,sun6i-a31-hwspinlock
> + - const: allwinner,sun50i-a64-hwspinlock
So this would not allow the previous single compatible string, which I
think we should preserve?
You can check out other bindings (like allwinner,sun6i-a31-spi.yaml) to
get an idea of how this could be written.
Cheers,
Andre
>
> reg:
> maxItems: 1
next prev parent reply other threads:[~2023-02-15 21:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 20:37 [PATCH v2 0/5] Enable hwlock on Allwinner A64 Bastian Germann
2023-02-15 20:37 ` [PATCH v2 1/5] dt-bindings: hwlock: sun6i: Add missing #hwlock-cells Bastian Germann
2023-02-15 20:37 ` [PATCH v2 2/5] dt-bindings: hwlock: sun6i: Add #hwlock-cells to example Bastian Germann
2023-02-15 20:40 ` Andre Przywara
2023-02-15 20:43 ` Bastian Germann
2023-02-15 23:09 ` Andre Przywara
2023-02-16 8:39 ` Krzysztof Kozlowski
2023-02-15 20:37 ` [PATCH v2 3/5] dt-bindings: hwlock: sun6i: Add missing names Bastian Germann
2023-02-15 20:45 ` Andre Przywara
2023-02-15 20:49 ` Bastian Germann
2023-02-16 8:36 ` Krzysztof Kozlowski
2023-02-16 8:54 ` Wilken Gottwalt
2023-02-15 20:37 ` [PATCH v2 4/5] dt-bindings: hwlock: sun6i: Add a64 compatible string Bastian Germann
2023-02-15 20:49 ` Andre Przywara [this message]
2023-02-15 21:31 ` Rob Herring
2023-02-16 8:38 ` Krzysztof Kozlowski
2023-02-15 20:37 ` [PATCH v2 5/5] arm64: dts: allwinner: a64: Add hwspinlock node Bastian Germann
2023-02-15 20:50 ` Andre Przywara
2023-02-16 8:36 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230215204906.511699f4@slackpad.lan \
--to=andre.przywara@arm.com \
--cc=andersson@kernel.org \
--cc=bage@debian.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=ohad@wizery.com \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
--cc=wilken.gottwalt@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).