From: Janne Grunau <j@jannau.net>
To: Mark Brown <broonie@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Tudor Ambarus <tudor.ambarus@microchip.com>,
linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
Alyssa Rosenzweig <alyssa@rosenzweig.io>,
asahi@lists.linux.dev, linux-kernel@vger.kernel.org,
Hector Martin <marcan@marcan.st>, Kazuki <kazukih0205@gmail.com>
Subject: Re: [PATCH v2 0/3] SPI core CS delay fixes and additions
Date: Thu, 16 Feb 2023 10:04:11 +0100 [thread overview]
Message-ID: <20230216090411.GH17933@jannau.net> (raw)
In-Reply-To: <20230214185234.uj63aovylzixs6xa@kazuki-mac>
Hej Mark,
On 2023-02-15 03:52:34 +0900, Kazuki wrote:
> On Fri, Jan 13, 2023 at 03:57:26PM +0000, Mark Brown wrote:
> > On Fri, 13 Jan 2023 19:23:07 +0900, Hector Martin wrote:
> > > Commits f6c911f3308c ("spi: dt-bindings: Introduce
> > > spi-cs-setup-ns property") and 33a2fde5f77b ("spi: Introduce
> > > spi-cs-setup-ns property") introduced a new property to represent the
> > > CS setup delay in the device tree, but they have some issues:
> > >
> > > - The property is only parsed as a 16-bit integer number of nanoseconds,
> > > which limits the maximum value to ~65us. This is not a reasonable
> > > upper limit, as some devices might need a lot more.
> > > - The property name is inconsistent with other delay properties, which
> > > use a "*-delay-ns" naming scheme.
> > > - Only the setup delay is introduced, but not the related hold and
> > > inactive delay times.
> > >
> > > [...]
> >
> > Applied to
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
> >
> > Thanks!
> >
> > [1/3] spi: Use a 32-bit DT property for spi-cs-setup-delay-ns
> > commit: f276aacf5d2f7fb57e400db44c807ea3b9525fd6
>
> Shouldn't this be sent to 6.2 before the property becomes a stable ABI?
can we still get "spi: Use a 32-bit DT property for
spi-cs-setup-delay-ns" into 6.2?
If not I can send a single line patch which switches
of_property_read_u16() to of_property_read_u32() to avoid defining
"spi-cs-setup-delay-ns" to u16 as stable devicetree ABI.
sorry this comes so late before 6.2, we missed to track the patches.
Thanks,
Janne
next prev parent reply other threads:[~2023-02-16 9:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 10:23 [PATCH v2 0/3] SPI core CS delay fixes and additions Hector Martin
2023-01-13 10:23 ` [PATCH v2 1/3] spi: Use a 32-bit DT property for spi-cs-setup-delay-ns Hector Martin
2023-01-13 10:23 ` [PATCH v2 2/3] spi: dt-bindings: Add hold/inactive CS delay peripheral properties Hector Martin
2023-01-13 10:23 ` [PATCH v2 3/3] spi: Parse hold/inactive CS delay values from the DT Hector Martin
2023-01-13 15:57 ` [PATCH v2 0/3] SPI core CS delay fixes and additions Mark Brown
2023-02-14 18:52 ` Kazuki
2023-02-16 9:04 ` Janne Grunau [this message]
2023-02-16 15:55 ` Mark Brown
2023-02-16 16:21 ` Janne Grunau
2023-02-16 16:25 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230216090411.GH17933@jannau.net \
--to=j@jannau.net \
--cc=alyssa@rosenzweig.io \
--cc=asahi@lists.linux.dev \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kazukih0205@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=robh+dt@kernel.org \
--cc=tudor.ambarus@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).