From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Genjian <zhanggenjian123@gmail.com>
Cc: paulburton@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, linux-mips@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Genjian Zhang <zhanggenjian@kylinos.cn>,
k2ci <kernel-bot@kylinos.cn>
Subject: Re: [PATCH] MIPS: dts: Boston: Fix dtc 'pci_device_reg' warning
Date: Fri, 17 Feb 2023 12:04:37 +0100 [thread overview]
Message-ID: <20230217110437.GC7138@alpha.franken.de> (raw)
In-Reply-To: <20230213062451.1688755-1-zhanggenjian@kylinos.cn>
On Mon, Feb 13, 2023 at 02:24:51PM +0800, Genjian wrote:
> From: Genjian Zhang <zhanggenjian@kylinos.cn>
>
> dtbs_check currently complains that:
> arch/mips/boot/dts/img/boston.dts:128.19-178.5: Warning (pci_device_reg):
> /pci@14000000/pci2_root@0,0,0: PCI unit address format error,
> expected "0,0"
> The unit-address format should be '<device>,<function>'.
> Fix the unit-address accordingly.
>
> Reported-by: k2ci <kernel-bot@kylinos.cn>
> Signed-off-by: Genjian Zhang <zhanggenjian@kylinos.cn>
> ---
> arch/mips/boot/dts/img/boston.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/boot/dts/img/boston.dts b/arch/mips/boot/dts/img/boston.dts
> index 84328afa3a55..72f7605d2e31 100644
> --- a/arch/mips/boot/dts/img/boston.dts
> +++ b/arch/mips/boot/dts/img/boston.dts
> @@ -125,7 +125,7 @@ pci2_intc: interrupt-controller {
> #interrupt-cells = <1>;
> };
>
> - pci2_root@0,0,0 {
> + pci2_root@0,0 {
> compatible = "pci10ee,7021";
> reg = <0x00000000 0 0 0 0>;
>
> --
> 2.25.1
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
prev parent reply other threads:[~2023-02-17 11:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-13 6:24 [PATCH] MIPS: dts: Boston: Fix dtc 'pci_device_reg' warning Genjian
2023-02-13 7:43 ` Philippe Mathieu-Daudé
2023-02-17 11:04 ` Thomas Bogendoerfer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230217110437.GC7138@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=devicetree@vger.kernel.org \
--cc=kernel-bot@kylinos.cn \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=paulburton@kernel.org \
--cc=robh+dt@kernel.org \
--cc=zhanggenjian123@gmail.com \
--cc=zhanggenjian@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).