From: Xingyu Wu <xingyu.wu@starfivetech.com>
To: <linux-riscv@lists.infradead.org>, <devicetree@vger.kernel.org>,
<linux-watchdog@vger.kernel.org>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Philipp Zabel <p.zabel@pengutronix.de>,
Xingyu Wu <xingyu.wu@starfivetech.com>,
Samin Guo <samin.guo@starfivetech.com>,
<linux-kernel@vger.kernel.org>, Conor Dooley <conor@kernel.org>
Subject: [PATCH v3 0/2] Add watchdog driver for StarFive JH7110 RISC-V SoC
Date: Mon, 20 Feb 2023 16:19:24 +0800 [thread overview]
Message-ID: <20230220081926.267695-1-xingyu.wu@starfivetech.com> (raw)
This patch serises are to add watchdog driver for the StarFive JH7110
RISC-V SoC. The first patch adds docunmentation to describe device
tree bindings. The subsequent patch adds watchdog driver and support
JH7110 SoC. And the addition of device tree node will be submitted
after the JH7110 dts merge. This patchset is based on 6.2.
The watchdog driver has been tested on the VisionFive 2 boards which
equip with JH7110 SoC and works normally.
Changes since v2:
- Added watchdog.yaml and unevaluatedProperties in the dt-binding.
- Removed some unnecessary include files.
- Changed the 'module_param' name and dropped 'soft_noboot'.
- Rrmoved 'CONFIG_OF'.
- Added a check if clock rate is 0.
- Modified the max_timeout calculation formula.
- Removed restart function.
- Removed duplicate checks on the upper and lower bounds of 'count'.
- Removed 'started' variable.
- Added pm_runtime_get_sync() and pm_runtime_put_sync().
- Removed 'firmware_version = 0' variable.
- Drop the device tree node commit.
Changes since v1:
- Renamed the dt-binding 'starfive,wdt.yaml' to 'starfive,jh7110-wdt.yaml'.
- Dropped the '_clk' and 'rst_' about the 'clock-names' and 'reset-names'
in the dt-binding.
- Updated the example context in the dt-binding 'starfive,jh7110-wdt.yaml'
to be independent of other patchset.
- Deleted unused macros like 'JH7110_WDOG_INT_EN'.
- Changed the type of 'freq' in the struct from u64 to u32.
- Used 'devm_clk_get_enabled()' instead of 'devm_clk_get()' and
'clk_prepare_enable()'.
- Removed the operation to get the frequency from the device tree.
- Added watchdog_stop_on_unregister() and watchdog_stop_on_reboot().
- Removed any operations about interrupt.
v2: https://lore.kernel.org/all/20221219094233.179153-1-xingyu.wu@starfivetech.com/
v1: https://lore.kernel.org/all/20221202093943.149674-1-xingyu.wu@starfivetech.com/
Xingyu Wu (2):
dt-bindings: watchdog: Add watchdog for StarFive JH7110
drivers: watchdog: Add StarFive Watchdog driver
.../watchdog/starfive,jh7110-wdt.yaml | 74 ++
MAINTAINERS | 7 +
drivers/watchdog/Kconfig | 9 +
drivers/watchdog/Makefile | 2 +
drivers/watchdog/starfive-wdt.c | 651 ++++++++++++++++++
5 files changed, 743 insertions(+)
create mode 100644 Documentation/devicetree/bindings/watchdog/starfive,jh7110-wdt.yaml
create mode 100644 drivers/watchdog/starfive-wdt.c
base-commit: c9c3395d5e3dcc6daee66c6908354d47bf98cb0c
--
2.25.1
next reply other threads:[~2023-02-20 8:19 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-20 8:19 Xingyu Wu [this message]
2023-02-20 8:19 ` [PATCH v3 1/2] dt-bindings: watchdog: Add watchdog for StarFive JH7110 Xingyu Wu
2023-02-20 11:46 ` Krzysztof Kozlowski
2023-02-20 8:19 ` [PATCH v3 2/2] drivers: watchdog: Add StarFive Watchdog driver Xingyu Wu
2023-02-23 18:23 ` Guenter Roeck
2023-02-24 7:42 ` Xingyu Wu
2023-02-24 15:18 ` Guenter Roeck
2023-02-27 6:26 ` Xingyu Wu
2023-02-27 6:36 ` Guenter Roeck
2023-02-27 6:45 ` Xingyu Wu
2023-02-27 14:50 ` Guenter Roeck
2023-02-28 2:07 ` Xingyu Wu
2023-02-26 14:14 ` Emil Renner Berthing
2023-02-26 14:33 ` Conor Dooley
2023-02-27 1:47 ` Xingyu Wu
2023-02-28 9:44 ` Xingyu Wu
2023-02-28 10:36 ` Emil Renner Berthing
2023-02-28 10:51 ` Conor Dooley
2023-02-28 10:57 ` Krzysztof Kozlowski
2023-02-28 11:11 ` Conor Dooley
2023-02-28 13:16 ` Xingyu Wu
2023-02-28 14:03 ` Krzysztof Kozlowski
2023-02-28 15:10 ` Guenter Roeck
2023-02-28 15:32 ` Emil Renner Berthing
2023-03-01 3:40 ` Xingyu Wu
2023-02-28 14:59 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230220081926.267695-1-xingyu.wu@starfivetech.com \
--to=xingyu.wu@starfivetech.com \
--cc=aou@eecs.berkeley.edu \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=p.zabel@pengutronix.de \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=samin.guo@starfivetech.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).