* [PATCH] dt-bindings: display: Start the info graphics with HS/VS change
@ 2023-02-21 20:04 Marek Vasut
2023-02-22 17:29 ` Sam Ravnborg
2023-02-26 20:02 ` Rob Herring
0 siblings, 2 replies; 3+ messages in thread
From: Marek Vasut @ 2023-02-21 20:04 UTC (permalink / raw)
To: dri-devel
Cc: Marek Vasut, Daniel Vetter, David Airlie, Krzysztof Kozlowski,
Rob Herring, Sam Ravnborg, Thierry Reding, devicetree
The VS signal change is synchronized to HS signal change, start the
info graphics with that event, instead of having that event occur in
the middle of it.
Scope trace of DPI bus with HS/VS active HIGH looks as follows:
________________...__
VS...___/__ __ \______...
HS...___/ \_______/ \__...__/ \___...
^ ^
| |
| Used to start here -'
|
'--- Start info graphics here
Signed-off-by: Marek Vasut <marex@denx.de>
---
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: David Airlie <airlied@gmail.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: devicetree@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
---
.../bindings/display/panel/panel-timing.yaml | 46 +++++++++----------
1 file changed, 23 insertions(+), 23 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/panel/panel-timing.yaml b/Documentation/devicetree/bindings/display/panel/panel-timing.yaml
index 0d317e61edd8f..aea69b84ca5d8 100644
--- a/Documentation/devicetree/bindings/display/panel/panel-timing.yaml
+++ b/Documentation/devicetree/bindings/display/panel/panel-timing.yaml
@@ -17,29 +17,29 @@ description: |
The parameters are defined as seen in the following illustration.
- +----------+-------------------------------------+----------+-------+
- | | ^ | | |
- | | |vback_porch | | |
- | | v | | |
- +----------#######################################----------+-------+
- | # ^ # | |
- | # | # | |
- | hback # | # hfront | hsync |
- | porch # | hactive # porch | len |
- |<-------->#<-------+--------------------------->#<-------->|<----->|
- | # | # | |
- | # |vactive # | |
- | # | # | |
- | # v # | |
- +----------#######################################----------+-------+
- | | ^ | | |
- | | |vfront_porch | | |
- | | v | | |
- +----------+-------------------------------------+----------+-------+
- | | ^ | | |
- | | |vsync_len | | |
- | | v | | |
- +----------+-------------------------------------+----------+-------+
+ +-------+----------+-------------------------------------+----------+
+ | | | ^ | |
+ | | | |vsync_len | |
+ | | | v | |
+ +-------+----------+-------------------------------------+----------+
+ | | | ^ | |
+ | | | |vback_porch | |
+ | | | v | |
+ +-------+----------#######################################----------+
+ | | # ^ # |
+ | | # | # |
+ | hsync | hback # | # hfront |
+ | len | porch # | hactive # porch |
+ |<----->|<-------->#<-------+--------------------------->#<-------->|
+ | | # | # |
+ | | # |vactive # |
+ | | # | # |
+ | | # v # |
+ +-------+----------#######################################----------+
+ | | | ^ | |
+ | | | |vfront_porch | |
+ | | | v | |
+ +-------+----------+-------------------------------------+----------+
The following is the panel timings shown with time on the x-axis.
--
2.39.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] dt-bindings: display: Start the info graphics with HS/VS change
2023-02-21 20:04 [PATCH] dt-bindings: display: Start the info graphics with HS/VS change Marek Vasut
@ 2023-02-22 17:29 ` Sam Ravnborg
2023-02-26 20:02 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Sam Ravnborg @ 2023-02-22 17:29 UTC (permalink / raw)
To: Marek Vasut
Cc: dri-devel, Daniel Vetter, David Airlie, Krzysztof Kozlowski,
Rob Herring, Thierry Reding, devicetree
Hi Marek.
On Tue, Feb 21, 2023 at 09:04:07PM +0100, Marek Vasut wrote:
> The VS signal change is synchronized to HS signal change, start the
> info graphics with that event, instead of having that event occur in
> the middle of it.
>
> Scope trace of DPI bus with HS/VS active HIGH looks as follows:
> ________________...__
> VS...___/__ __ \______...
> HS...___/ \_______/ \__...__/ \___...
> ^ ^
> | |
> | Used to start here -'
> |
> '--- Start info graphics here
>
> Signed-off-by: Marek Vasut <marex@denx.de>
I recall being annoyed about this before.
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
> ---
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: devicetree@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> ---
> .../bindings/display/panel/panel-timing.yaml | 46 +++++++++----------
> 1 file changed, 23 insertions(+), 23 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-timing.yaml b/Documentation/devicetree/bindings/display/panel/panel-timing.yaml
> index 0d317e61edd8f..aea69b84ca5d8 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-timing.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-timing.yaml
> @@ -17,29 +17,29 @@ description: |
>
> The parameters are defined as seen in the following illustration.
>
> - +----------+-------------------------------------+----------+-------+
> - | | ^ | | |
> - | | |vback_porch | | |
> - | | v | | |
> - +----------#######################################----------+-------+
> - | # ^ # | |
> - | # | # | |
> - | hback # | # hfront | hsync |
> - | porch # | hactive # porch | len |
> - |<-------->#<-------+--------------------------->#<-------->|<----->|
> - | # | # | |
> - | # |vactive # | |
> - | # | # | |
> - | # v # | |
> - +----------#######################################----------+-------+
> - | | ^ | | |
> - | | |vfront_porch | | |
> - | | v | | |
> - +----------+-------------------------------------+----------+-------+
> - | | ^ | | |
> - | | |vsync_len | | |
> - | | v | | |
> - +----------+-------------------------------------+----------+-------+
> + +-------+----------+-------------------------------------+----------+
> + | | | ^ | |
> + | | | |vsync_len | |
> + | | | v | |
> + +-------+----------+-------------------------------------+----------+
> + | | | ^ | |
> + | | | |vback_porch | |
> + | | | v | |
> + +-------+----------#######################################----------+
> + | | # ^ # |
> + | | # | # |
> + | hsync | hback # | # hfront |
> + | len | porch # | hactive # porch |
> + |<----->|<-------->#<-------+--------------------------->#<-------->|
> + | | # | # |
> + | | # |vactive # |
> + | | # | # |
> + | | # v # |
> + +-------+----------#######################################----------+
> + | | | ^ | |
> + | | | |vfront_porch | |
> + | | | v | |
> + +-------+----------+-------------------------------------+----------+
>
>
> The following is the panel timings shown with time on the x-axis.
> --
> 2.39.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: display: Start the info graphics with HS/VS change
2023-02-21 20:04 [PATCH] dt-bindings: display: Start the info graphics with HS/VS change Marek Vasut
2023-02-22 17:29 ` Sam Ravnborg
@ 2023-02-26 20:02 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2023-02-26 20:02 UTC (permalink / raw)
To: Marek Vasut
Cc: Krzysztof Kozlowski, Daniel Vetter, David Airlie, dri-devel,
Rob Herring, Thierry Reding, devicetree, Sam Ravnborg
On Tue, 21 Feb 2023 21:04:07 +0100, Marek Vasut wrote:
> The VS signal change is synchronized to HS signal change, start the
> info graphics with that event, instead of having that event occur in
> the middle of it.
>
> Scope trace of DPI bus with HS/VS active HIGH looks as follows:
> ________________...__
> VS...___/__ __ \______...
> HS...___/ \_______/ \__...__/ \___...
> ^ ^
> | |
> | Used to start here -'
> |
> '--- Start info graphics here
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> ---
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: devicetree@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> ---
> .../bindings/display/panel/panel-timing.yaml | 46 +++++++++----------
> 1 file changed, 23 insertions(+), 23 deletions(-)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-26 20:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-21 20:04 [PATCH] dt-bindings: display: Start the info graphics with HS/VS change Marek Vasut
2023-02-22 17:29 ` Sam Ravnborg
2023-02-26 20:02 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).