From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Rob Clark <robdclark@gmail.com>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Sean Paul <sean@poorly.run>, David Airlie <airlied@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Akhil P Oommen <quic_akhilpo@quicinc.com>
Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Rob Clark <robdclark@chromium.org>,
Marijn Suijten <marijn.suijten@somainline.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>
Subject: [PATCH v4 07/14] drm/msm/adreno: Disable has_cached_coherent in GMU wrapper configurations
Date: Tue, 14 Mar 2023 16:28:38 +0100 [thread overview]
Message-ID: <20230223-topic-gmuwrapper-v4-7-e987eb79d03f@linaro.org> (raw)
In-Reply-To: <20230223-topic-gmuwrapper-v4-0-e987eb79d03f@linaro.org>
A610 and A619_holi don't support the feature. Disable it to make the GPU stop
crashing after almost each and every submission - the received data on
the GPU end was simply incomplete in garbled, resulting in almost nothing
being executed properly. Extend the disablement to adreno_has_gmu_wrapper,
as none of the GMU wrapper Adrenos that don't support yet seem to feature it.
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
drivers/gpu/drm/msm/adreno/adreno_device.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/adreno/adreno_device.c b/drivers/gpu/drm/msm/adreno/adreno_device.c
index f35392c034f7..6513c6094865 100644
--- a/drivers/gpu/drm/msm/adreno/adreno_device.c
+++ b/drivers/gpu/drm/msm/adreno/adreno_device.c
@@ -540,7 +540,6 @@ static int adreno_bind(struct device *dev, struct device *master, void *data)
config.rev.minor, config.rev.patchid);
priv->is_a2xx = config.rev.core == 2;
- priv->has_cached_coherent = config.rev.core >= 6;
gpu = info->init(drm);
if (IS_ERR(gpu)) {
@@ -552,6 +551,10 @@ static int adreno_bind(struct device *dev, struct device *master, void *data)
if (ret)
return ret;
+ if (config.rev.core >= 6)
+ if (!adreno_has_gmu_wrapper(to_adreno_gpu(gpu)))
+ priv->has_cached_coherent = true;
+
return 0;
}
--
2.39.2
next prev parent reply other threads:[~2023-03-14 15:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 15:28 [PATCH v4 00/14] GMU-less A6xx support (A610, A619_holi) Konrad Dybcio
2023-03-14 15:28 ` [PATCH v4 01/14] dt-bindings: display/msm: gpu: Document GMU wrapper-equipped A6xx Konrad Dybcio
2023-03-16 6:59 ` Krzysztof Kozlowski
2023-03-14 15:28 ` [PATCH v4 02/14] dt-bindings: display/msm/gmu: Add GMU wrapper Konrad Dybcio
2023-03-16 7:09 ` Krzysztof Kozlowski
2023-03-14 15:28 ` [PATCH v4 03/14] drm/msm/a6xx: Remove static keyword from sptprac en/disable functions Konrad Dybcio
2023-03-14 15:28 ` [PATCH v4 04/14] drm/msm/a6xx: Extend and explain UBWC config Konrad Dybcio
2023-03-25 18:33 ` Rob Clark
2023-03-14 15:28 ` [PATCH v4 05/14] drm/msm/a6xx: Introduce GMU wrapper support Konrad Dybcio
2023-03-14 15:28 ` [PATCH v4 06/14] drm/msm/a6xx: Remove both GBIF and RBBM GBIF halt on hw init Konrad Dybcio
2023-03-28 15:35 ` Dmitry Baryshkov
2023-03-14 15:28 ` Konrad Dybcio [this message]
2023-03-14 15:28 ` [PATCH v4 08/14] drm/msm/a6xx: Add support for A619_holi Konrad Dybcio
2023-03-14 15:28 ` [PATCH v4 09/14] drm/msm/a6xx: Add A610 support Konrad Dybcio
2023-03-14 15:28 ` [PATCH v4 10/14] drm/msm/a6xx: Fix some A619 tunables Konrad Dybcio
2023-03-14 15:28 ` [PATCH v4 11/14] drm/msm/a6xx: Use "else if" in GPU speedbin rev matching Konrad Dybcio
2023-03-14 15:28 ` [PATCH v4 12/14] drm/msm/a6xx: Use adreno_is_aXYZ macros in speedbin matching Konrad Dybcio
2023-03-28 15:30 ` Dmitry Baryshkov
2023-03-14 15:28 ` [PATCH v4 13/14] drm/msm/a6xx: Add A619_holi speedbin support Konrad Dybcio
2023-03-28 15:31 ` Dmitry Baryshkov
2023-03-14 15:28 ` [PATCH v4 14/14] drm/msm/a6xx: Add A610 " Konrad Dybcio
2023-03-28 15:32 ` Dmitry Baryshkov
2023-03-29 1:12 ` [PATCH v4 00/14] GMU-less A6xx support (A610, A619_holi) Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230223-topic-gmuwrapper-v4-7-e987eb79d03f@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_akhilpo@quicinc.com \
--cc=robdclark@chromium.org \
--cc=robdclark@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).