Re: [PATCH] ARM64: dts: debix model-a: enable hdmi

[Marco Felsch <m.felsch@pengutronix.de>]

Hi,

thanks for your patch, please see my comments below.

On 23-02-25, Krzysztof Kozlowski wrote:
> On 25/02/2023 15:25, Hardevsinh Palaniya wrote:
> > From: HardevSinh Palaniya <hardevsinh.palaniya@siliconsignals.io>
> > Date: Sat, 25 Feb 2023 19:38:20 +0530
> > Subject: [PATCH] arm64: dts: debix model-a: enable hdmi
> 
> Your patch is corrupted... See above.
> 
> > 
> > Enable HDMI support for Polyhex Debix Model A Board
> 
> Use subject prefixes matching the subsystem (which you can get for
> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
> your patch is touching).
> 
> > 
> > Signed-off-by: HardevSinh Palaniya <hardevsinh.palaniya@siliconsignals.io>
> > 
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts b/arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts
> > index 2876d18f2a38..bc2515113ae3 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts
> > @@ -45,6 +45,43 @@ reg_usdhc2_vmmc: regulator-usdhc2 {
> >  	};
> >  };
> >  
> > +
> 
> No need for two blank lines, but one.
> 
> 
> > +&irqsteer_hdmi {
> > +	status = "okay";
> > +};
> > +
> > +&hdmi_blk_ctrl {
> > +	status = "okay";
> > +};
> > +
> > +&hdmi_pavi {
> > +	status = "okay";
> > +};
> > +
> > +&hdmi {
> > +	status = "okay";
> > +};
> > +
> > +&hdmiphy {
> > +	status = "okay";
> > +};
> > +
> > +&lcdif1 {
> > +	status = "okay";
> > +};
> > +
> > +&lcdif2 {
> > +	status = "okay";
> > +};
> > +
> > +&lcdif3 {
> > +	status = "okay";
> > +
> > +	thres-low  = <1 2>;             /* (FIFO * 1 / 2) */
> > +	thres-high = <3 4>;             /* (FIFO * 3 / 4) */

Isn't this a downstream property?

Regards,
  Marco

> > +};
> > +
> > +
> 
> Same problem.
> 
> >  &A53_0 {
> >  	cpu-supply = <&buck2>;
> >  };
> 
> Best regards,
> Krzysztof
> 
> 
>