From: Chancel Liu <chancel.liu@nxp.com>
To: lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, perex@perex.cz,
tiwai@suse.com, ckeepax@opensource.cirrus.com,
patches@opensource.cirrus.com, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Cc: Chancel Liu <chancel.liu@nxp.com>
Subject: [PATCH v2 2/2] ASoC: wm8524: Correct the MUTE setting while power up/down
Date: Mon, 27 Feb 2023 17:19:38 +0800 [thread overview]
Message-ID: <20230227091938.1671416-2-chancel.liu@nxp.com> (raw)
In-Reply-To: <20230227091938.1671416-1-chancel.liu@nxp.com>
wm8524 should be unmuted while power up and muted while power down.
Signed-off-by: Chancel Liu <chancel.liu@nxp.com>
---
sound/soc/codecs/wm8524.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/wm8524.c b/sound/soc/codecs/wm8524.c
index b56dcac60244..8f2130e05b32 100644
--- a/sound/soc/codecs/wm8524.c
+++ b/sound/soc/codecs/wm8524.c
@@ -75,7 +75,7 @@ static int wm8524_startup(struct snd_pcm_substream *substream,
SNDRV_PCM_HW_PARAM_RATE,
&wm8524->rate_constraint);
- gpiod_set_value_cansleep(wm8524->mute, 1);
+ gpiod_set_value_cansleep(wm8524->mute, 0);
return 0;
}
@@ -86,7 +86,7 @@ static void wm8524_shutdown(struct snd_pcm_substream *substream,
struct snd_soc_component *component = dai->component;
struct wm8524_priv *wm8524 = snd_soc_component_get_drvdata(component);
- gpiod_set_value_cansleep(wm8524->mute, 0);
+ gpiod_set_value_cansleep(wm8524->mute, 1);
}
static int wm8524_set_dai_sysclk(struct snd_soc_dai *codec_dai,
--
2.25.1
next prev parent reply other threads:[~2023-02-27 9:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-27 9:19 [PATCH v2 1/2] ASoC: dt-bindings: wlf,wm8524: Convert to json-schema Chancel Liu
2023-02-27 9:19 ` Chancel Liu [this message]
2023-03-01 21:07 ` [PATCH v2 2/2] ASoC: wm8524: Correct the MUTE setting while power up/down Mark Brown
2023-02-28 8:15 ` [PATCH v2 1/2] ASoC: dt-bindings: wlf,wm8524: Convert to json-schema Krzysztof Kozlowski
2023-03-01 21:08 ` Mark Brown
2023-03-06 13:32 ` (subset) " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230227091938.1671416-2-chancel.liu@nxp.com \
--to=chancel.liu@nxp.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).