From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A915EC64ED8 for ; Mon, 27 Feb 2023 18:53:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229900AbjB0Sxe (ORCPT ); Mon, 27 Feb 2023 13:53:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34040 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229595AbjB0Sxe (ORCPT ); Mon, 27 Feb 2023 13:53:34 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4A681041E for ; Mon, 27 Feb 2023 10:53:32 -0800 (PST) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pWicd-0002aM-JC; Mon, 27 Feb 2023 19:53:15 +0100 Received: from mfe by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1pWicb-0008Ja-93; Mon, 27 Feb 2023 19:53:13 +0100 Date: Mon, 27 Feb 2023 19:53:13 +0100 From: Marco Felsch To: Marek Vasut Cc: linux-clk@vger.kernel.org, Rob Herring , Adam Ford , Alexander Stein , Abel Vesa , Fabio Estevam , Jacky Bai , Krzysztof Kozlowski , Laurent Pinchart , Luca Ceresoli , Lucas Stach , Michael Turquette , NXP Linux Team , Peng Fan , Pengutronix Kernel Team , Richard Cochran , Rob Herring , Sascha Hauer , Shawn Guo , Stephen Boyd , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v5 3/5] dt-bindings: clock: imx8mp: Add audiomix block control Message-ID: <20230227185313.sfuc3nehayjxbhqw@pengutronix.de> References: <20230227174308.87286-1-marex@denx.de> <20230227174308.87286-3-marex@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230227174308.87286-3-marex@denx.de> User-Agent: NeoMutt/20180716 X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: mfe@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Marek, sorry for the late review on this, please see below. On 23-02-27, Marek Vasut wrote: > Unlike the other block control IPs in i.MX8M, the audiomix is mostly a > series of clock gates and muxes. Add DT bindings for this IP. > > Reviewed-by: Rob Herring > Tested-by: Adam Ford #imx8mp-beacon-kit > Tested-by: Alexander Stein > Signed-off-by: Marek Vasut > --- > Cc: Abel Vesa > Cc: Alexander Stein > Cc: Fabio Estevam > Cc: Jacky Bai > Cc: Krzysztof Kozlowski > Cc: Laurent Pinchart > Cc: Luca Ceresoli > Cc: Lucas Stach > Cc: Marco Felsch > Cc: Michael Turquette > Cc: NXP Linux Team > Cc: Peng Fan > Cc: Pengutronix Kernel Team > Cc: Richard Cochran > Cc: Rob Herring > Cc: Sascha Hauer > Cc: Shawn Guo > Cc: Stephen Boyd > Cc: devicetree@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-clk@vger.kernel.org > --- > V2: No change > V3: - Add missed RB from Rob from V1 > - Rename audio_ahb to plain ahb > V4: - Rebase on next 20230223 > V5: Add TB from Adam and Alexander > --- > .../bindings/clock/imx8mp-audiomix.yaml | 84 +++++++++++++++++++ > 1 file changed, 84 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/imx8mp-audiomix.yaml > > diff --git a/Documentation/devicetree/bindings/clock/imx8mp-audiomix.yaml b/Documentation/devicetree/bindings/clock/imx8mp-audiomix.yaml > new file mode 100644 > index 0000000000000..01b4e1e311cef > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/imx8mp-audiomix.yaml > @@ -0,0 +1,84 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/clock/imx8mp-audiomix.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NXP i.MX8MP AudioMIX Block Control Binding > + > +maintainers: > + - Marek Vasut > + > +description: | > + NXP i.MX8M Plus AudioMIX is dedicated clock muxing and gating IP > + used to control Audio related clock on the SoC. > + > +properties: > + compatible: > + const: fsl,imx8mp-audio-blk-ctrl > + > + reg: > + maxItems: 1 > + > + power-domains: > + maxItems: 1 > + > + power-domain-names: > + const: audio Why do we need to specify the name here? We have just one power-domain, so there should be no need to distinguish between them, or do I miss something? > + > + clocks: > + minItems: 7 > + maxItems: 7 > + > + clock-names: > + items: > + - const: ahb > + - const: sai1 > + - const: sai2 > + - const: sai3 > + - const: sai5 > + - const: sai6 > + - const: sai7 > + > + '#clock-cells': > + const: 1 > + description: > + The clock consumer should specify the desired clock by having the clock > + ID in its "clocks" phandle cell. See include/dt-bindings/clock/imx8mp-clock.h > + for the full list of i.MX8MP IMX8MP_CLK_AUDIOMIX_ clock IDs. > + > +required: > + - compatible > + - reg > + - power-domains > + - power-domain-names We can drop the power-domain-names here as well. > + - clocks > + - clock-names > + - '#clock-cells' > + > +additionalProperties: false > + > +examples: > + # Clock Control Module node: > + - | > + #include > + > + clock-controller@30e20000 { > + #clock-cells = <1>; > + compatible = "fsl,imx8mp-audio-blk-ctrl"; > + clocks = <&clk IMX8MP_CLK_AUDIO_ROOT>, > + <&clk IMX8MP_CLK_SAI1>, > + <&clk IMX8MP_CLK_SAI2>, > + <&clk IMX8MP_CLK_SAI3>, > + <&clk IMX8MP_CLK_SAI5>, > + <&clk IMX8MP_CLK_SAI6>, > + <&clk IMX8MP_CLK_SAI7>; > + clock-names = "ahb", > + "sai1", "sai2", "sai3", > + "sai5", "sai6", "sai7"; > + power-domains = <&pgc_audio>; > + power-domain-names = "audio"; > + reg = <0x30e20000 0x10000>; It is common to have have the compatible as the first property followed by the reg property. We should change this here as well as in the 8mp.dtsi patch. Regards, Marco > + }; > + > +... > -- > 2.39.2 > >