From: shravan kumar <shravan.chippa@microchip.com>
To: <paul.j.murphy@intel.com>, <daniele.alessandrelli@intel.com>,
<mchehab@kernel.org>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <shawnguo@kernel.org>,
<s.hauer@pengutronix.de>
Cc: <kernel@pengutronix.de>, <festevam@gmail.com>,
<linux-imx@nxp.com>, <linux-media@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<shravan.chippa@microchip.com>,
Jacopo Mondi <jacopo.mondi@ideasonboard.com>,
Jacopo Mondi <jacopo@jmondi.org>
Subject: [PATCH v12 1/5] media: i2c: imx334: replace __v4l2_ctrl_s_ctrl to __v4l2_ctrl_modify_range
Date: Wed, 1 Mar 2023 13:04:08 +0530 [thread overview]
Message-ID: <20230301073412.1204574-2-shravan.chippa@microchip.com> (raw)
In-Reply-To: <20230301073412.1204574-1-shravan.chippa@microchip.com>
From: Shravan Chippa <shravan.chippa@microchip.com>
For evry mode we will get new set of values for hbalnk so use
__v4l2_ctrl_modify_range() to support multi modes for hblank.
The hblank value is readonly in the driver. because of this the function
returns error if we try to change. so added dumy return case in
imx334_set_ctrl function.
Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Suggested-by: Jacopo Mondi <jacopo@jmondi.org>
Signed-off-by: Shravan Chippa <shravan.chippa@microchip.com>
---
drivers/media/i2c/imx334.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/media/i2c/imx334.c b/drivers/media/i2c/imx334.c
index 7b0a9086447d..ebacba3059b3 100644
--- a/drivers/media/i2c/imx334.c
+++ b/drivers/media/i2c/imx334.c
@@ -382,7 +382,8 @@ static int imx334_update_controls(struct imx334 *imx334,
if (ret)
return ret;
- ret = __v4l2_ctrl_s_ctrl(imx334->hblank_ctrl, mode->hblank);
+ ret = __v4l2_ctrl_modify_range(imx334->hblank_ctrl, mode->hblank,
+ mode->hblank, 1, mode->hblank);
if (ret)
return ret;
@@ -480,6 +481,9 @@ static int imx334_set_ctrl(struct v4l2_ctrl *ctrl)
pm_runtime_put(imx334->dev);
+ break;
+ case V4L2_CID_HBLANK:
+ ret = 0;
break;
default:
dev_err(imx334->dev, "Invalid control %d", ctrl->id);
--
2.34.1
next prev parent reply other threads:[~2023-03-01 7:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-01 7:34 [PATCH v12 0/5] media: i2c: imx334: support lower bandwidth mode shravan kumar
2023-03-01 7:34 ` shravan kumar [this message]
2023-03-01 7:34 ` [PATCH v12 2/5] media: i2c: imx334: add missing reset values for mode 3840x2160_regs[] shravan kumar
2023-03-01 7:34 ` [PATCH v12 3/5] media: i2c: imx334: support lower bandwidth mode shravan kumar
2023-03-01 7:34 ` [PATCH v12 4/5] dt-bindings: media: i2c: imx334 add new link_freq shravan kumar
2023-03-01 7:34 ` [PATCH v12 5/5] media: i2c: imx334: update pixel and link frequency shravan kumar
2023-03-14 19:05 ` Sakari Ailus
2023-03-21 15:41 ` Shravan.Chippa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230301073412.1204574-2-shravan.chippa@microchip.com \
--to=shravan.chippa@microchip.com \
--cc=daniele.alessandrelli@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=jacopo.mondi@ideasonboard.com \
--cc=jacopo@jmondi.org \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=paul.j.murphy@intel.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).