From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86506C64EC4 for ; Fri, 3 Mar 2023 12:30:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230042AbjCCMaf (ORCPT ); Fri, 3 Mar 2023 07:30:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45726 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230071AbjCCMab (ORCPT ); Fri, 3 Mar 2023 07:30:31 -0500 Received: from mail-pg1-x535.google.com (mail-pg1-x535.google.com [IPv6:2607:f8b0:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 832575D754 for ; Fri, 3 Mar 2023 04:30:30 -0800 (PST) Received: by mail-pg1-x535.google.com with SMTP id z10so1347474pgr.8 for ; Fri, 03 Mar 2023 04:30:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=wKCLv1hgI86xhnJ8PFNiyFksPKMl3hpg2oT8pYQZNSw=; b=r+wRZBS/rNchorFCHPRKq4PVeBobHOUJa1wtGCGLSJgwilzMDQH3ehLoh/rn29QdmW dxg9EbpyYOhiZW4t3Fr+FGvRjR3keD9TAspcLBCCAeftqctPejsfxspLJbd4ab/5gXqj Qw8KGInTBYctfa0OlwZBBLfVd9SfLcImW7fvzIPVkftLnm5vAi82yih3Y4w32vqUC4Ts xp6SakQ0kTKLl8z77XI3BMtEBgWhj7zO03lhPihiSTSBNEwQcRXOVZg6vGXEYw/W4Rkg O1vOSu3ljTpsKMFOFy0hemO48BbkicInFTdMxatU2wWgYjkiGz9DmiiH36cUljAa79+e zS+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wKCLv1hgI86xhnJ8PFNiyFksPKMl3hpg2oT8pYQZNSw=; b=C7AjmbKkg8RX1rbrRUB8GsFTrsX2R3wRgZcTwPtdHztsAxsS31iHEQTGQRYwA/agyH g6K0c3XTqaQSkH/Ni0mC0fWzfuANsedLbZx3+8ZRuGAWQJwHLpsRTe9aEZLei8cZs86u U4XAjFXyJRpwlpHEDzzpZMntgyUDow7/14fgXOvS1a8B9/yoOdGWp+a/qAzg46EXQC6n KELfMmfzUOIYR6Zw/VKzzNVi7hoOngOdwaOfgJiiweNGQRqYz579SzDsRpN8T594ZDLC D+bBYu0JylurHUrsumhvpCbMUgBwSMi3guYrCRRjPj4mfPtnauNH8+Fi+fsyybD8DR+j g0SA== X-Gm-Message-State: AO0yUKUFCqARekXp/UdH47VoKVQ7LfWJ8fUFJCPI1i8lY3h8L0xA6id8 27ssGUII4ISvDl6V51ZC2pLH X-Google-Smtp-Source: AK7set97iZEg+efZSyPVoEaAWnXYHtkgTBA9aWCb/R6Ep2v8/b9tq4QhMQNui/I52feyiJqe6CkTLQ== X-Received: by 2002:a62:7982:0:b0:5a9:d676:ae58 with SMTP id u124-20020a627982000000b005a9d676ae58mr2152089pfc.13.1677846629953; Fri, 03 Mar 2023 04:30:29 -0800 (PST) Received: from thinkpad ([117.207.30.104]) by smtp.gmail.com with ESMTPSA id n13-20020aa7904d000000b0058b927b9653sm1542681pfo.92.2023.03.03.04.30.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Mar 2023 04:30:29 -0800 (PST) Date: Fri, 3 Mar 2023 18:00:22 +0530 From: Manivannan Sadhasivam To: Lee Jones Cc: jacek.anaszewski@gmail.com, pavel@ucw.cz, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, thunder.leizhen@huawei.com, festevam@gmail.com Subject: Re: [PATCH v6] dt-bindings: leds: Document commonly used LED triggers Message-ID: <20230303123022.GA6782@thinkpad> References: <20230213072133.5977-1-manivannan.sadhasivam@linaro.org> <20230303103407.GR2303077@google.com> <20230303113945.GF2420672@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230303113945.GF2420672@google.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Mar 03, 2023 at 11:39:45AM +0000, Lee Jones wrote: > On Fri, 03 Mar 2023, Lee Jones wrote: > > > On Mon, 13 Feb 2023, Manivannan Sadhasivam wrote: > > > > > Document the commonly used LED triggers by the SoCs. Not all triggers > > > are documented as some of them are very application specific. Most of the > > > triggers documented here are currently used in devicetrees of many SoCs. > > > > > > While at it, also place the comment above the triggers (hci, mmc, wlan) > > > to match the rest of the binding. > > > > > > Signed-off-by: Manivannan Sadhasivam > > > --- > > > > > > Changes in v6: > > > > > > * Rebased on top of lee/for-leds-next branch > > > * Fixed the comment location for few triggers > > > > > > Changes in v5: > > > > > > * Rebased on top of v6.2-rc1 > > > > > > Changes in v4: > > > > > > * Removed the sorting of triggers > > > * Removed the "items" as they were not needed > > > * Reworded the description > > > * Dropped Zhen Lei's tested-by tag as the patch has changed > > > * Added kbd-capslock trigger > > > > > > Changes in v3: > > > > > > * Rebased on top of v6.1-rc1 > > > * Added WLAN Rx trigger > > > * Added tested tag from Zhen Lei > > > > > > Changes in v2: > > > > > > * Added more triggers, fixed the regex > > > * Sorted triggers in ascending order > > > > > > .../devicetree/bindings/leds/common.yaml | 37 +++++++++++++++++-- > > > 1 file changed, 34 insertions(+), 3 deletions(-) > > > > Applied, thanks > > Change of plan. This doesn't apply cleanly. > > Could you please rebase and resubmit please? > Done! Thanks, Mani > -- > Lee Jones [李琼斯] -- மணிவண்ணன் சதாசிவம்