From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Rafał Miłecki" <rafal@milecki.pl>,
"Srinivas Kandagatla" <srinivas.kandagatla@linaro.org>,
linux-kernel@vger.kernel.org, "Michael Walle" <michael@walle.cc>,
devicetree@vger.kernel.org, "Rob Herring" <robh+dt@kernel.org>,
"Frank Rowand" <frowand.list@gmail.com>,
"Robert Marko" <robert.marko@sartura.hr>,
"Luka Perkov" <luka.perkov@sartura.hr>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH 0/8] nvmem: Let layout drivers be modules
Date: Mon, 6 Mar 2023 16:00:23 +0100 [thread overview]
Message-ID: <20230306160023.40171f2e@xps-13> (raw)
In-Reply-To: <ZAXw4EHQldOi35gJ@kroah.com>
Hello,
gregkh@linuxfoundation.org wrote on Mon, 6 Mar 2023 14:55:44 +0100:
> On Mon, Mar 06, 2023 at 02:54:10PM +0100, Rafał Miłecki wrote:
> > On 2023-03-01 16:22, Miquel Raynal wrote:
> > > The base series on which these changes apply is still contained in [1],
> > > I would prefer to keep it as it was and apply this series on top of it.
> > >
> > > (...)
> > >
> > > [1] https://github.com/miquelraynal/linux/tree/nvmem-next/layouts
> >
> > My experience with kernel development over all subsystems I touched is
> > that patches should be improved until being clean & acceptable. I never
> > sent a series with more recent patches fixing issues in earlier patches
> > of the same seriee.
> >
> > So my preference would be to get a new, clean & complete set of patches.
>
> I agree, don't break something and then fix it up in a later patch, that
> makes bisection impossible.
Apart from two rather small fixes which I can squash if that's what you
are requesting, most of the series is already fine on its own, fully
working and bisectable. On top of that initial series from Michael I am
adding support for compiling additional code as modules, which is
arguably another feature. I don't see the point in merging them both
besides mixing two different works. Looking at the code shows that every
step is pretty clean, there is nothing going back and forth.
I will anyway try to make it look like a single series with the changes
requested by Rob in v2.
Thanks,
Miquèl
prev parent reply other threads:[~2023-03-06 15:00 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-01 15:22 [PATCH 0/8] nvmem: Let layout drivers be modules Miquel Raynal
2023-03-01 15:22 ` [PATCH 1/8] of: Fix modalias string generation Miquel Raynal
2023-03-02 19:21 ` Rob Herring
2023-03-01 15:22 ` [PATCH 2/8] of: Change of_device_get_modalias() main argument Miquel Raynal
2023-03-02 19:37 ` Rob Herring
2023-03-01 15:22 ` [PATCH 3/8] of: Create an of_device_request_module() receiving an OF node Miquel Raynal
2023-03-02 19:13 ` Rob Herring
2023-03-01 15:22 ` [PATCH 4/8] nvmem: core: Fix error path ordering Miquel Raynal
2023-03-01 15:22 ` [PATCH 5/8] nvmem: core: Handle the absence of expected layouts Miquel Raynal
2023-03-01 15:22 ` [PATCH 6/8] nvmem: core: Request layout modules loading Miquel Raynal
2023-03-01 15:22 ` [PATCH 7/8] nvmem: layouts: sl28vpd: Convert layout driver into a module Miquel Raynal
2023-03-01 15:22 ` [PATCH 8/8] nvmem: layouts: onie-tlv: " Miquel Raynal
2023-03-01 15:34 ` [PATCH 0/8] nvmem: Let layout drivers be modules Greg Kroah-Hartman
2023-03-06 13:01 ` Michael Walle
2023-03-06 13:35 ` Miquel Raynal
2023-03-06 13:39 ` Michael Walle
2023-03-06 13:57 ` Rafał Miłecki
2023-03-06 14:03 ` Michael Walle
2023-03-06 14:06 ` Rafał Miłecki
2023-03-06 14:11 ` Michael Walle
2023-03-06 14:18 ` Miquel Raynal
2023-03-06 14:23 ` Rafał Miłecki
2023-03-06 14:29 ` Miquel Raynal
2023-03-06 14:34 ` Rafał Miłecki
2023-03-06 14:44 ` Miquel Raynal
2023-03-06 13:54 ` Rafał Miłecki
2023-03-06 13:55 ` Greg Kroah-Hartman
2023-03-06 15:00 ` Miquel Raynal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230306160023.40171f2e@xps-13 \
--to=miquel.raynal@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luka.perkov@sartura.hr \
--cc=michael@walle.cc \
--cc=rafal@milecki.pl \
--cc=robert.marko@sartura.hr \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).