* [PATCH v1 1/2] dt-bindings: gpio: add fcs,fxl6408-gpio binding document
[not found] <20230306083446.41082-1-francesco@dolcini.it>
@ 2023-03-06 8:34 ` Francesco Dolcini
2023-03-06 8:41 ` Krzysztof Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: Francesco Dolcini @ 2023-03-06 8:34 UTC (permalink / raw)
To: linux-gpio, devicetree
Cc: Emanuele Ghidoli, Linus Walleij, Bartosz Golaszewski, Rob Herring,
Krzysztof Kozlowski, linux-kernel
From: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
Add binding document for Fairchild FXL6408 GPIO expander.
Signed-off-by: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
---
.../bindings/gpio/fcs,fxl6408-gpio.yaml | 73 +++++++++++++++++++
1 file changed, 73 insertions(+)
create mode 100644 Documentation/devicetree/bindings/gpio/fcs,fxl6408-gpio.yaml
diff --git a/Documentation/devicetree/bindings/gpio/fcs,fxl6408-gpio.yaml b/Documentation/devicetree/bindings/gpio/fcs,fxl6408-gpio.yaml
new file mode 100644
index 000000000000..ccf946040d00
--- /dev/null
+++ b/Documentation/devicetree/bindings/gpio/fcs,fxl6408-gpio.yaml
@@ -0,0 +1,73 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/gpio/fcs,fxl6408-gpio.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: FXL6408 GPIO driver
+
+maintainers:
+ - Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
+
+description: |
+ Driver for Fairchild FXL6408 GPIO expander
+
+properties:
+ compatible:
+ enum:
+ - fcs,fxl6408
+
+ reg:
+ maxItems: 1
+
+ "#gpio-cells":
+ const: 2
+
+ gpio-controller: true
+
+ gpio-line-names:
+ minItems: 1
+ maxItems: 8
+
+patternProperties:
+ "^(hog-[0-9]+|.+-hog(-[0-9]+)?)$":
+ type: object
+ properties:
+ gpio-hog: true
+ gpios: true
+ input: true
+ output-high: true
+ output-low: true
+ line-name: true
+
+ required:
+ - gpio-hog
+ - gpios
+
+ additionalProperties: false
+
+required:
+ - compatible
+ - reg
+ - gpio-controller
+ - "#gpio-cells"
+
+additionalProperties: false
+
+examples:
+ - |
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ gpio_expander_43: gpio-expander@43 {
+ compatible = "fcs,fxl6408";
+ gpio-controller;
+ #gpio-cells = <2>;
+ reg = <0x43>;
+ gpio-line-names = "Wi-Fi_W_DISABLE", "Wi-Fi_WKUP_WLAN",
+ "PWR_EN_+V3.3_WiFi_N", "PCIe_REF_CLK_EN",
+ "USB_RESET_N", "USB_BYPASS_N", "Wi-Fi_PDn",
+ "Wi-Fi_WKUP_BT";
+ };
+ };
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/2] dt-bindings: gpio: add fcs,fxl6408-gpio binding document
2023-03-06 8:34 ` [PATCH v1 1/2] dt-bindings: gpio: add fcs,fxl6408-gpio binding document Francesco Dolcini
@ 2023-03-06 8:41 ` Krzysztof Kozlowski
2023-03-07 13:54 ` Rob Herring
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-06 8:41 UTC (permalink / raw)
To: Francesco Dolcini, linux-gpio, devicetree
Cc: Emanuele Ghidoli, Linus Walleij, Bartosz Golaszewski, Rob Herring,
Krzysztof Kozlowski, linux-kernel
On 06/03/2023 09:34, Francesco Dolcini wrote:
> From: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
>
> Add binding document for Fairchild FXL6408 GPIO expander.
Subject: drop second/last, redundant "binding document". The
"dt-bindings" prefix is already stating that these are bindings.
>
> Signed-off-by: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
Missing SoB.
> ---
> .../bindings/gpio/fcs,fxl6408-gpio.yaml | 73 +++++++++++++++++++
> 1 file changed, 73 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/gpio/fcs,fxl6408-gpio.yaml
>
> diff --git a/Documentation/devicetree/bindings/gpio/fcs,fxl6408-gpio.yaml b/Documentation/devicetree/bindings/gpio/fcs,fxl6408-gpio.yaml
> new file mode 100644
> index 000000000000..ccf946040d00
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpio/fcs,fxl6408-gpio.yaml
> @@ -0,0 +1,73 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/gpio/fcs,fxl6408-gpio.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: FXL6408 GPIO driver
If "driver" means Linux driver, then drop.
Fairchild FXL6408 GPIO Expander
> +
> +maintainers:
> + - Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
> +
> +description: |
> + Driver for Fairchild FXL6408 GPIO expander
This is not a driver. Drop entire description as it is duplicating title
or add here something useful.
> +
> +properties:
> + compatible:
> + enum:
> + - fcs,fxl6408
> +
> + reg:
> + maxItems: 1
> +
> + "#gpio-cells":
> + const: 2
> +
> + gpio-controller: true
> +
> + gpio-line-names:
> + minItems: 1
> + maxItems: 8
> +
> +patternProperties:
> + "^(hog-[0-9]+|.+-hog(-[0-9]+)?)$":
From here....
> + type: object
> + properties:
> + gpio-hog: true
> + gpios: true
> + input: true
> + output-high: true
> + output-low: true
> + line-name: true
> +
> + required:
> + - gpio-hog
> + - gpios
> +
> + additionalProperties: false
To here, all this can be simpler:
"^(hog-[0-9]+|.+-hog(-[0-9]+)?)$":
required:
- gpio-hog
which selects gpio hog schema.
> +
> +required:
> + - compatible
> + - reg
> + - gpio-controller
> + - "#gpio-cells"
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + gpio_expander_43: gpio-expander@43 {
> + compatible = "fcs,fxl6408";
> + gpio-controller;
> + #gpio-cells = <2>;
> + reg = <0x43>;
> + gpio-line-names = "Wi-Fi_W_DISABLE", "Wi-Fi_WKUP_WLAN",
> + "PWR_EN_+V3.3_WiFi_N", "PCIe_REF_CLK_EN",
Align with previous line/entries.
> + "USB_RESET_N", "USB_BYPASS_N", "Wi-Fi_PDn",
> + "Wi-Fi_WKUP_BT";
> + };
> + };
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/2] dt-bindings: gpio: add fcs,fxl6408-gpio binding document
2023-03-06 8:41 ` Krzysztof Kozlowski
@ 2023-03-07 13:54 ` Rob Herring
0 siblings, 0 replies; 3+ messages in thread
From: Rob Herring @ 2023-03-07 13:54 UTC (permalink / raw)
To: Krzysztof Kozlowski, Francesco Dolcini
Cc: linux-gpio, devicetree, Emanuele Ghidoli, Linus Walleij,
Bartosz Golaszewski, Krzysztof Kozlowski, linux-kernel
On Mon, Mar 06, 2023 at 09:41:50AM +0100, Krzysztof Kozlowski wrote:
> On 06/03/2023 09:34, Francesco Dolcini wrote:
> > From: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
> >
> > Add binding document for Fairchild FXL6408 GPIO expander.
>
> Subject: drop second/last, redundant "binding document". The
> "dt-bindings" prefix is already stating that these are bindings.
>
> >
> > Signed-off-by: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
>
> Missing SoB.
>
> > ---
> > .../bindings/gpio/fcs,fxl6408-gpio.yaml | 73 +++++++++++++++++++
Also, match the compatible string here dropping '-gpio'.
> > 1 file changed, 73 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/gpio/fcs,fxl6408-gpio.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/gpio/fcs,fxl6408-gpio.yaml b/Documentation/devicetree/bindings/gpio/fcs,fxl6408-gpio.yaml
> > new file mode 100644
> > index 000000000000..ccf946040d00
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/gpio/fcs,fxl6408-gpio.yaml
> > @@ -0,0 +1,73 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/gpio/fcs,fxl6408-gpio.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: FXL6408 GPIO driver
>
> If "driver" means Linux driver, then drop.
>
> Fairchild FXL6408 GPIO Expander
>
> > +
> > +maintainers:
> > + - Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
> > +
> > +description: |
> > + Driver for Fairchild FXL6408 GPIO expander
>
> This is not a driver. Drop entire description as it is duplicating title
> or add here something useful.
>
>
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - fcs,fxl6408
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + "#gpio-cells":
> > + const: 2
> > +
> > + gpio-controller: true
> > +
> > + gpio-line-names:
> > + minItems: 1
> > + maxItems: 8
> > +
> > +patternProperties:
> > + "^(hog-[0-9]+|.+-hog(-[0-9]+)?)$":
>
> >From here....
>
> > + type: object
> > + properties:
> > + gpio-hog: true
> > + gpios: true
> > + input: true
> > + output-high: true
> > + output-low: true
> > + line-name: true
> > +
> > + required:
> > + - gpio-hog
> > + - gpios
> > +
> > + additionalProperties: false
>
> To here, all this can be simpler:
>
> "^(hog-[0-9]+|.+-hog(-[0-9]+)?)$":
> required:
> - gpio-hog
>
> which selects gpio hog schema.
>
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - gpio-controller
> > + - "#gpio-cells"
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + i2c {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + gpio_expander_43: gpio-expander@43 {
> > + compatible = "fcs,fxl6408";
> > + gpio-controller;
> > + #gpio-cells = <2>;
> > + reg = <0x43>;
> > + gpio-line-names = "Wi-Fi_W_DISABLE", "Wi-Fi_WKUP_WLAN",
> > + "PWR_EN_+V3.3_WiFi_N", "PCIe_REF_CLK_EN",
>
> Align with previous line/entries.
>
> > + "USB_RESET_N", "USB_BYPASS_N", "Wi-Fi_PDn",
> > + "Wi-Fi_WKUP_BT";
> > + };
> > + };
>
> Best regards,
> Krzysztof
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-07 13:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230306083446.41082-1-francesco@dolcini.it>
2023-03-06 8:34 ` [PATCH v1 1/2] dt-bindings: gpio: add fcs,fxl6408-gpio binding document Francesco Dolcini
2023-03-06 8:41 ` Krzysztof Kozlowski
2023-03-07 13:54 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).