From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: andersson@kernel.org, lpieralisi@kernel.org, kw@linux.com,
krzysztof.kozlowski+dt@linaro.org, robh@kernel.org,
konrad.dybcio@linaro.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, quic_srichara@quicinc.com
Subject: Re: [PATCH 13/19] dt-bindings: PCI: qcom-ep: Rename "mmio" region to "mhi"
Date: Wed, 8 Mar 2023 13:59:30 +0530 [thread overview]
Message-ID: <20230308082930.GB134293@thinkpad> (raw)
In-Reply-To: <ef6ce2bf-3fb9-50ac-ce4b-f8a0d5a8f099@linaro.org>
On Tue, Mar 07, 2023 at 09:18:41AM +0100, Krzysztof Kozlowski wrote:
> On 06/03/2023 16:32, Manivannan Sadhasivam wrote:
> > As per Qualcomm's internal documentation, the name of the region is "mhi"
> > and not "mmio". So let's rename it to follow the convention.
> >
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > ---
> > Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml
> > index 89cfdee4b89f..c2d50f42cb4c 100644
> > --- a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml
> > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml
> > @@ -22,7 +22,7 @@ properties:
> > - description: External local bus interface registers
> > - description: Address Translation Unit (ATU) registers
> > - description: Memory region used to map remote RC address space
> > - - description: BAR memory region
> > + - description: MHI register region used as BAR
> >
> > reg-names:
> > items:
> > @@ -31,7 +31,7 @@ properties:
> > - const: elbi
> > - const: atu
> > - const: addr_space
> > - - const: mmio
> > + - const: mhi
>
> That literally breaks ABI just for convention. I don't think it's right
> approach.
>
Hmm. I'll drop these two patches in next revision.
Thanks,
Mani
> Best regards,
> Krzysztof
>
--
மணிவண்ணன் சதாசிவம்
next prev parent reply other threads:[~2023-03-08 8:30 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-06 15:32 [PATCH 00/19] Qcom PCIe cleanups and improvements Manivannan Sadhasivam
2023-03-06 15:32 ` [PATCH 01/19] PCI: qcom: Remove PCIE20_ prefix from register definitions Manivannan Sadhasivam
2023-03-06 15:32 ` [PATCH 02/19] PCI: qcom: Sort and group registers and bitfield definitions Manivannan Sadhasivam
2023-03-06 15:32 ` [PATCH 03/19] PCI: qcom: Use bitfield definitions for register fields Manivannan Sadhasivam
2023-03-06 15:32 ` [PATCH 04/19] PCI: qcom: Add missing macros " Manivannan Sadhasivam
2023-03-06 15:32 ` [PATCH 05/19] PCI: qcom: Use lower case for hex Manivannan Sadhasivam
2023-03-06 15:32 ` [PATCH 06/19] PCI: qcom: Use bulk reset APIs for handling resets for IP rev 2.1.0 Manivannan Sadhasivam
2023-03-06 15:32 ` [PATCH 07/19] PCI: qcom: Use bulk clock APIs for handling clocks for IP rev 1.0.0 Manivannan Sadhasivam
2023-03-06 15:32 ` [PATCH 08/19] PCI: qcom: Use bulk clock APIs for handling clocks for IP rev 2.3.2 Manivannan Sadhasivam
2023-03-06 15:32 ` [PATCH 09/19] PCI: qcom: Use bulk clock APIs for handling clocks for IP rev 2.3.3 Manivannan Sadhasivam
2023-03-06 15:32 ` [PATCH 10/19] PCI: qcom: Use bulk reset APIs for handling resets " Manivannan Sadhasivam
2023-03-06 15:32 ` [PATCH 11/19] PCI: qcom: Use bulk reset APIs for handling resets for IP rev 2.4.0 Manivannan Sadhasivam
2023-03-06 15:32 ` [PATCH 12/19] PCI: qcom: Use macros for defining total no. of clocks & supplies Manivannan Sadhasivam
2023-03-06 15:32 ` [PATCH 13/19] dt-bindings: PCI: qcom-ep: Rename "mmio" region to "mhi" Manivannan Sadhasivam
2023-03-06 17:13 ` Rob Herring
2023-03-07 8:18 ` Krzysztof Kozlowski
2023-03-08 8:29 ` Manivannan Sadhasivam [this message]
2023-03-06 15:32 ` [PATCH 14/19] " Manivannan Sadhasivam
2023-03-07 8:19 ` Krzysztof Kozlowski
2023-03-08 8:29 ` Manivannan Sadhasivam
2023-03-06 15:32 ` [PATCH 15/19] dt-bindings: PCI: qcom: Add "mhi" register region to supported SoCs Manivannan Sadhasivam
2023-03-06 16:49 ` Johan Hovold
2023-03-08 8:32 ` Manivannan Sadhasivam
2023-03-06 17:13 ` Rob Herring
2023-03-06 15:32 ` [PATCH 16/19] arm64: dts: qcom: sdm845: Add "mhi" region to the PCIe nodes Manivannan Sadhasivam
2023-03-07 8:20 ` Krzysztof Kozlowski
2023-03-08 8:31 ` Manivannan Sadhasivam
2023-03-08 8:33 ` Krzysztof Kozlowski
2023-03-06 15:32 ` [PATCH 17/19] arm64: dts: qcom: sm8250: " Manivannan Sadhasivam
2023-03-06 15:32 ` [PATCH 18/19] arm64: dts: qcom: sc8280xp: " Manivannan Sadhasivam
2023-03-06 15:32 ` [PATCH 19/19] PCI: qcom: Expose link transition counts via debugfs Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230308082930.GB134293@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=quic_srichara@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).