* [PATCH] dt-bindings: remoteproc: qcom,adsp: bring back firmware-name
@ 2023-03-05 12:59 Krzysztof Kozlowski
2023-03-08 22:48 ` Rob Herring
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-05 12:59 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Mathieu Poirier,
Rob Herring, Krzysztof Kozlowski, Manivannan Sadhasivam,
Neil Armstrong, linux-arm-msm, linux-remoteproc, devicetree,
linux-kernel
Cc: Krzysztof Kozlowski
The firmware-name property was moved from common qcom,pas-common.yaml
binding to each device-specific schema, but the qcom,adsp.yaml was not
updated.
Fixes: cee616c68846 ("dt-bindings: remoteproc: qcom: adsp: move memory-region and firmware-name out of pas-common")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
index 643ee787a81f..828dfebaef6a 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
@@ -44,6 +44,10 @@ properties:
maxItems: 1
description: Reference to the reserved-memory for the Hexagon core
+ firmware-name:
+ $ref: /schemas/types.yaml#/definitions/string
+ description: Firmware name for the Hexagon core
+
required:
- compatible
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] dt-bindings: remoteproc: qcom,adsp: bring back firmware-name
2023-03-05 12:59 [PATCH] dt-bindings: remoteproc: qcom,adsp: bring back firmware-name Krzysztof Kozlowski
@ 2023-03-08 22:48 ` Rob Herring
2023-03-09 6:27 ` Krzysztof Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2023-03-08 22:48 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Mathieu Poirier,
Krzysztof Kozlowski, Manivannan Sadhasivam, Neil Armstrong,
linux-arm-msm, linux-remoteproc, devicetree, linux-kernel
On Sun, Mar 05, 2023 at 01:59:17PM +0100, Krzysztof Kozlowski wrote:
> The firmware-name property was moved from common qcom,pas-common.yaml
> binding to each device-specific schema, but the qcom,adsp.yaml was not
> updated.
>
> Fixes: cee616c68846 ("dt-bindings: remoteproc: qcom: adsp: move memory-region and firmware-name out of pas-common")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
> index 643ee787a81f..828dfebaef6a 100644
> --- a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
> @@ -44,6 +44,10 @@ properties:
> maxItems: 1
> description: Reference to the reserved-memory for the Hexagon core
>
> + firmware-name:
> + $ref: /schemas/types.yaml#/definitions/string
We need to stop redefining the type for 'firmware-name'. I'm adding it
to dtschema, so here just put 'maxItems: 1'. Some cases take more than
string, so we have to define this as an array. (We obviously didn't
learn the name things plural lesson on this one.)
Rob
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] dt-bindings: remoteproc: qcom,adsp: bring back firmware-name
2023-03-08 22:48 ` Rob Herring
@ 2023-03-09 6:27 ` Krzysztof Kozlowski
0 siblings, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-09 6:27 UTC (permalink / raw)
To: Rob Herring
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Mathieu Poirier,
Krzysztof Kozlowski, Manivannan Sadhasivam, Neil Armstrong,
linux-arm-msm, linux-remoteproc, devicetree, linux-kernel
On 08/03/2023 23:48, Rob Herring wrote:
> On Sun, Mar 05, 2023 at 01:59:17PM +0100, Krzysztof Kozlowski wrote:
>> The firmware-name property was moved from common qcom,pas-common.yaml
>> binding to each device-specific schema, but the qcom,adsp.yaml was not
>> updated.
>>
>> Fixes: cee616c68846 ("dt-bindings: remoteproc: qcom: adsp: move memory-region and firmware-name out of pas-common")
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>> Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
>> index 643ee787a81f..828dfebaef6a 100644
>> --- a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
>> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
>> @@ -44,6 +44,10 @@ properties:
>> maxItems: 1
>> description: Reference to the reserved-memory for the Hexagon core
>>
>> + firmware-name:
>> + $ref: /schemas/types.yaml#/definitions/string
>
> We need to stop redefining the type for 'firmware-name'. I'm adding it
> to dtschema, so here just put 'maxItems: 1'.
Oh, yes! But maybe we should add string pattern to "-name" in general?
Just like we have for "-names"?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-09 6:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-05 12:59 [PATCH] dt-bindings: remoteproc: qcom,adsp: bring back firmware-name Krzysztof Kozlowski
2023-03-08 22:48 ` Rob Herring
2023-03-09 6:27 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).