From: Bjorn Andersson <andersson@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Brian Masney <bmasney@redhat.com>
Cc: quic_shazhuss@quicinc.com, agross@kernel.org,
konrad.dybcio@linaro.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sa8540p-ride: correct name of remoteproc_nsp0 firmware
Date: Thu, 9 Mar 2023 13:55:53 -0800 [thread overview]
Message-ID: <20230309215553.pe523cmw6nc4pmnw@ripper> (raw)
In-Reply-To: <8f7bddf8-84de-27b5-26a3-d80b2e2f0097@linaro.org>
On Wed, Mar 08, 2023 at 01:36:52PM +0100, Krzysztof Kozlowski wrote:
> On 08/03/2023 13:06, Brian Masney wrote:
> > On Wed, Mar 08, 2023 at 12:02:04PM +0100, Krzysztof Kozlowski wrote:
> >> On 08/03/2023 00:23, Brian Masney wrote:
> >>> The cdsp.mbn firmware that's referenced in sa8540p-ride.dts is actually
> >>> named cdsp0.mbn in the deliverables from Qualcomm. Let's go ahead and
> >>> correct the name to match what's in Qualcomm's deliverable.
> >>
> >> I don't think vendor deliverables matter. linux-firmware is here more
> >> important. The file will be cdsp.mbn in the firmware, won't it?
> >
> > cdsp0.mbn and cdsp1.mbn for the sa8540p are not in linux-firmware and I
> > far as I know there's no plan for someone to submit those since QC would
> > need to approve that. I can ask though since the DTS for these two bits
> > has been submitted upstream.
>
> If they are never going to be submitted, vendor is allowed to rename
> them all the time in their "deliverables". Are you going to rename the
> file every time Qualcomm decides to rename them? There is no single
> guarantee the names would be fixed, because vendor is allowed to do
> absolutely anything.
>
cdsp0.mbn and cdsp1.mbn are better names, so let's use this patch to
define that if/when they are pushed to linux-firmware it should follow
this scheme.
> Sorry, but any argument in upstream DTS that "someone downstream does
> something" is deemed to fail in many cases.
>
That is indeed an insufficient argument, in many cases.
Regards,
Bjorn
next prev parent reply other threads:[~2023-03-09 21:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-07 23:23 [PATCH] arm64: dts: qcom: sa8540p-ride: correct name of remoteproc_nsp0 firmware Brian Masney
2023-03-08 11:02 ` Krzysztof Kozlowski
2023-03-08 12:06 ` Brian Masney
2023-03-08 12:36 ` Krzysztof Kozlowski
2023-03-09 21:55 ` Bjorn Andersson [this message]
2023-03-15 23:34 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230309215553.pe523cmw6nc4pmnw@ripper \
--to=andersson@kernel.org \
--cc=agross@kernel.org \
--cc=bmasney@redhat.com \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_shazhuss@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox