* [PATCH] mtd: nand: qcom: Use of_property_present() for testing DT property presence
@ 2023-03-10 14:47 Rob Herring
2023-03-10 14:55 ` Manivannan Sadhasivam
2023-03-22 16:08 ` Miquel Raynal
0 siblings, 2 replies; 3+ messages in thread
From: Rob Herring @ 2023-03-10 14:47 UTC (permalink / raw)
To: Manivannan Sadhasivam, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra
Cc: devicetree, linux-mtd, linux-arm-msm, linux-kernel
It is preferred to use typed property access functions (i.e.
of_property_read_<type> functions) rather than low-level
of_get_property/of_find_property functions for reading properties. As
part of this, convert of_get_property/of_find_property calls to the
recently added of_property_present() helper when we just want to test
for presence of a property and nothing more.
Signed-off-by: Rob Herring <robh@kernel.org>
---
drivers/mtd/nand/raw/qcom_nandc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/raw/qcom_nandc.c b/drivers/mtd/nand/raw/qcom_nandc.c
index 198a44794d2d..6b52ed8c6178 100644
--- a/drivers/mtd/nand/raw/qcom_nandc.c
+++ b/drivers/mtd/nand/raw/qcom_nandc.c
@@ -3054,7 +3054,7 @@ static int qcom_nand_host_parse_boot_partitions(struct qcom_nand_controller *nan
struct device *dev = nandc->dev;
int partitions_count, i, j, ret;
- if (!of_find_property(dn, "qcom,boot-partitions", NULL))
+ if (!of_property_present(dn, "qcom,boot-partitions"))
return 0;
partitions_count = of_property_count_u32_elems(dn, "qcom,boot-partitions");
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mtd: nand: qcom: Use of_property_present() for testing DT property presence
2023-03-10 14:47 [PATCH] mtd: nand: qcom: Use of_property_present() for testing DT property presence Rob Herring
@ 2023-03-10 14:55 ` Manivannan Sadhasivam
2023-03-22 16:08 ` Miquel Raynal
1 sibling, 0 replies; 3+ messages in thread
From: Manivannan Sadhasivam @ 2023-03-10 14:55 UTC (permalink / raw)
To: Rob Herring
Cc: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
devicetree, linux-mtd, linux-arm-msm, linux-kernel
On Fri, Mar 10, 2023 at 08:47:15AM -0600, Rob Herring wrote:
> It is preferred to use typed property access functions (i.e.
> of_property_read_<type> functions) rather than low-level
> of_get_property/of_find_property functions for reading properties. As
> part of this, convert of_get_property/of_find_property calls to the
> recently added of_property_present() helper when we just want to test
> for presence of a property and nothing more.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
Thanks,
Mani
> ---
> drivers/mtd/nand/raw/qcom_nandc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/raw/qcom_nandc.c b/drivers/mtd/nand/raw/qcom_nandc.c
> index 198a44794d2d..6b52ed8c6178 100644
> --- a/drivers/mtd/nand/raw/qcom_nandc.c
> +++ b/drivers/mtd/nand/raw/qcom_nandc.c
> @@ -3054,7 +3054,7 @@ static int qcom_nand_host_parse_boot_partitions(struct qcom_nand_controller *nan
> struct device *dev = nandc->dev;
> int partitions_count, i, j, ret;
>
> - if (!of_find_property(dn, "qcom,boot-partitions", NULL))
> + if (!of_property_present(dn, "qcom,boot-partitions"))
> return 0;
>
> partitions_count = of_property_count_u32_elems(dn, "qcom,boot-partitions");
> --
> 2.39.2
>
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mtd: nand: qcom: Use of_property_present() for testing DT property presence
2023-03-10 14:47 [PATCH] mtd: nand: qcom: Use of_property_present() for testing DT property presence Rob Herring
2023-03-10 14:55 ` Manivannan Sadhasivam
@ 2023-03-22 16:08 ` Miquel Raynal
1 sibling, 0 replies; 3+ messages in thread
From: Miquel Raynal @ 2023-03-22 16:08 UTC (permalink / raw)
To: Rob Herring, Manivannan Sadhasivam, Miquel Raynal,
Richard Weinberger, Vignesh Raghavendra
Cc: devicetree, linux-mtd, linux-arm-msm, linux-kernel
On Fri, 2023-03-10 at 14:47:15 UTC, Rob Herring wrote:
> It is preferred to use typed property access functions (i.e.
> of_property_read_<type> functions) rather than low-level
> of_get_property/of_find_property functions for reading properties. As
> part of this, convert of_get_property/of_find_property calls to the
> recently added of_property_present() helper when we just want to test
> for presence of a property and nothing more.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
Miquel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-22 16:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-10 14:47 [PATCH] mtd: nand: qcom: Use of_property_present() for testing DT property presence Rob Herring
2023-03-10 14:55 ` Manivannan Sadhasivam
2023-03-22 16:08 ` Miquel Raynal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).