From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: fnkl.kernel@gmail.com
Cc: Thierry Reding <thierry.reding@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
- <asahi@lists.linux.dev>, Hector Martin <marcan@marcan.st>,
Sven Peter <sven@svenpeter.dev>,
Alyssa Rosenzweig <alyssa@rosenzweig.io>,
linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v8 2/5] pwm: Add Apple PWM controller
Date: Fri, 10 Mar 2023 22:46:58 +0100 [thread overview]
Message-ID: <20230310214658.424vui3frynit437@pengutronix.de> (raw)
In-Reply-To: <20230214-fpwm-v8-2-65518a0d4944@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 992 bytes --]
Hello Sascha,
On Fri, Mar 10, 2023 at 07:44:08PM +0100, Sasha Finkelstein via B4 Relay wrote:
> +static int apple_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm,
> + const struct pwm_state *state)
> +{
> + struct apple_pwm *fpwm;
> +
> + if (state->polarity == PWM_POLARITY_INVERSED)
> + return -EINVAL;
> +
> + fpwm = to_apple_pwm(chip);
> + if (state->enabled) {
> + u64 on_cycles, off_cycles;
> +
> + on_cycles = mul_u64_u64_div_u64(fpwm->clkrate,
> + state->duty_cycle, NSEC_PER_SEC);
> + if (on_cycles > 0xFFFFFFFF)
> + on_cycles = 0xFFFFFFFF;
> +
> + off_cycles = mul_u64_u64_div_u64(fpwm->clkrate,
> + state->period, NSEC_PER_SEC) - on_cycles;
> + if (off_cycles > 0xFFFFFFFF)
> + return -ERANGE;
This is still wrong and needs clamping, too.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-03-10 21:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 18:44 [PATCH v8 0/5] PWM and keyboard backlight driver for ARM Macs Sasha Finkelstein via B4 Relay
2023-03-10 18:44 ` [PATCH v8 1/5] dt-bindings: pwm: Add Apple PWM controller Sasha Finkelstein via B4 Relay
2023-03-10 18:44 ` [PATCH v8 2/5] " Sasha Finkelstein via B4 Relay
2023-03-10 21:46 ` Uwe Kleine-König [this message]
2023-03-10 18:44 ` [PATCH v8 3/5] arm64: dts: apple: t8103: Add " Sasha Finkelstein via B4 Relay
2023-03-10 18:44 ` [PATCH v8 4/5] arm64: dts: apple: t600x: " Sasha Finkelstein via B4 Relay
2023-03-10 18:44 ` [PATCH v8 5/5] MAINTAINERS: Add entries for Apple PWM driver Sasha Finkelstein via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230310214658.424vui3frynit437@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=alyssa@rosenzweig.io \
--cc=asahi@lists.linux.dev \
--cc=devicetree@vger.kernel.org \
--cc=fnkl.kernel@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=robh+dt@kernel.org \
--cc=sven@svenpeter.dev \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox