From: Jonathan Cameron <jic23@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Svyatoslav Ryhel <clamor95@gmail.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Derek Kiernan <derek.kiernan@xilinx.com>,
Dragan Cvetic <dragan.cvetic@xilinx.com>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Dmitry Osipenko <dmitry.osipenko@collabora.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH v1 1/4] dt-bindings: iio: light: add apds990x binding
Date: Sun, 12 Mar 2023 14:22:15 +0000 [thread overview]
Message-ID: <20230312142215.13ff34a2@jic23-huawei> (raw)
In-Reply-To: <e6cb5a4f-30ac-3918-c188-cd14ef31f780@linaro.org>
On Sun, 12 Mar 2023 11:47:19 +0100
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> On 11/03/2023 20:34, Jonathan Cameron wrote:
>
> >> +
> >> +additionalProperties: false
> >> +
> >> +required:
> >> + - compatible
> >> + - reg
> >> + - interrupt
> > It would nice to relax the need for an interrupt if the device is still useable
> > with timeouts etc. Board folk have a habit of deciding they don't need to wire
> > up interrupts. We can relax that a later date though if you prefer not to do
> > it now.
> >> + - vdd-supply
> >> + - vled-supply
> >
> > Whilst true that the supplies need to be connected, that doesn't
> > mean they need to provided in the device tree binding. If they are
> > always powered up I think we can fallback to stub regulators.
>
> We can, but others might not. The binding should still require them if
> they are required for device to work. Mark also made it clear recently:
>
> https://lore.kernel.org/all/31ca0ede-012c-4849-bf25-d0492b116681@sirena.org.uk/
> https://lore.kernel.org/all/5cd6764c-9b04-42ea-932d-9f14aa465605@sirena.org.uk/
> https://lore.kernel.org/all/f6f02138-8ef9-4a33-9b51-0b7cd371230f@sirena.org.uk/
OK. Then there are a lot of bindings to fix. Seems odd to me but meh it's
not something I care about.
Note this means that we can't have trivial-device.yaml for instance.
Ah well, I guess views change or crystallise over time or just differed
in the first place.
Jonathan
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2023-03-12 14:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 9:02 [PATCH v1 0/4] Update APDS990x ALS to support IIO Svyatoslav Ryhel
2023-03-08 9:02 ` [PATCH v1 1/4] dt-bindings: iio: light: add apds990x binding Svyatoslav Ryhel
2023-03-08 14:06 ` Rob Herring
2023-03-11 19:34 ` Jonathan Cameron
2023-03-12 10:47 ` Krzysztof Kozlowski
2023-03-12 14:22 ` Jonathan Cameron [this message]
2023-03-08 9:02 ` [PATCH v1 2/4] misc: adps990x: convert to OF Svyatoslav Ryhel
2023-03-11 19:28 ` Jonathan Cameron
2023-03-08 9:02 ` [PATCH v1 3/4] misc: apds990x: convert to IIO Svyatoslav Ryhel
2023-03-12 14:34 ` Jonathan Cameron
2023-03-08 9:02 ` [PATCH v1 4/4] iio: light: move apds990x into proper place Svyatoslav Ryhel
2023-03-11 19:38 ` Jonathan Cameron
2023-03-09 12:57 ` [PATCH v1 0/4] Update APDS990x ALS to support IIO Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230312142215.13ff34a2@jic23-huawei \
--to=jic23@kernel.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=clamor95@gmail.com \
--cc=derek.kiernan@xilinx.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.osipenko@collabora.com \
--cc=dragan.cvetic@xilinx.com \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).