Re: [PATCH 2/2] dt-bindings: iio: imu: st_lsm6dsx: add asm330lhb

[Jonathan Cameron <jic23@kernel.org>]

On Thu, 9 Mar 2023 10:57:00 +0100
Lorenzo Bianconi <lorenzo@kernel.org> wrote:

> On Mar 07, Krzysztof Kozlowski wrote:
> > On 06/03/2023 12:08, Lorenzo Bianconi wrote:  
> > > Add device bindings for asm330lhb IMU sensor.
> > > Use asm330lhh as fallback device for asm330lhb since it implements all
> > > the features currently supported by asm330lhb.
> > > 
> > > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> > > ---
> > >  Documentation/devicetree/bindings/iio/imu/st,lsm6dsx.yaml | 3 +++
> > >  1 file changed, 3 insertions(+)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/iio/imu/st,lsm6dsx.yaml b/Documentation/devicetree/bindings/iio/imu/st,lsm6dsx.yaml
> > > index decf022335d8..b39f5217d8ff 100644
> > > --- a/Documentation/devicetree/bindings/iio/imu/st,lsm6dsx.yaml
> > > +++ b/Documentation/devicetree/bindings/iio/imu/st,lsm6dsx.yaml
> > > @@ -46,6 +46,9 @@ properties:
> > >        - items:
> > >            - const: st,ism330is
> > >            - const: st,lsm6dso16is
> > > +      - items:
> > > +          - const: st,asm330lhb
> > > +          - const: st,asm330lhh  
> > 
> > You added it to the end of the list, but aren't there any ordering
> > already? If so, it should be put rather in correct place.  
> 
> Hi Krzysztof,
> 
> I do not think there is any ordering issue there.
As of today, they aren't in any particular order that I can see.
However, it might be nice to go for some sort of order as a follow up patch
(very low priority though!).

The same applies in the driver, where some of the entries could be organized
by name or maybe wai value.  Perhaps it's just not worth bothering and this
series doesn't make things worse, so I've applied the series to the togreg
branch of iio.git and pushed out initially as testing to let 0-day
see what it can find.

Thanks,

Jonathan

> 
> Regards,
> Lorenzo
> 
> > 
> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > 
> > 
> > Best regards,
> > Krzysztof
> >