* [PATCH] rtc: sun6i: Use of_property_present() for testing DT property presence
@ 2023-03-10 14:47 Rob Herring
2023-03-13 10:22 ` Andre Przywara
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Rob Herring @ 2023-03-10 14:47 UTC (permalink / raw)
To: Alessandro Zummo, Alexandre Belloni, Chen-Yu Tsai, Jernej Skrabec,
Samuel Holland
Cc: devicetree, linux-rtc, linux-arm-kernel, linux-sunxi,
linux-kernel
It is preferred to use typed property access functions (i.e.
of_property_read_<type> functions) rather than low-level
of_get_property/of_find_property functions for reading properties. As
part of this, convert of_get_property/of_find_property calls to the
recently added of_property_present() helper when we just want to test
for presence of a property and nothing more.
Signed-off-by: Rob Herring <robh@kernel.org>
---
drivers/rtc/rtc-sun6i.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/rtc/rtc-sun6i.c b/drivers/rtc/rtc-sun6i.c
index 7038f47d77ff..dc76537f1b62 100644
--- a/drivers/rtc/rtc-sun6i.c
+++ b/drivers/rtc/rtc-sun6i.c
@@ -260,7 +260,7 @@ static void __init sun6i_rtc_clk_init(struct device_node *node,
}
/* Switch to the external, more precise, oscillator, if present */
- if (of_get_property(node, "clocks", NULL)) {
+ if (of_property_present(node, "clocks")) {
reg |= SUN6I_LOSC_CTRL_EXT_OSC;
if (rtc->data->has_losc_en)
reg |= SUN6I_LOSC_CTRL_EXT_LOSC_EN;
--
2.39.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] rtc: sun6i: Use of_property_present() for testing DT property presence
2023-03-10 14:47 [PATCH] rtc: sun6i: Use of_property_present() for testing DT property presence Rob Herring
@ 2023-03-13 10:22 ` Andre Przywara
2023-03-14 19:58 ` Jernej Škrabec
2023-03-17 22:21 ` Alexandre Belloni
2 siblings, 0 replies; 4+ messages in thread
From: Andre Przywara @ 2023-03-13 10:22 UTC (permalink / raw)
To: Rob Herring
Cc: Alessandro Zummo, Alexandre Belloni, Chen-Yu Tsai, Jernej Skrabec,
Samuel Holland, devicetree, linux-rtc, linux-arm-kernel,
linux-sunxi, linux-kernel
On Fri, 10 Mar 2023 08:47:36 -0600
Rob Herring <robh@kernel.org> wrote:
> It is preferred to use typed property access functions (i.e.
> of_property_read_<type> functions) rather than low-level
> of_get_property/of_find_property functions for reading properties. As
> part of this, convert of_get_property/of_find_property calls to the
> recently added of_property_present() helper when we just want to test
> for presence of a property and nothing more.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
Reviewed-by: Andre Przywara <andre.przywara@arm.com>
Cheers,
Andre
> ---
> drivers/rtc/rtc-sun6i.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/rtc/rtc-sun6i.c b/drivers/rtc/rtc-sun6i.c
> index 7038f47d77ff..dc76537f1b62 100644
> --- a/drivers/rtc/rtc-sun6i.c
> +++ b/drivers/rtc/rtc-sun6i.c
> @@ -260,7 +260,7 @@ static void __init sun6i_rtc_clk_init(struct device_node *node,
> }
>
> /* Switch to the external, more precise, oscillator, if present */
> - if (of_get_property(node, "clocks", NULL)) {
> + if (of_property_present(node, "clocks")) {
> reg |= SUN6I_LOSC_CTRL_EXT_OSC;
> if (rtc->data->has_losc_en)
> reg |= SUN6I_LOSC_CTRL_EXT_LOSC_EN;
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] rtc: sun6i: Use of_property_present() for testing DT property presence
2023-03-10 14:47 [PATCH] rtc: sun6i: Use of_property_present() for testing DT property presence Rob Herring
2023-03-13 10:22 ` Andre Przywara
@ 2023-03-14 19:58 ` Jernej Škrabec
2023-03-17 22:21 ` Alexandre Belloni
2 siblings, 0 replies; 4+ messages in thread
From: Jernej Škrabec @ 2023-03-14 19:58 UTC (permalink / raw)
To: Alessandro Zummo, Alexandre Belloni, Chen-Yu Tsai, Samuel Holland,
Rob Herring
Cc: devicetree, linux-rtc, linux-arm-kernel, linux-sunxi,
linux-kernel
Dne petek, 10. marec 2023 ob 15:47:36 CET je Rob Herring napisal(a):
> It is preferred to use typed property access functions (i.e.
> of_property_read_<type> functions) rather than low-level
> of_get_property/of_find_property functions for reading properties. As
> part of this, convert of_get_property/of_find_property calls to the
> recently added of_property_present() helper when we just want to test
> for presence of a property and nothing more.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Best regards,
Jernej
> ---
> drivers/rtc/rtc-sun6i.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/rtc/rtc-sun6i.c b/drivers/rtc/rtc-sun6i.c
> index 7038f47d77ff..dc76537f1b62 100644
> --- a/drivers/rtc/rtc-sun6i.c
> +++ b/drivers/rtc/rtc-sun6i.c
> @@ -260,7 +260,7 @@ static void __init sun6i_rtc_clk_init(struct device_node
> *node, }
>
> /* Switch to the external, more precise, oscillator, if present */
> - if (of_get_property(node, "clocks", NULL)) {
> + if (of_property_present(node, "clocks")) {
> reg |= SUN6I_LOSC_CTRL_EXT_OSC;
> if (rtc->data->has_losc_en)
> reg |= SUN6I_LOSC_CTRL_EXT_LOSC_EN;
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] rtc: sun6i: Use of_property_present() for testing DT property presence
2023-03-10 14:47 [PATCH] rtc: sun6i: Use of_property_present() for testing DT property presence Rob Herring
2023-03-13 10:22 ` Andre Przywara
2023-03-14 19:58 ` Jernej Škrabec
@ 2023-03-17 22:21 ` Alexandre Belloni
2 siblings, 0 replies; 4+ messages in thread
From: Alexandre Belloni @ 2023-03-17 22:21 UTC (permalink / raw)
To: Alessandro Zummo, Chen-Yu Tsai, Jernej Skrabec, Samuel Holland,
Rob Herring
Cc: devicetree, linux-rtc, linux-arm-kernel, linux-sunxi,
linux-kernel
On Fri, 10 Mar 2023 08:47:36 -0600, Rob Herring wrote:
> It is preferred to use typed property access functions (i.e.
> of_property_read_<type> functions) rather than low-level
> of_get_property/of_find_property functions for reading properties. As
> part of this, convert of_get_property/of_find_property calls to the
> recently added of_property_present() helper when we just want to test
> for presence of a property and nothing more.
>
> [...]
Applied, thanks!
[1/1] rtc: sun6i: Use of_property_present() for testing DT property presence
commit: 4d9890ac9d43d4dfd011110ab96633caa6fa829c
Best regards,
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-03-17 22:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-10 14:47 [PATCH] rtc: sun6i: Use of_property_present() for testing DT property presence Rob Herring
2023-03-13 10:22 ` Andre Przywara
2023-03-14 19:58 ` Jernej Škrabec
2023-03-17 22:21 ` Alexandre Belloni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).