* [PATCH net-next v13 02/16] dt-bindings: net: mediatek,net: add mt7981-eth binding
2023-03-09 10:54 [PATCH net-next v13 00/16] net: ethernet: mtk_eth_soc: various enhancements Daniel Golle
@ 2023-03-09 10:55 ` Daniel Golle
2023-03-09 10:55 ` [PATCH net-next v13 03/16] dt-bindings: arm: mediatek: sgmiisys: Convert to DT schema Daniel Golle
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Daniel Golle @ 2023-03-09 10:55 UTC (permalink / raw)
To: devicetree, Rob Herring, Krzysztof Kozlowski, netdev,
linux-mediatek, linux-arm-kernel, linux-kernel, Russell King,
Heiner Kallweit, Lorenzo Bianconi, Mark Lee, John Crispin,
Felix Fietkau, AngeloGioacchino Del Regno, Matthias Brugger,
DENG Qingfang, Landen Chao, Sean Wang, Paolo Abeni,
Jakub Kicinski, Eric Dumazet, David S. Miller, Vladimir Oltean,
Florian Fainelli, Andrew Lunn, Vladimir Oltean
Cc: Bjørn Mork, Frank Wunderlich, Alexander Couzens
Introduce DT bindings for the MT7981 SoC to mediatek,net.yaml.
Reviewed-by: Rob Herring <robh@kernel.org>
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
---
.../devicetree/bindings/net/mediatek,net.yaml | 53 +++++++++++++++++--
1 file changed, 48 insertions(+), 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/mediatek,net.yaml b/Documentation/devicetree/bindings/net/mediatek,net.yaml
index 7ef696204c5a..b7f6474dc5ab 100644
--- a/Documentation/devicetree/bindings/net/mediatek,net.yaml
+++ b/Documentation/devicetree/bindings/net/mediatek,net.yaml
@@ -21,6 +21,7 @@ properties:
- mediatek,mt7623-eth
- mediatek,mt7622-eth
- mediatek,mt7629-eth
+ - mediatek,mt7981-eth
- mediatek,mt7986-eth
- ralink,rt5350-eth
@@ -78,6 +79,11 @@ properties:
description:
List of phandles to wireless ethernet dispatch nodes.
+ mediatek,wed-pcie:
+ $ref: /schemas/types.yaml#/definitions/phandle
+ description:
+ Phandle to the mediatek wed-pcie controller.
+
dma-coherent: true
mdio-bus:
@@ -123,6 +129,8 @@ allOf:
mediatek,wed: false
+ mediatek,wed-pcie: false
+
- if:
properties:
compatible:
@@ -160,6 +168,8 @@ allOf:
description:
Phandle to the mediatek pcie-mirror controller.
+ mediatek,wed-pcie: false
+
- if:
properties:
compatible:
@@ -206,6 +216,44 @@ allOf:
mediatek,wed: false
+ mediatek,wed-pcie: false
+
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: mediatek,mt7981-eth
+ then:
+ properties:
+ interrupts:
+ minItems: 4
+
+ clocks:
+ minItems: 15
+ maxItems: 15
+
+ clock-names:
+ items:
+ - const: fe
+ - const: gp2
+ - const: gp1
+ - const: wocpu0
+ - const: sgmii_ck
+ - const: sgmii_tx250m
+ - const: sgmii_rx250m
+ - const: sgmii_cdr_ref
+ - const: sgmii_cdr_fb
+ - const: sgmii2_tx250m
+ - const: sgmii2_rx250m
+ - const: sgmii2_cdr_ref
+ - const: sgmii2_cdr_fb
+ - const: netsys0
+ - const: netsys1
+
+ mediatek,sgmiisys:
+ minItems: 2
+ maxItems: 2
+
- if:
properties:
compatible:
@@ -242,11 +290,6 @@ allOf:
minItems: 2
maxItems: 2
- mediatek,wed-pcie:
- $ref: /schemas/types.yaml#/definitions/phandle
- description:
- Phandle to the mediatek wed-pcie controller.
-
patternProperties:
"^mac@[0-1]$":
type: object
--
2.39.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH net-next v13 03/16] dt-bindings: arm: mediatek: sgmiisys: Convert to DT schema
2023-03-09 10:54 [PATCH net-next v13 00/16] net: ethernet: mtk_eth_soc: various enhancements Daniel Golle
2023-03-09 10:55 ` [PATCH net-next v13 02/16] dt-bindings: net: mediatek,net: add mt7981-eth binding Daniel Golle
@ 2023-03-09 10:55 ` Daniel Golle
2023-03-09 10:55 ` [PATCH net-next v13 04/16] dt-bindings: arm: mediatek: sgmiisys: add MT7981 SoC Daniel Golle
2023-03-13 23:51 ` [PATCH net-next v13 00/16] net: ethernet: mtk_eth_soc: various enhancements Jakub Kicinski
3 siblings, 0 replies; 5+ messages in thread
From: Daniel Golle @ 2023-03-09 10:55 UTC (permalink / raw)
To: devicetree, Rob Herring, Krzysztof Kozlowski, netdev,
linux-mediatek, linux-arm-kernel, linux-kernel, Russell King,
Heiner Kallweit, Lorenzo Bianconi, Mark Lee, John Crispin,
Felix Fietkau, AngeloGioacchino Del Regno, Matthias Brugger,
DENG Qingfang, Landen Chao, Sean Wang, Paolo Abeni,
Jakub Kicinski, Eric Dumazet, David S. Miller, Vladimir Oltean,
Florian Fainelli, Andrew Lunn, Vladimir Oltean
Cc: Bjørn Mork, Frank Wunderlich, Alexander Couzens
Convert mediatek,sgmiiisys bindings to DT schema format.
Add maintainer Matthias Brugger, no maintainers were listed in the
original documentation.
As this node is also referenced by the Ethernet controller and used
as SGMII PCS add this fact to the description.
Move the file to Documentation/devicetree/bindings/pcs/ which seems more
appropriate given that the great majority of registers are related to
SGMII PCS functionality and only one register represents clock bits.
Reviewed-by: Rob Herring <robh@kernel.org>
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
---
.../arm/mediatek/mediatek,sgmiisys.txt | 27 ----------
.../bindings/net/pcs/mediatek,sgmiisys.yaml | 49 +++++++++++++++++++
2 files changed, 49 insertions(+), 27 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/arm/mediatek/mediatek,sgmiisys.txt
create mode 100644 Documentation/devicetree/bindings/net/pcs/mediatek,sgmiisys.yaml
diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,sgmiisys.txt b/Documentation/devicetree/bindings/arm/mediatek/mediatek,sgmiisys.txt
deleted file mode 100644
index d2c24c277514..000000000000
--- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,sgmiisys.txt
+++ /dev/null
@@ -1,27 +0,0 @@
-MediaTek SGMIISYS controller
-============================
-
-The MediaTek SGMIISYS controller provides various clocks to the system.
-
-Required Properties:
-
-- compatible: Should be:
- - "mediatek,mt7622-sgmiisys", "syscon"
- - "mediatek,mt7629-sgmiisys", "syscon"
- - "mediatek,mt7981-sgmiisys_0", "syscon"
- - "mediatek,mt7981-sgmiisys_1", "syscon"
- - "mediatek,mt7986-sgmiisys_0", "syscon"
- - "mediatek,mt7986-sgmiisys_1", "syscon"
-- #clock-cells: Must be 1
-
-The SGMIISYS controller uses the common clk binding from
-Documentation/devicetree/bindings/clock/clock-bindings.txt
-The available clocks are defined in dt-bindings/clock/mt*-clk.h.
-
-Example:
-
-sgmiisys: sgmiisys@1b128000 {
- compatible = "mediatek,mt7622-sgmiisys", "syscon";
- reg = <0 0x1b128000 0 0x1000>;
- #clock-cells = <1>;
-};
diff --git a/Documentation/devicetree/bindings/net/pcs/mediatek,sgmiisys.yaml b/Documentation/devicetree/bindings/net/pcs/mediatek,sgmiisys.yaml
new file mode 100644
index 000000000000..7ce597011a32
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/pcs/mediatek,sgmiisys.yaml
@@ -0,0 +1,49 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/pcs/mediatek,sgmiisys.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: MediaTek SGMIISYS Controller
+
+maintainers:
+ - Matthias Brugger <matthias.bgg@gmail.com>
+
+description:
+ The MediaTek SGMIISYS controller provides a SGMII PCS and some clocks
+ to the ethernet subsystem to which it is attached.
+
+properties:
+ compatible:
+ items:
+ - enum:
+ - mediatek,mt7622-sgmiisys
+ - mediatek,mt7629-sgmiisys
+ - mediatek,mt7986-sgmiisys_0
+ - mediatek,mt7986-sgmiisys_1
+ - const: syscon
+
+ reg:
+ maxItems: 1
+
+ '#clock-cells':
+ const: 1
+
+required:
+ - compatible
+ - reg
+ - '#clock-cells'
+
+additionalProperties: false
+
+examples:
+ - |
+ soc {
+ #address-cells = <2>;
+ #size-cells = <2>;
+ sgmiisys: syscon@1b128000 {
+ compatible = "mediatek,mt7622-sgmiisys", "syscon";
+ reg = <0 0x1b128000 0 0x1000>;
+ #clock-cells = <1>;
+ };
+ };
--
2.39.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH net-next v13 04/16] dt-bindings: arm: mediatek: sgmiisys: add MT7981 SoC
2023-03-09 10:54 [PATCH net-next v13 00/16] net: ethernet: mtk_eth_soc: various enhancements Daniel Golle
2023-03-09 10:55 ` [PATCH net-next v13 02/16] dt-bindings: net: mediatek,net: add mt7981-eth binding Daniel Golle
2023-03-09 10:55 ` [PATCH net-next v13 03/16] dt-bindings: arm: mediatek: sgmiisys: Convert to DT schema Daniel Golle
@ 2023-03-09 10:55 ` Daniel Golle
2023-03-13 23:51 ` [PATCH net-next v13 00/16] net: ethernet: mtk_eth_soc: various enhancements Jakub Kicinski
3 siblings, 0 replies; 5+ messages in thread
From: Daniel Golle @ 2023-03-09 10:55 UTC (permalink / raw)
To: devicetree, Rob Herring, Krzysztof Kozlowski, netdev,
linux-mediatek, linux-arm-kernel, linux-kernel, Russell King,
Heiner Kallweit, Lorenzo Bianconi, Mark Lee, John Crispin,
Felix Fietkau, AngeloGioacchino Del Regno, Matthias Brugger,
DENG Qingfang, Landen Chao, Sean Wang, Paolo Abeni,
Jakub Kicinski, Eric Dumazet, David S. Miller, Vladimir Oltean,
Florian Fainelli, Andrew Lunn, Vladimir Oltean
Cc: Bjørn Mork, Frank Wunderlich, Alexander Couzens
Add mediatek,pnswap boolean property needed on many boards using the
MediaTek MT7981 SoC.
Reviewed-by: Rob Herring <robh@kernel.org>
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
---
.../devicetree/bindings/net/pcs/mediatek,sgmiisys.yaml | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/pcs/mediatek,sgmiisys.yaml b/Documentation/devicetree/bindings/net/pcs/mediatek,sgmiisys.yaml
index 7ce597011a32..66a95191bd77 100644
--- a/Documentation/devicetree/bindings/net/pcs/mediatek,sgmiisys.yaml
+++ b/Documentation/devicetree/bindings/net/pcs/mediatek,sgmiisys.yaml
@@ -19,6 +19,8 @@ properties:
- enum:
- mediatek,mt7622-sgmiisys
- mediatek,mt7629-sgmiisys
+ - mediatek,mt7981-sgmiisys_0
+ - mediatek,mt7981-sgmiisys_1
- mediatek,mt7986-sgmiisys_0
- mediatek,mt7986-sgmiisys_1
- const: syscon
@@ -29,6 +31,10 @@ properties:
'#clock-cells':
const: 1
+ mediatek,pnswap:
+ description: Invert polarity of the SGMII data lanes
+ type: boolean
+
required:
- compatible
- reg
--
2.39.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH net-next v13 00/16] net: ethernet: mtk_eth_soc: various enhancements
2023-03-09 10:54 [PATCH net-next v13 00/16] net: ethernet: mtk_eth_soc: various enhancements Daniel Golle
` (2 preceding siblings ...)
2023-03-09 10:55 ` [PATCH net-next v13 04/16] dt-bindings: arm: mediatek: sgmiisys: add MT7981 SoC Daniel Golle
@ 2023-03-13 23:51 ` Jakub Kicinski
3 siblings, 0 replies; 5+ messages in thread
From: Jakub Kicinski @ 2023-03-13 23:51 UTC (permalink / raw)
To: Daniel Golle
Cc: devicetree, Rob Herring, Krzysztof Kozlowski, netdev,
linux-mediatek, linux-arm-kernel, linux-kernel, Russell King,
Heiner Kallweit, Lorenzo Bianconi, Mark Lee, John Crispin,
Felix Fietkau, AngeloGioacchino Del Regno, Matthias Brugger,
DENG Qingfang, Landen Chao, Sean Wang, Paolo Abeni, Eric Dumazet,
David S. Miller, Vladimir Oltean, Florian Fainelli, Andrew Lunn,
Vladimir Oltean, Bjørn Mork, Frank Wunderlich,
Alexander Couzens
On Thu, 9 Mar 2023 10:54:23 +0000 Daniel Golle wrote:
> This series brings a variety of fixes and enhancements for mtk_eth_soc,
> adds support for the MT7981 SoC and facilitates sharing the SGMII PCS
> code between mtk_eth_soc and mt7530.
> Also prepare support for MT7988 which has been done while net-next was
> closed.
The netdev review queue is too long for me to comprehend, since the
discussion is still ongoing on v12 (even tho seemingly tangential)
I'll drop this, please repost once conclusion is reached.
^ permalink raw reply [flat|nested] 5+ messages in thread