From: Andi Shyti <andi.shyti@kernel.org>
To: linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Wolfram Sang <wsa@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Chris Packham <chris.packham@alliedtelesis.co.nz>,
Ryan Chen <ryan_chen@aspeedtech.com>,
Andi Shyti <andi.shyti@kernel.org>
Subject: [PATCH v4 0/3] Add the clock stretching i2c property
Date: Tue, 14 Mar 2023 22:56:09 +0100 [thread overview]
Message-ID: <20230314215612.23741-1-andi.shyti@kernel.org> (raw)
Hello,
fter a discussion between Krzysztof and Ryan[1], it has become
apparent that the i2c binding is lacking the definition of a
property that needs to be added at a more generic level. This
property is also used by the mpc i2c controller, which has been
updated in the second patch.
The DTS schema change has been sent as github pull reqest[2][3].
Thanks Krzysztof and Chris for the reviews.
Thank you,
Andi
[1] https://lore.kernel.org/all/c41ee6b5-ddb4-1253-de54-a295b3bab2cc@linaro.org/
[2] https://github.com/devicetree-org/dt-schema/pull/102
[3] https://github.com/devicetree-org/dt-schema/pull/103
Changelog
=========
v3 -> v4:
- Replaced "i2c-scl-clk-low-timeout-ms" with
"i2c-scl-clk-low-timeout-us". Use microseconds instead of
milliseconds.
- Add tags from Chris.
v2 -> v3:
- Chris recommended to use of_property_read_u32() instead of
of_get_property(). Because there were two use of it I added
the suggested cleanup in a separate patch.
v1 -> v2:
- Removed the binding patch and send through a different channel
- To ensure back compatibility, which was broken in v1, the
legacy "fsl,timeout" has not been removed and marked as
deprecated. In the driver the that property is checked anyway
as a fallback in case the main i2c-scl-clk-low-timeout-ms is
missing.
Andi Shyti (3):
dt-bindings: i2c: mpc: Mark "fsl,timeout" as deprecated
i2c: mpc: Use of_property_read_u32 instead of of_get_property
i2c: mpc: Use i2c-scl-clk-low-timeout-ms i2c property
.../devicetree/bindings/i2c/i2c-mpc.yaml | 3 +-
drivers/i2c/busses/i2c-mpc.c | 35 ++++++++++++-------
2 files changed, 25 insertions(+), 13 deletions(-)
--
2.39.2
next reply other threads:[~2023-03-14 21:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 21:56 Andi Shyti [this message]
2023-03-14 21:56 ` [PATCH v4 1/3] dt-bindings: i2c: mpc: Mark "fsl,timeout" as deprecated Andi Shyti
2023-03-16 20:51 ` Rob Herring
2023-03-14 21:56 ` [PATCH v4 2/3] i2c: mpc: Use of_property_read_u32 instead of of_get_property Andi Shyti
2023-03-14 21:56 ` [PATCH v4 3/3] i2c: mpc: Use i2c-scl-clk-low-timeout-ms i2c property Andi Shyti
2023-03-14 22:00 ` Chris Packham
2023-03-14 22:07 ` Andi Shyti
2023-03-14 22:16 ` [PATCH v5 3/3] i2c: mpc: Use i2c-scl-clk-low-timeout-us " Andi Shyti
2023-03-17 9:26 ` Krzysztof Kozlowski
2023-03-17 14:00 ` Andi Shyti
2023-03-17 9:25 ` [PATCH v4 3/3] i2c: mpc: Use i2c-scl-clk-low-timeout-ms " Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230314215612.23741-1-andi.shyti@kernel.org \
--to=andi.shyti@kernel.org \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=ryan_chen@aspeedtech.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).