* [PATCH] arm64: dts: hi3798cv200: Correct 'clock-names' in sd0
@ 2023-03-15 11:28 David Yang
2023-05-13 18:47 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: David Yang @ 2023-03-15 11:28 UTC (permalink / raw)
To: mmyangfl
Cc: Wei Xu, Rob Herring, Krzysztof Kozlowski, linux-arm-kernel,
devicetree, linux-kernel
"ciu" and "biu" were incorrectly swapped. Fix them to match 'clocks'.
Signed-off-by: David Yang <mmyangfl@gmail.com>
---
arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi b/arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi
index a83b9d4f1..7112f9933 100644
--- a/arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi
+++ b/arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi
@@ -304,7 +304,7 @@ sd0: mmc@9820000 {
interrupts = <GIC_SPI 34 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&crg HISTB_SDIO0_CIU_CLK>,
<&crg HISTB_SDIO0_BIU_CLK>;
- clock-names = "biu", "ciu";
+ clock-names = "ciu", "biu";
resets = <&crg 0x9c 4>;
reset-names = "reset";
status = "disabled";
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arm64: dts: hi3798cv200: Correct 'clock-names' in sd0
2023-03-15 11:28 [PATCH] arm64: dts: hi3798cv200: Correct 'clock-names' in sd0 David Yang
@ 2023-05-13 18:47 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2023-05-13 18:47 UTC (permalink / raw)
To: David Yang
Cc: Wei Xu, Rob Herring, Krzysztof Kozlowski, linux-arm-kernel,
devicetree, linux-kernel
On 15/03/2023 12:28, David Yang wrote:
> "ciu" and "biu" were incorrectly swapped. Fix them to match 'clocks'.
>
> Signed-off-by: David Yang <mmyangfl@gmail.com>
This breaks the bindings. You wanted probably different order.
Does not look like you tested the DTS against bindings. Please run `make
dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst
for instructions).
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-05-13 18:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-15 11:28 [PATCH] arm64: dts: hi3798cv200: Correct 'clock-names' in sd0 David Yang
2023-05-13 18:47 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).