From: Jan Jasper de Kroon <jajadekroon@gmail.com>
To: jajadekroon@gmail.com
Cc: alexandre.belloni@bootlin.com, broonie@kernel.org,
devicetree@vger.kernel.org, dmitry.torokhov@gmail.com,
kernel@undef.tools, krzysztof.kozlowski+dt@linaro.org,
linux-input@vger.kernel.org, robh+dt@kernel.org
Subject: [PATCH v3 1/2] dt-bindings: input: touchscreen: Add 'goodix-hold-in-reset' property to Goodix
Date: Thu, 16 Mar 2023 16:47:50 +0100 [thread overview]
Message-ID: <20230316154749.68304-1-jajadekroon@gmail.com> (raw)
In-Reply-To: <20230311134655.486973-1-jajadekroon@gmail.com>
Add an optional 'goodix-hold-in-reset', to the Goodix touchscreen
device tree binding. When set to true, the touchscreen controller will
be held in reset mode during system suspend, reducing power consumption.
If not present, the property defaults to false.
Signed-off-by: Jan Jasper de Kroon <jajadekroon@gmail.com>
---
Changes from v2 to v3:
- Used imperative mood instead of "This patch adds".
- Dropped "I am submitting this patch to..." as it is redundant.
- Removed the paragraph related to the related patch sent to the
linux-input mailing list as it is not necessary.
- Renamed the hold-in-reset-in-suspend function to
goodix-hold-in-reset to prevent potential naming conflicts with other
functions in the codebase. No functional changes were made.
Changes from v1 to v2:
- Updated subject prefix to match subsystem.
- Added more detailed description of the change.
- Fixed formatting issues in commit message.
.../devicetree/bindings/input/touchscreen/goodix.yaml | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml b/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml
index 3d016b87c8df..197f8db9acc2 100644
--- a/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml
+++ b/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml
@@ -56,6 +56,13 @@ properties:
touchscreen-size-y: true
touchscreen-swapped-x-y: true
+ goodix-hold-in-reset:
+ description: |
+ When set to true, the touchscreen controller will be held in reset mode
+ during system suspend. This can help reduce power consumption, but may
+ cause the touchscreen to take longer to resume when the system is woken
+ up from suspend.
+
additionalProperties: false
required:
@@ -75,6 +82,7 @@ examples:
interrupts = <0 0>;
irq-gpios = <&gpio1 0 0>;
reset-gpios = <&gpio1 1 0>;
+ goodix-hold-in-reset;
};
};
--
2.34.3
next prev parent reply other threads:[~2023-03-16 15:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-11 13:46 [PATCH] feat: Add 'hold-in-reset-in-suspend' property to goodix touchscreen binding Jan Jasper de Kroon
2023-03-12 11:42 ` Krzysztof Kozlowski
2023-03-12 18:31 ` [PATCH v2 1/2] dt-bindings: input: touchscreen: Add 'hold-in-reset-in-suspend' property to goodix Jan Jasper de Kroon
2023-03-14 17:47 ` Krzysztof Kozlowski
2023-03-16 15:41 ` Jan Jasper de Kroon
2023-03-16 19:24 ` Krzysztof Kozlowski
2023-03-16 15:29 ` [PATCH v3 1/2] dt-bindings: input: touchscreen: Add 'goodix-hold-in-reset' property to Goodix Jan Jasper de Kroon
2023-03-16 19:25 ` Krzysztof Kozlowski
2023-03-17 10:39 ` Jan Jasper de Kroon
2023-03-19 14:09 ` Krzysztof Kozlowski
2023-03-19 16:38 ` Jan Jasper de Kroon
2023-03-19 18:31 ` Krzysztof Kozlowski
2023-03-14 14:10 ` [PATCH] feat: Add 'hold-in-reset-in-suspend' property to goodix touchscreen binding Rob Herring
2023-03-14 17:16 ` Jan Jasper de Kroon
2023-03-16 15:47 ` Jan Jasper de Kroon [this message]
2023-03-16 19:26 ` [PATCH v3 1/2] dt-bindings: input: touchscreen: Add 'goodix-hold-in-reset' property to Goodix Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230316154749.68304-1-jajadekroon@gmail.com \
--to=jajadekroon@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=kernel@undef.tools \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).