From: Andi Shyti <andi.shyti@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Andi Shyti <andi.shyti@kernel.org>,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Wolfram Sang <wsa@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Chris Packham <chris.packham@alliedtelesis.co.nz>,
Ryan Chen <ryan_chen@aspeedtech.com>
Subject: Re: [PATCH v5 3/3] i2c: mpc: Use i2c-scl-clk-low-timeout-us i2c property
Date: Fri, 17 Mar 2023 15:00:43 +0100 [thread overview]
Message-ID: <20230317140043.jnlmghbnvol2kxrz@intel.intel> (raw)
In-Reply-To: <5a8fa13b-d9f7-aca8-3898-51d6e53fa78a@linaro.org>
Hi Krzysztof,
On Fri, Mar 17, 2023 at 10:26:21AM +0100, Krzysztof Kozlowski wrote:
> On 14/03/2023 23:16, Andi Shyti wrote:
> > "fsl,timeout" is marked as deprecated and replaced by the
> > "i2c-scl-clk-low-timeout-us" i2c property.
> >
> > Use this latter and, in case it is missing, for back
> > compatibility, check whether we still have "fsl,timeout" defined.
> >
> > Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
> > Reviewed-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> > Tested-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> > ---
> > Hi,
> >
> > this should be the only patch where I forgot an 'ms'.
> > It should be fixed now.
> >
> > Thanks, Chris.
> >
> > V4 -> v5
> > - replace /ms/us/ in the commit subject and in the comment.
> >
>
> Please send entire new v5, because this messes with our
> threading/reviewing and our tools.
ah... tools!
Sure... will do!
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Thanks!
Andi
next prev parent reply other threads:[~2023-03-17 14:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 21:56 [PATCH v4 0/3] Add the clock stretching i2c property Andi Shyti
2023-03-14 21:56 ` [PATCH v4 1/3] dt-bindings: i2c: mpc: Mark "fsl,timeout" as deprecated Andi Shyti
2023-03-16 20:51 ` Rob Herring
2023-03-14 21:56 ` [PATCH v4 2/3] i2c: mpc: Use of_property_read_u32 instead of of_get_property Andi Shyti
2023-03-14 21:56 ` [PATCH v4 3/3] i2c: mpc: Use i2c-scl-clk-low-timeout-ms i2c property Andi Shyti
2023-03-14 22:00 ` Chris Packham
2023-03-14 22:07 ` Andi Shyti
2023-03-14 22:16 ` [PATCH v5 3/3] i2c: mpc: Use i2c-scl-clk-low-timeout-us " Andi Shyti
2023-03-17 9:26 ` Krzysztof Kozlowski
2023-03-17 14:00 ` Andi Shyti [this message]
2023-03-17 9:25 ` [PATCH v4 3/3] i2c: mpc: Use i2c-scl-clk-low-timeout-ms " Krzysztof Kozlowski
-- strict thread matches above, loose matches on Subject: below --
2023-03-17 23:33 [PATCH v5 0/3] Add the clock stretching " Andi Shyti
2023-03-17 23:33 ` [PATCH v5 3/3] i2c: mpc: Use i2c-scl-clk-low-timeout-us " Andi Shyti
2023-03-29 19:08 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230317140043.jnlmghbnvol2kxrz@intel.intel \
--to=andi.shyti@kernel.org \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=ryan_chen@aspeedtech.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).