From: Tianling Shen <cnsztl@gmail.com>
To: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Heiko Stuebner <heiko@sntech.de>,
Jagan Teki <jagan@amarulasolutions.com>,
Peter Geis <pgwipeout@gmail.com>, Andy Yan <andyshrk@163.com>,
Tianling Shen <cnsztl@gmail.com>,
Brian Norris <briannorris@chromium.org>,
Chris Morgan <macromorgan@hotmail.com>,
Sebastian Reichel <sebastian.reichel@collabora.com>,
Andrew Lunn <andrew@lunn.ch>,
Michael Riesch <michael.riesch@wolfvision.net>,
Maya Matuszczyk <maccraft123mc@gmail.com>,
Andrew Powers-Holmes <aholmes@omnom.net>,
Sascha Hauer <s.hauer@pengutronix.de>,
Vasily Khoruzhick <anarsoul@gmail.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 4/5] arm64: dts: rockchip: fix gmac support for NanoPi R5S
Date: Sat, 18 Mar 2023 16:37:44 +0800 [thread overview]
Message-ID: <20230318083745.6181-5-cnsztl@gmail.com> (raw)
In-Reply-To: <20230318083745.6181-1-cnsztl@gmail.com>
- Changed phy-mode to rgmii.
- Fixed pull type in pinctrl for gmac0.
- Removed duplicate properties in mdio node.
These properties are defined in the gmac0 node already.
Fixes: c6629b9a6738 ("arm64: dts: rockchip: Add FriendlyElec Nanopi R5S")
Signed-off-by: Tianling Shen <cnsztl@gmail.com>
---
arch/arm64/boot/dts/rockchip/rk3568-nanopi-r5s.dts | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3568-nanopi-r5s.dts b/arch/arm64/boot/dts/rockchip/rk3568-nanopi-r5s.dts
index e9adf5e66529..2a1118f15c29 100644
--- a/arch/arm64/boot/dts/rockchip/rk3568-nanopi-r5s.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3568-nanopi-r5s.dts
@@ -57,7 +57,7 @@ &gmac0 {
assigned-clock-rates = <0>, <125000000>;
clock_in_out = "output";
phy-handle = <&rgmii_phy0>;
- phy-mode = "rgmii-id";
+ phy-mode = "rgmii";
pinctrl-names = "default";
pinctrl-0 = <&gmac0_miim
&gmac0_tx_bus2
@@ -79,9 +79,6 @@ rgmii_phy0: ethernet-phy@1 {
reg = <1>;
pinctrl-0 = <ð_phy0_reset_pin>;
pinctrl-names = "default";
- reset-assert-us = <10000>;
- reset-deassert-us = <50000>;
- reset-gpios = <&gpio0 RK_PC4 GPIO_ACTIVE_LOW>;
};
};
@@ -115,7 +112,7 @@ &pcie3x2 {
&pinctrl {
gmac0 {
eth_phy0_reset_pin: eth-phy0-reset-pin {
- rockchip,pins = <0 RK_PC4 RK_FUNC_GPIO &pcfg_pull_down>;
+ rockchip,pins = <0 RK_PC4 RK_FUNC_GPIO &pcfg_pull_up>;
};
};
--
2.40.0
next prev parent reply other threads:[~2023-03-18 8:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-18 8:37 [PATCH v2 0/5] arm64: dts: rockchip: improve support for NanoPi R5 series Tianling Shen
2023-03-18 8:37 ` [PATCH v2 1/5] arm64: dts: rockchip: create common dtsi " Tianling Shen
2023-03-18 8:37 ` [PATCH v2 2/5] dt-bindings: Add doc for FriendlyARM NanoPi R5C Tianling Shen
2023-03-18 8:37 ` [PATCH v2 3/5] arm64: dts: rockchip: Add " Tianling Shen
2023-03-18 8:37 ` Tianling Shen [this message]
2023-03-18 8:37 ` [PATCH v2 5/5] arm64: dts: rockchip: remove I2S1 TDM node for the NanoPi R5 series Tianling Shen
2023-03-22 23:40 ` [PATCH v2 0/5] arm64: dts: rockchip: improve support for " Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230318083745.6181-5-cnsztl@gmail.com \
--to=cnsztl@gmail.com \
--cc=aholmes@omnom.net \
--cc=anarsoul@gmail.com \
--cc=andrew@lunn.ch \
--cc=andyshrk@163.com \
--cc=briannorris@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jagan@amarulasolutions.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=maccraft123mc@gmail.com \
--cc=macromorgan@hotmail.com \
--cc=michael.riesch@wolfvision.net \
--cc=pgwipeout@gmail.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sebastian.reichel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).