From: Jonathan Cameron <jic23@kernel.org>
To: Marijn Suijten <marijn.suijten@somainline.org>
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Rob Herring <robh@kernel.org>,
phone-devel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@somainline.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Martin Botka <martin.botka@somainline.org>,
Jami Kettunen <jami.kettunen@somainline.org>,
iio@vger.kernel.org, Lars-Peter Clausen <lars@metafoo.de>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Manivannan Sadhasivam <mani@kernel.org>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
"Rafael J. Wysocki" <rafael@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Amit Kucheria <amitk@kernel.org>, Zhang Rui <rui.zhang@intel.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
linux-pm@vger.kernel.org
Subject: Re: [PATCH v3 2/3] dt-bindings: thermal: qcom-spmi-adc-tm5: Use generic ADC node name
Date: Sat, 18 Mar 2023 16:44:49 +0000 [thread overview]
Message-ID: <20230318164449.1df8d0be@jic23-huawei> (raw)
In-Reply-To: <20230316224450.onx2bldlisfwwp23@SoMainline.org>
On Thu, 16 Mar 2023 23:44:50 +0100
Marijn Suijten <marijn.suijten@somainline.org> wrote:
> On 2023-03-16 17:44:28, Jonathan Cameron wrote:
> <snip>
> > > Should it inherit the common binding, or was it omitted for a reason?
> >
> > Harmless but little point as far as I can see given we don't happen
> > to have any of the generic elements defined in the generic channel
> > binding.
>
> Supposedly the reg property, and now also the node name. Up to you to
> say whether I should inherit this (and strip out the common bits) or
> just focus on renaming the node name in the existing binding to channel.
>
> - Marijn
Just rename the node name.
Jonathan
next prev parent reply other threads:[~2023-03-18 16:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 20:44 [PATCH v3 0/3] arm64: dts: qcom: Use labels with generic node names for ADC channels Marijn Suijten
2023-02-01 20:44 ` [PATCH v3 1/3] " Marijn Suijten
2023-02-01 20:44 ` [PATCH v3 2/3] dt-bindings: thermal: qcom-spmi-adc-tm5: Use generic ADC node name Marijn Suijten
2023-02-03 21:25 ` Rob Herring
2023-02-05 15:06 ` Jonathan Cameron
2023-03-16 12:43 ` Marijn Suijten
2023-03-16 17:44 ` Jonathan Cameron
2023-03-16 22:44 ` Marijn Suijten
2023-03-18 16:44 ` Jonathan Cameron [this message]
2023-02-01 20:44 ` [PATCH v3 3/3] dt-bindings: iio: adc: Require generic adc-chan name for channel nodes Marijn Suijten
2023-02-02 8:50 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230318164449.1df8d0be@jic23-huawei \
--to=jic23@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=agross@kernel.org \
--cc=amitk@kernel.org \
--cc=andersson@kernel.org \
--cc=angelogioacchino.delregno@somainline.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=iio@vger.kernel.org \
--cc=jami.kettunen@somainline.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mani@kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=martin.botka@somainline.org \
--cc=phone-devel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=rui.zhang@intel.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).