From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EB4DC74A5B for ; Sat, 18 Mar 2023 16:30:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229677AbjCRQaC (ORCPT ); Sat, 18 Mar 2023 12:30:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229550AbjCRQaC (ORCPT ); Sat, 18 Mar 2023 12:30:02 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1C552799D; Sat, 18 Mar 2023 09:29:59 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8A8D560ECD; Sat, 18 Mar 2023 16:29:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8AD7AC433D2; Sat, 18 Mar 2023 16:29:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679156998; bh=AtbWDM1b1XIpGRo7m2NM4jhZhIEsMXFc9F32RHnTV28=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=iMB8iIJTtSXQ+NdBrNljqloJ2P9Y/xMgrznOuh2ymmwV7/7wKl19c8ypEt35+Oe2l NiqChXqnHyTjfYmvYJzZ6WdL2Rl1hUOFWve2BALpBW6jkHBuC2oFHC5yEjOrpn1wS3 y86QbOiIuktLoGuhofx4MgOf6PpK69yNQLyUVUtGSYPv/ERgC7kmK3jQKWegjK54r1 3Ap9rx3UbUlY9q25igt5BgxiMVjgTPiEJfyv0S7Wa8/KRrvZUddv6EPm4KYrMSdq2h aejq/a5Hkf2ioi8iRu0ZaclhlU1WWmKkffgFUUjxxyOqGIvcB3fVMzbT6yABfS0n0N E/AnHJLEciYCQ== Date: Sat, 18 Mar 2023 16:44:49 +0000 From: Jonathan Cameron To: Marijn Suijten Cc: Jonathan Cameron , Rob Herring , phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Jami Kettunen , iio@vger.kernel.org, Lars-Peter Clausen , Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Manivannan Sadhasivam , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui , Dmitry Baryshkov , linux-pm@vger.kernel.org Subject: Re: [PATCH v3 2/3] dt-bindings: thermal: qcom-spmi-adc-tm5: Use generic ADC node name Message-ID: <20230318164449.1df8d0be@jic23-huawei> In-Reply-To: <20230316224450.onx2bldlisfwwp23@SoMainline.org> References: <20230201204447.542385-1-marijn.suijten@somainline.org> <20230201204447.542385-3-marijn.suijten@somainline.org> <20230203212501.GA908601-robh@kernel.org> <20230205150645.549ff062@jic23-huawei> <20230316124307.pzuvbacsmjdootfx@SoMainline.org> <20230316174428.00003c4c@Huawei.com> <20230316224450.onx2bldlisfwwp23@SoMainline.org> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.37; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, 16 Mar 2023 23:44:50 +0100 Marijn Suijten wrote: > On 2023-03-16 17:44:28, Jonathan Cameron wrote: > > > > Should it inherit the common binding, or was it omitted for a reason? > > > > Harmless but little point as far as I can see given we don't happen > > to have any of the generic elements defined in the generic channel > > binding. > > Supposedly the reg property, and now also the node name. Up to you to > say whether I should inherit this (and strip out the common bits) or > just focus on renaming the node name in the existing binding to channel. > > - Marijn Just rename the node name. Jonathan