From: Lakshmi Yadlapati <lakshmiy@us.ibm.com>
To: robh+dt@kernel.org, linux@roeck-us.net, jdelvare@suse.com,
krzysztof.kozlowski+dt@linaro.org, joel@jms.id.au,
andrew@aj.id.au, eajames@linux.ibm.com
Cc: linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org,
devicetree@vger.kernel.org,
Lakshmi Yadlapati <lakshmiy@us.ibm.com>
Subject: [PATCH v2 3/5] hwmon: (pmbus/acbel-crps) Add Acbel CRPS power supply driver
Date: Mon, 20 Mar 2023 10:40:17 -0500 [thread overview]
Message-ID: <20230320154019.1943770-4-lakshmiy@us.ibm.com> (raw)
In-Reply-To: <20230320154019.1943770-1-lakshmiy@us.ibm.com>
Add the driver to support Acbel CRPS power supply.
Signed-off-by: Lakshmi Yadlapati <lakshmiy@us.ibm.com>
---
Changes since V1
- Removed debugfs stuff.
- Removed acbel_crps_read_word_data and acbel_crps_read_byte_data.
- Removed PMBUS_MFR_IIN_MAX.
- Added validation for the supported power supply.
- Fix the formatting.
drivers/hwmon/pmbus/Kconfig | 10 +++
drivers/hwmon/pmbus/Makefile | 1 +
drivers/hwmon/pmbus/acbel-crps.c | 102 +++++++++++++++++++++++++++++++
3 files changed, 113 insertions(+)
create mode 100644 drivers/hwmon/pmbus/acbel-crps.c
diff --git a/drivers/hwmon/pmbus/Kconfig b/drivers/hwmon/pmbus/Kconfig
index 59d9a7430499..0215709c3dd2 100644
--- a/drivers/hwmon/pmbus/Kconfig
+++ b/drivers/hwmon/pmbus/Kconfig
@@ -27,6 +27,16 @@ config SENSORS_PMBUS
This driver can also be built as a module. If so, the module will
be called pmbus.
+config SENSORS_ACBEL_CRPS
+ tristate "ACBEL CRPS Power Supply"
+ help
+ If you say yes here you get hardware monitoring support for the ACBEL
+ Common Redundant Power Supply.
+
+ This driver can also be built as a module. If so, the module will
+ be called acbel-crps.
+ Supported models: FSG032-00xG
+
config SENSORS_ADM1266
tristate "Analog Devices ADM1266 Sequencer"
select CRC8
diff --git a/drivers/hwmon/pmbus/Makefile b/drivers/hwmon/pmbus/Makefile
index 3ae019916267..39aef0cb9934 100644
--- a/drivers/hwmon/pmbus/Makefile
+++ b/drivers/hwmon/pmbus/Makefile
@@ -5,6 +5,7 @@
obj-$(CONFIG_PMBUS) += pmbus_core.o
obj-$(CONFIG_SENSORS_PMBUS) += pmbus.o
+obj-$(CONFIG_SENSORS_ACBEL_CRPS) += acbel-crps.o
obj-$(CONFIG_SENSORS_ADM1266) += adm1266.o
obj-$(CONFIG_SENSORS_ADM1275) += adm1275.o
obj-$(CONFIG_SENSORS_BEL_PFE) += bel-pfe.o
diff --git a/drivers/hwmon/pmbus/acbel-crps.c b/drivers/hwmon/pmbus/acbel-crps.c
new file mode 100644
index 000000000000..ac281699709f
--- /dev/null
+++ b/drivers/hwmon/pmbus/acbel-crps.c
@@ -0,0 +1,102 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+/*
+ * Copyright 2023 IBM Corp.
+ */
+
+#include <linux/device.h>
+#include <linux/fs.h>
+#include <linux/i2c.h>
+#include <linux/module.h>
+#include <linux/pmbus.h>
+#include <linux/hwmon-sysfs.h>
+#include "pmbus.h"
+
+struct acbel_crps {
+ struct i2c_client *client;
+};
+
+static const struct i2c_device_id acbel_crps_id[] = {
+ { "acbel_crps" },
+ {}
+};
+#define to_psu(x, y) container_of((x), struct acbel_crps, debugfs_entries[(y)])
+
+static const struct file_operations acbel_crps_fops = {
+ .llseek = noop_llseek,
+ .open = simple_open,
+};
+
+static struct pmbus_driver_info acbel_crps_info = {
+ .pages = 1,
+ .func[0] = PMBUS_HAVE_VIN | PMBUS_HAVE_IIN | PMBUS_HAVE_PIN |
+ PMBUS_HAVE_VOUT | PMBUS_HAVE_IOUT | PMBUS_HAVE_POUT |
+ PMBUS_HAVE_TEMP | PMBUS_HAVE_TEMP2 | PMBUS_HAVE_TEMP3 |
+ PMBUS_HAVE_FAN12 | PMBUS_HAVE_STATUS_VOUT |
+ PMBUS_HAVE_STATUS_IOUT | PMBUS_HAVE_STATUS_TEMP |
+ PMBUS_HAVE_STATUS_INPUT | PMBUS_HAVE_STATUS_FAN12,
+};
+
+static int acbel_crps_probe(struct i2c_client *client)
+{
+ struct acbel_crps *psu;
+ u8 buf[I2C_SMBUS_BLOCK_MAX + 1];
+ struct device *dev = &client->dev;
+ int rc;
+
+ rc = i2c_smbus_read_block_data(client, PMBUS_MFR_ID, buf);
+ if (rc < 0) {
+ dev_err(dev, "Failed to read PMBUS_MFR_ID\n");
+ return rc;
+ }
+ if (strncmp(buf, "ACBEL", 5)) {
+ buf[rc] = '\0';
+ dev_err(dev, "Manufacturer '%s' not supported\n", buf);
+ return -ENODEV;
+ }
+
+ rc = i2c_smbus_read_block_data(client, PMBUS_MFR_MODEL, buf);
+ if (rc < 0) {
+ dev_err(dev, "Failed to read PMBUS_MFR_MODEL\n");
+ return rc;
+ }
+
+ if (strncmp(buf, "FSG032", 6)) {
+ buf[rc] = '\0';
+ dev_err(dev, "Model '%s' not supported\n", buf);
+ return -ENODEV;
+ }
+
+ rc = pmbus_do_probe(client, &acbel_crps_info);
+ if (rc)
+ return rc;
+ /*
+ * Don't fail the probe if there isn't enough memory for debugfs.
+ */
+ psu = devm_kzalloc(&client->dev, sizeof(*psu), GFP_KERNEL);
+ if (!psu)
+ return 0;
+
+ return 0;
+}
+
+static const struct of_device_id acbel_crps_of_match[] = {
+ { .compatible = "acbel,crps" },
+ {}
+};
+MODULE_DEVICE_TABLE(of, acbel_crps_of_match);
+
+static struct i2c_driver acbel_crps_driver = {
+ .driver = {
+ .name = "acbel-crps",
+ .of_match_table = acbel_crps_of_match,
+ },
+ .probe_new = acbel_crps_probe,
+ .id_table = acbel_crps_id,
+};
+
+module_i2c_driver(acbel_crps_driver);
+
+MODULE_AUTHOR("Lakshmi Yadlapati");
+MODULE_DESCRIPTION("PMBus driver for AcBel Power System power supplies");
+MODULE_LICENSE("GPL");
+MODULE_IMPORT_NS(PMBUS);
--
2.37.2
next prev parent reply other threads:[~2023-03-20 15:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 15:40 [PATCH v2 0/5] hwmon: (pmbus/acbel-crps) Add Acbel CRPS power supply driver Lakshmi Yadlapati
2023-03-20 15:40 ` [PATCH v2 1/5] dt-bindings: vendor-prefixes: Add prefix for acbel Lakshmi Yadlapati
2023-03-20 15:40 ` [PATCH v2 2/5] dt-bindings: trivial-devices: Add acbel,crps Lakshmi Yadlapati
2023-03-20 16:29 ` Krzysztof Kozlowski
2023-03-20 16:48 ` Lakshmi Yadlapati
2023-03-20 20:41 ` Guenter Roeck
2023-03-20 15:40 ` Lakshmi Yadlapati [this message]
2023-03-20 19:42 ` [PATCH v2 3/5] hwmon: (pmbus/acbel-crps) Add Acbel CRPS power supply driver kernel test robot
2023-03-20 20:31 ` Guenter Roeck
2023-03-21 5:31 ` kernel test robot
2023-03-20 15:40 ` [PATCH v2 4/5] docs: hwmon: Add documenttaion for acbel-crps PSU Lakshmi Yadlapati
2023-03-20 20:32 ` Guenter Roeck
2023-03-21 2:17 ` kernel test robot
2023-03-20 15:40 ` [PATCH v2 5/5] ARM: dts: aspeed: p10bmc: Change power supply info Lakshmi Yadlapati
2023-03-20 16:30 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230320154019.1943770-4-lakshmiy@us.ibm.com \
--to=lakshmiy@us.ibm.com \
--cc=andrew@aj.id.au \
--cc=devicetree@vger.kernel.org \
--cc=eajames@linux.ibm.com \
--cc=jdelvare@suse.com \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).