From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1EE8C6FD1C for ; Fri, 24 Mar 2023 17:42:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231571AbjCXRmM (ORCPT ); Fri, 24 Mar 2023 13:42:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35370 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229551AbjCXRmM (ORCPT ); Fri, 24 Mar 2023 13:42:12 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 69CCBC64C; Fri, 24 Mar 2023 10:42:11 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F35DF62C1A; Fri, 24 Mar 2023 17:42:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 391B9C433EF; Fri, 24 Mar 2023 17:42:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679679730; bh=sk7R+qaRnvRoyWIxFll8DPdn5wqX+Pp6np8xpvBRcZI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mxj9WV/IaFFX4jIdJ3milBTT3JlHExArc/Z4f+1/UtC229TqKbL1rMNHcYqoOtdNl pa853S/83SrYck1OLSCcvRigaFXNcSTyV+46DNrUChjEwGCYgtZkj8oA8Q8aBjZg7S dWuLlazxLkjXjVeQehHkjpkT5uG2gHlBNL95QLA2Gt2FeHcq5GdGrhg85tUrdKFdJy kFO/71V+xeVB4euOy6/Y73GROGYcDgzxLD1zdkvvmKO4tXQ0xjmcsTMI2UFWnucy4W fZUqdBh8GDsSfKUc7HA0wQnh0nmz6VSgjMxbzYAbvPgr/15QoktLoe4iDUCV/oSSRQ hBocaR0TrMPJA== Date: Fri, 24 Mar 2023 10:45:18 -0700 From: Bjorn Andersson To: Neil Armstrong Cc: Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Andy Gross , Konrad Dybcio , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/4] arm64: dts: qcom: sm8450: remove invalid properties in cluster-sleep nodes Message-ID: <20230324174518.2arvdglqqixmxqcp@ripper> References: <20230323-topic-sm8450-upstream-dt-bindings-fixes-v2-0-0ca1bea1a843@linaro.org> <20230323-topic-sm8450-upstream-dt-bindings-fixes-v2-2-0ca1bea1a843@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230323-topic-sm8450-upstream-dt-bindings-fixes-v2-2-0ca1bea1a843@linaro.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Mar 24, 2023 at 10:28:47AM +0100, Neil Armstrong wrote: > Fixes the following DT bindings check error: Is that because idle-state-name and local-timer-stop should not be defined for domain-idle-states or are you just clearing out the dtbs_check warning? According to cpu-capacity.txt local-timer-stop seems to have been a property relevant for clusters in the past, was this a mistake in the binding or did something change when this was moved to domain-idle-states? Regards, Bjorn > domain-idle-states: cluster-sleep-0: 'idle-state-name', 'local-timer-stop' do not match any of the regexes: > 'pinctrl-[0-9]+' > domain-idle-states: cluster-sleep-1: 'idle-state-name', 'local-timer-stop' do not match any of the regexes: > 'pinctrl-[0-9]+' > > Reviewed-by: Krzysztof Kozlowski > Signed-off-by: Neil Armstrong > --- > arch/arm64/boot/dts/qcom/sm8450.dtsi | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi > index 78fb65bd15cc..ff55fcfdd676 100644 > --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi > @@ -255,22 +255,18 @@ BIG_CPU_SLEEP_0: cpu-sleep-1-0 { > domain-idle-states { > CLUSTER_SLEEP_0: cluster-sleep-0 { > compatible = "domain-idle-state"; > - idle-state-name = "cluster-l3-off"; > arm,psci-suspend-param = <0x41000044>; > entry-latency-us = <1050>; > exit-latency-us = <2500>; > min-residency-us = <5309>; > - local-timer-stop; > }; > > CLUSTER_SLEEP_1: cluster-sleep-1 { > compatible = "domain-idle-state"; > - idle-state-name = "cluster-power-collapse"; > arm,psci-suspend-param = <0x4100c344>; > entry-latency-us = <2700>; > exit-latency-us = <3500>; > min-residency-us = <13959>; > - local-timer-stop; > }; > }; > }; > > -- > 2.34.1 >