devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] arm64: dts: imx8mm: Fix lcdif compatible
@ 2023-03-16 14:06 Alexander Stein
  2023-03-16 14:06 ` [PATCH 2/2] arm64: dts: imx8mm: Fix lcdif clock order Alexander Stein
  2023-03-27  2:34 ` [PATCH 1/2] arm64: dts: imx8mm: Fix lcdif compatible Shawn Guo
  0 siblings, 2 replies; 4+ messages in thread
From: Alexander Stein @ 2023-03-16 14:06 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Shawn Guo, Sascha Hauer,
	Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team
  Cc: Alexander Stein, devicetree, linux-arm-kernel

imx8mm-lcdif is compatible to imx6sx-lcdif.

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 arch/arm64/boot/dts/freescale/imx8mm.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
index fedd32cfa47a..1de455ba21da 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
@@ -1120,7 +1120,7 @@ aips4: bus@32c00000 {
 			ranges = <0x32c00000 0x32c00000 0x400000>;
 
 			lcdif: lcdif@32e00000 {
-				compatible = "fsl,imx28-lcdif";
+				compatible = "fsl,imx8mm-lcdif", "fsl,imx6sx-lcdif";
 				reg = <0x32e00000 0x10000>;
 				clocks = <&clk IMX8MM_CLK_LCDIF_PIXEL>,
 					 <&clk IMX8MM_CLK_DISP_AXI_ROOT>,
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/2] arm64: dts: imx8mm: Fix lcdif clock order
  2023-03-16 14:06 [PATCH 1/2] arm64: dts: imx8mm: Fix lcdif compatible Alexander Stein
@ 2023-03-16 14:06 ` Alexander Stein
  2023-03-27  2:34 ` [PATCH 1/2] arm64: dts: imx8mm: Fix lcdif compatible Shawn Guo
  1 sibling, 0 replies; 4+ messages in thread
From: Alexander Stein @ 2023-03-16 14:06 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Shawn Guo, Sascha Hauer,
	Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team
  Cc: Alexander Stein, devicetree, linux-arm-kernel

Fixes the dtbs_check warnings:
lcdif@32e00000: clock-names:1: 'axi' was expected
lcdif@32e00000: clock-names:2: 'disp_axi' was expected

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 arch/arm64/boot/dts/freescale/imx8mm.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
index 1de455ba21da..1474c7fa9312 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
@@ -1123,9 +1123,9 @@ lcdif: lcdif@32e00000 {
 				compatible = "fsl,imx8mm-lcdif", "fsl,imx6sx-lcdif";
 				reg = <0x32e00000 0x10000>;
 				clocks = <&clk IMX8MM_CLK_LCDIF_PIXEL>,
-					 <&clk IMX8MM_CLK_DISP_AXI_ROOT>,
-					 <&clk IMX8MM_CLK_DISP_APB_ROOT>;
-				clock-names = "pix", "disp_axi", "axi";
+					 <&clk IMX8MM_CLK_DISP_APB_ROOT>,
+					 <&clk IMX8MM_CLK_DISP_AXI_ROOT>;
+				clock-names = "pix", "axi", "disp_axi";
 				assigned-clocks = <&clk IMX8MM_CLK_LCDIF_PIXEL>,
 						  <&clk IMX8MM_CLK_DISP_AXI>,
 						  <&clk IMX8MM_CLK_DISP_APB>;
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] arm64: dts: imx8mm: Fix lcdif compatible
  2023-03-16 14:06 [PATCH 1/2] arm64: dts: imx8mm: Fix lcdif compatible Alexander Stein
  2023-03-16 14:06 ` [PATCH 2/2] arm64: dts: imx8mm: Fix lcdif clock order Alexander Stein
@ 2023-03-27  2:34 ` Shawn Guo
  2023-03-27  8:50   ` Alexander Stein
  1 sibling, 1 reply; 4+ messages in thread
From: Shawn Guo @ 2023-03-27  2:34 UTC (permalink / raw)
  To: Alexander Stein
  Cc: Rob Herring, Krzysztof Kozlowski, Sascha Hauer,
	Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
	devicetree, linux-arm-kernel

On Thu, Mar 16, 2023 at 03:06:45PM +0100, Alexander Stein wrote:
> imx8mm-lcdif is compatible to imx6sx-lcdif.
> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>

Doesn't apply for me.

Shawn

> ---
>  arch/arm64/boot/dts/freescale/imx8mm.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> index fedd32cfa47a..1de455ba21da 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> @@ -1120,7 +1120,7 @@ aips4: bus@32c00000 {
>  			ranges = <0x32c00000 0x32c00000 0x400000>;
>  
>  			lcdif: lcdif@32e00000 {
> -				compatible = "fsl,imx28-lcdif";
> +				compatible = "fsl,imx8mm-lcdif", "fsl,imx6sx-lcdif";
>  				reg = <0x32e00000 0x10000>;
>  				clocks = <&clk IMX8MM_CLK_LCDIF_PIXEL>,
>  					 <&clk IMX8MM_CLK_DISP_AXI_ROOT>,
> -- 
> 2.34.1
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] arm64: dts: imx8mm: Fix lcdif compatible
  2023-03-27  2:34 ` [PATCH 1/2] arm64: dts: imx8mm: Fix lcdif compatible Shawn Guo
@ 2023-03-27  8:50   ` Alexander Stein
  0 siblings, 0 replies; 4+ messages in thread
From: Alexander Stein @ 2023-03-27  8:50 UTC (permalink / raw)
  To: Shawn Guo
  Cc: Rob Herring, Krzysztof Kozlowski, Sascha Hauer,
	Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
	devicetree, linux-arm-kernel

Am Montag, 27. März 2023, 04:34:44 CEST schrieb Shawn Guo:
> On Thu, Mar 16, 2023 at 03:06:45PM +0100, Alexander Stein wrote:
> > imx8mm-lcdif is compatible to imx6sx-lcdif.
> > 
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> 
> Doesn't apply for me.

Ah, you are right. These are patches based on Jagan's MIPI-DSI support.
I'll resubmit once that series is applied.

Best regards,
Alexander

> Shawn
> 
> > ---
> > 
> >  arch/arm64/boot/dts/freescale/imx8mm.dtsi | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > b/arch/arm64/boot/dts/freescale/imx8mm.dtsi index
> > fedd32cfa47a..1de455ba21da 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > @@ -1120,7 +1120,7 @@ aips4: bus@32c00000 {
> > 
> >  			ranges = <0x32c00000 0x32c00000 0x400000>;
> >  			
> >  			lcdif: lcdif@32e00000 {
> > 
> > -				compatible = "fsl,imx28-lcdif";
> > +				compatible = "fsl,imx8mm-lcdif", 
"fsl,imx6sx-lcdif";
> > 
> >  				reg = <0x32e00000 0x10000>;
> >  				clocks = <&clk 
IMX8MM_CLK_LCDIF_PIXEL>,
> >  				
> >  					 <&clk 
IMX8MM_CLK_DISP_AXI_ROOT>,


-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-03-27  8:55 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-16 14:06 [PATCH 1/2] arm64: dts: imx8mm: Fix lcdif compatible Alexander Stein
2023-03-16 14:06 ` [PATCH 2/2] arm64: dts: imx8mm: Fix lcdif clock order Alexander Stein
2023-03-27  2:34 ` [PATCH 1/2] arm64: dts: imx8mm: Fix lcdif compatible Shawn Guo
2023-03-27  8:50   ` Alexander Stein

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).