From: Christian Marangi <ansuelsmth@gmail.com>
To: Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Gregory Clement <gregory.clement@bootlin.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Christian Marangi <ansuelsmth@gmail.com>,
John Crispin <john@phrozen.org>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org
Subject: [net-next PATCH v6 07/16] net: phy: marvell: Add software control of the LEDs
Date: Mon, 27 Mar 2023 16:10:22 +0200 [thread overview]
Message-ID: <20230327141031.11904-8-ansuelsmth@gmail.com> (raw)
In-Reply-To: <20230327141031.11904-1-ansuelsmth@gmail.com>
From: Andrew Lunn <andrew@lunn.ch>
Add a brightness function, so the LEDs can be controlled from
software using the standard Linux LED infrastructure.
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
---
drivers/net/phy/marvell.c | 45 ++++++++++++++++++++++++++++++++++-----
1 file changed, 40 insertions(+), 5 deletions(-)
diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c
index 63a3644d86c9..5f4caca93983 100644
--- a/drivers/net/phy/marvell.c
+++ b/drivers/net/phy/marvell.c
@@ -144,11 +144,13 @@
/* WOL Event Interrupt Enable */
#define MII_88E1318S_PHY_CSIER_WOL_EIE BIT(7)
-/* LED Timer Control Register */
-#define MII_88E1318S_PHY_LED_TCR 0x12
-#define MII_88E1318S_PHY_LED_TCR_FORCE_INT BIT(15)
-#define MII_88E1318S_PHY_LED_TCR_INTn_ENABLE BIT(7)
-#define MII_88E1318S_PHY_LED_TCR_INT_ACTIVE_LOW BIT(11)
+#define MII_88E1318S_PHY_LED_FUNC 0x10
+#define MII_88E1318S_PHY_LED_FUNC_OFF (0x8)
+#define MII_88E1318S_PHY_LED_FUNC_ON (0x9)
+#define MII_88E1318S_PHY_LED_TCR 0x12
+#define MII_88E1318S_PHY_LED_TCR_FORCE_INT BIT(15)
+#define MII_88E1318S_PHY_LED_TCR_INTn_ENABLE BIT(7)
+#define MII_88E1318S_PHY_LED_TCR_INT_ACTIVE_LOW BIT(11)
/* Magic Packet MAC address registers */
#define MII_88E1318S_PHY_MAGIC_PACKET_WORD2 0x17
@@ -2832,6 +2834,34 @@ static int marvell_hwmon_probe(struct phy_device *phydev)
}
#endif
+static int m88e1318_led_brightness_set(struct phy_device *phydev,
+ u32 index, enum led_brightness value)
+{
+ int reg;
+
+ reg = phy_read_paged(phydev, MII_MARVELL_LED_PAGE,
+ MII_88E1318S_PHY_LED_FUNC);
+ if (reg < 0)
+ return reg;
+
+ switch (index) {
+ case 0:
+ case 1:
+ case 2:
+ reg &= ~(0xf << (4 * index));
+ if (value == LED_OFF)
+ reg |= MII_88E1318S_PHY_LED_FUNC_OFF << (4 * index);
+ else
+ reg |= MII_88E1318S_PHY_LED_FUNC_ON << (4 * index);
+ break;
+ default:
+ return -EINVAL;
+ }
+
+ return phy_write_paged(phydev, MII_MARVELL_LED_PAGE,
+ MII_88E1318S_PHY_LED_FUNC, reg);
+}
+
static int marvell_probe(struct phy_device *phydev)
{
struct marvell_priv *priv;
@@ -3081,6 +3111,7 @@ static struct phy_driver marvell_drivers[] = {
.get_sset_count = marvell_get_sset_count,
.get_strings = marvell_get_strings,
.get_stats = marvell_get_stats,
+ .led_brightness_set = m88e1318_led_brightness_set,
},
{
.phy_id = MARVELL_PHY_ID_88E1145,
@@ -3187,6 +3218,7 @@ static struct phy_driver marvell_drivers[] = {
.cable_test_start = marvell_vct7_cable_test_start,
.cable_test_tdr_start = marvell_vct5_cable_test_tdr_start,
.cable_test_get_status = marvell_vct7_cable_test_get_status,
+ .led_brightness_set = m88e1318_led_brightness_set,
},
{
.phy_id = MARVELL_PHY_ID_88E1540,
@@ -3213,6 +3245,7 @@ static struct phy_driver marvell_drivers[] = {
.cable_test_start = marvell_vct7_cable_test_start,
.cable_test_tdr_start = marvell_vct5_cable_test_tdr_start,
.cable_test_get_status = marvell_vct7_cable_test_get_status,
+ .led_brightness_set = m88e1318_led_brightness_set,
},
{
.phy_id = MARVELL_PHY_ID_88E1545,
@@ -3239,6 +3272,7 @@ static struct phy_driver marvell_drivers[] = {
.cable_test_start = marvell_vct7_cable_test_start,
.cable_test_tdr_start = marvell_vct5_cable_test_tdr_start,
.cable_test_get_status = marvell_vct7_cable_test_get_status,
+ .led_brightness_set = m88e1318_led_brightness_set,
},
{
.phy_id = MARVELL_PHY_ID_88E3016,
@@ -3380,6 +3414,7 @@ static struct phy_driver marvell_drivers[] = {
.get_stats = marvell_get_stats,
.get_tunable = m88e1540_get_tunable,
.set_tunable = m88e1540_set_tunable,
+ .led_brightness_set = m88e1318_led_brightness_set,
},
};
--
2.39.2
next prev parent reply other threads:[~2023-03-27 14:12 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 14:10 [net-next PATCH v6 00/16] net: Add basic LED support for switch/phy Christian Marangi
2023-03-27 14:10 ` [net-next PATCH v6 01/16] net: dsa: qca8k: move qca8k_port_to_phy() to header Christian Marangi
2023-04-13 14:05 ` Florian Fainelli
2023-03-27 14:10 ` [net-next PATCH v6 02/16] net: dsa: qca8k: add LEDs basic support Christian Marangi
2023-03-27 14:10 ` [net-next PATCH v6 03/16] net: dsa: qca8k: add LEDs blink_set() support Christian Marangi
2023-04-13 14:06 ` Florian Fainelli
2023-03-27 14:10 ` [net-next PATCH v6 04/16] leds: Provide stubs for when CLASS_LED & NEW_LEDS are disabled Christian Marangi
2023-04-13 13:58 ` Florian Fainelli
2023-03-27 14:10 ` [net-next PATCH v6 05/16] net: phy: Add a binding for PHY LEDs Christian Marangi
2023-03-27 14:10 ` [net-next PATCH v6 06/16] net: phy: phy_device: Call into the PHY driver to set LED brightness Christian Marangi
2023-04-13 13:57 ` Florian Fainelli
2023-04-12 23:11 ` Christian Marangi
2023-04-13 14:04 ` Florian Fainelli
2023-04-13 14:43 ` Andrew Lunn
2023-04-13 14:48 ` Andrew Lunn
2023-03-27 14:10 ` Christian Marangi [this message]
2023-04-13 13:55 ` [net-next PATCH v6 07/16] net: phy: marvell: Add software control of the LEDs Florian Fainelli
2023-03-27 14:10 ` [net-next PATCH v6 08/16] net: phy: phy_device: Call into the PHY driver to set LED blinking Christian Marangi
2023-04-13 13:56 ` Florian Fainelli
2023-03-27 14:10 ` [net-next PATCH v6 09/16] net: phy: marvell: Implement led_blink_set() Christian Marangi
2023-04-13 13:58 ` Florian Fainelli
2023-03-27 14:10 ` [net-next PATCH v6 10/16] dt-bindings: leds: Document support for generic ethernet LEDs Christian Marangi
2023-03-31 20:09 ` Rob Herring
2023-03-27 14:10 ` [net-next PATCH v6 11/16] dt-bindings: net: ethernet-controller: Document support for LEDs node Christian Marangi
2023-03-27 14:10 ` [net-next PATCH v6 12/16] dt-bindings: net: dsa: qca8k: add LEDs definition example Christian Marangi
2023-04-06 14:10 ` Rob Herring
2023-04-12 22:42 ` Christian Marangi
2023-04-13 13:49 ` Andrew Lunn
2023-03-27 14:10 ` [net-next PATCH v6 13/16] ARM: dts: qcom: ipq8064-rb3011: Drop unevaluated properties in switch nodes Christian Marangi
2023-04-09 16:15 ` Jonathan McDowell
2023-03-27 14:10 ` [net-next PATCH v6 14/16] ARM: dts: qcom: ipq8064-rb3011: Add Switch LED for each port Christian Marangi
2023-03-27 14:10 ` [net-next PATCH v6 15/16] dt-bindings: net: phy: Document support for LEDs node Christian Marangi
2023-03-27 14:10 ` [net-next PATCH v6 16/16] arm: mvebu: dt: Add PHY LED support for 370-rd WAN port Christian Marangi
2023-03-28 8:31 ` Pavel Machek
2023-03-28 11:59 ` Andrew Lunn
2023-04-03 19:54 ` Pavel Machek
2023-04-04 19:52 ` Andrew Lunn
2023-04-06 9:18 ` Pavel Machek
2023-04-06 13:54 ` Andrew Lunn
2023-04-03 18:46 ` Rob Herring
2023-04-03 19:28 ` Andrew Lunn
2023-03-28 1:46 ` [net-next PATCH v6 00/16] net: Add basic LED support for switch/phy Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230327141031.11904-8-ansuelsmth@gmail.com \
--to=ansuelsmth@gmail.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=gregory.clement@bootlin.com \
--cc=hkallweit1@gmail.com \
--cc=john@phrozen.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).