devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Christian Marangi <ansuelsmth@gmail.com>
Cc: Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Andrew Lunn <andrew@lunn.ch>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Vladimir Oltean <olteanv@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	Gregory Clement <gregory.clement@bootlin.com>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	John Crispin <john@phrozen.org>,
	linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-arm-msm@vger.kernel.org
Subject: Re: [net-next PATCH v6 00/16] net: Add basic LED support for switch/phy
Date: Mon, 27 Mar 2023 18:46:06 -0700	[thread overview]
Message-ID: <20230327184606.37933d41@kernel.org> (raw)
In-Reply-To: <20230327141031.11904-1-ansuelsmth@gmail.com>

On Mon, 27 Mar 2023 16:10:15 +0200 Christian Marangi wrote:
> This is a continue of [1]. It was decided to take a more gradual
> approach to implement LEDs support for switch and phy starting with
> basic support and then implementing the hw control part when we have all
> the prereq done.
> 
> This series implements only the brightness_set() and blink_set() ops.
> An example of switch implementation is done with qca8k.
> 
> For PHY a more generic approach is used with implementing the LED
> support in PHY core and with the user (in this case marvell) adding all
> the required functions.
> 
> Currently we set the default-state as "keep" to not change the default
> configuration of the declared LEDs since almost every switch have a
> default configuration.

Please run ./scripts/kernel-doc -none on the headers,
the new ops added in patches 6 and 8 need to be kdoc'ed.

      parent reply	other threads:[~2023-03-28  1:46 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-27 14:10 [net-next PATCH v6 00/16] net: Add basic LED support for switch/phy Christian Marangi
2023-03-27 14:10 ` [net-next PATCH v6 01/16] net: dsa: qca8k: move qca8k_port_to_phy() to header Christian Marangi
2023-04-13 14:05   ` Florian Fainelli
2023-03-27 14:10 ` [net-next PATCH v6 02/16] net: dsa: qca8k: add LEDs basic support Christian Marangi
2023-03-27 14:10 ` [net-next PATCH v6 03/16] net: dsa: qca8k: add LEDs blink_set() support Christian Marangi
2023-04-13 14:06   ` Florian Fainelli
2023-03-27 14:10 ` [net-next PATCH v6 04/16] leds: Provide stubs for when CLASS_LED & NEW_LEDS are disabled Christian Marangi
2023-04-13 13:58   ` Florian Fainelli
2023-03-27 14:10 ` [net-next PATCH v6 05/16] net: phy: Add a binding for PHY LEDs Christian Marangi
2023-03-27 14:10 ` [net-next PATCH v6 06/16] net: phy: phy_device: Call into the PHY driver to set LED brightness Christian Marangi
2023-04-13 13:57   ` Florian Fainelli
2023-04-12 23:11     ` Christian Marangi
2023-04-13 14:04       ` Florian Fainelli
2023-04-13 14:43         ` Andrew Lunn
2023-04-13 14:48     ` Andrew Lunn
2023-03-27 14:10 ` [net-next PATCH v6 07/16] net: phy: marvell: Add software control of the LEDs Christian Marangi
2023-04-13 13:55   ` Florian Fainelli
2023-03-27 14:10 ` [net-next PATCH v6 08/16] net: phy: phy_device: Call into the PHY driver to set LED blinking Christian Marangi
2023-04-13 13:56   ` Florian Fainelli
2023-03-27 14:10 ` [net-next PATCH v6 09/16] net: phy: marvell: Implement led_blink_set() Christian Marangi
2023-04-13 13:58   ` Florian Fainelli
2023-03-27 14:10 ` [net-next PATCH v6 10/16] dt-bindings: leds: Document support for generic ethernet LEDs Christian Marangi
2023-03-31 20:09   ` Rob Herring
2023-03-27 14:10 ` [net-next PATCH v6 11/16] dt-bindings: net: ethernet-controller: Document support for LEDs node Christian Marangi
2023-03-27 14:10 ` [net-next PATCH v6 12/16] dt-bindings: net: dsa: qca8k: add LEDs definition example Christian Marangi
2023-04-06 14:10   ` Rob Herring
2023-04-12 22:42     ` Christian Marangi
2023-04-13 13:49       ` Andrew Lunn
2023-03-27 14:10 ` [net-next PATCH v6 13/16] ARM: dts: qcom: ipq8064-rb3011: Drop unevaluated properties in switch nodes Christian Marangi
2023-04-09 16:15   ` Jonathan McDowell
2023-03-27 14:10 ` [net-next PATCH v6 14/16] ARM: dts: qcom: ipq8064-rb3011: Add Switch LED for each port Christian Marangi
2023-03-27 14:10 ` [net-next PATCH v6 15/16] dt-bindings: net: phy: Document support for LEDs node Christian Marangi
2023-03-27 14:10 ` [net-next PATCH v6 16/16] arm: mvebu: dt: Add PHY LED support for 370-rd WAN port Christian Marangi
2023-03-28  8:31   ` Pavel Machek
2023-03-28 11:59     ` Andrew Lunn
2023-04-03 19:54       ` Pavel Machek
2023-04-04 19:52         ` Andrew Lunn
2023-04-06  9:18           ` Pavel Machek
2023-04-06 13:54             ` Andrew Lunn
2023-04-03 18:46   ` Rob Herring
2023-04-03 19:28     ` Andrew Lunn
2023-03-28  1:46 ` Jakub Kicinski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230327184606.37933d41@kernel.org \
    --to=kuba@kernel.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=ansuelsmth@gmail.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=f.fainelli@gmail.com \
    --cc=gregory.clement@bootlin.com \
    --cc=hkallweit1@gmail.com \
    --cc=john@phrozen.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lee@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=pabeni@redhat.com \
    --cc=pavel@ucw.cz \
    --cc=robh+dt@kernel.org \
    --cc=sebastian.hesselbarth@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).