From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B228C77B60 for ; Mon, 27 Mar 2023 21:05:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229663AbjC0VFF (ORCPT ); Mon, 27 Mar 2023 17:05:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57302 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232211AbjC0VFA (ORCPT ); Mon, 27 Mar 2023 17:05:00 -0400 Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B3F530F6 for ; Mon, 27 Mar 2023 14:04:41 -0700 (PDT) Received: by mail-pl1-x635.google.com with SMTP id ja10so9706208plb.5 for ; Mon, 27 Mar 2023 14:04:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679951072; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=b3BlSIi0ORzZ5YgJoiJ2zZR40sarw+gdRjnKYSAtweI=; b=XVYLZAn82SNr8CHuqtmYkJkZke6Dwb9mmza6Tr6duyH2uLzwFpsGEuLJlDCtwLBXeM x4PC/Mn0BYOjv/ucNuYuqrQ+ALj9Kk5QnKKlYKeLQkFSjyW0gNE+CHsaY6Fu5qsGsEY3 7sKht3oXlqDQGZoEfa0KPUbVpsIWayJfA0314uNadYqL7zK4B/ICYj+rRom7DohcVLAt 3Kqhjc23jPUEKaW0NXYCGLrs533jGLTo2xuYyw4+eIgy8kL5o//6nSL1k1IYq0zE/ppK DelojTwVDNIRSYtuH/5P43ctd4w5cm/yqW5FTDK3t0dJn1gq/JXN8FSrhNrrfj5P2n8V ih4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679951072; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=b3BlSIi0ORzZ5YgJoiJ2zZR40sarw+gdRjnKYSAtweI=; b=jMZrYnPuqo4InQXlz/3hXTcgH+kttQtA0AaAuCJ21mMw77yL1pktckDA+mCCXJ551P KrcCi8lPEbDPA0y+Lmzd/iI07glwOThZsOQSSkn/Uv8pFEy9mnbpPshthjJKM53Sy6NQ vglwC3xD70AeWHthvy7HKFEZLu++tngrnsXt0ZuTGnXS+lIb2w6ziNIPvSnE8cP11eI0 Xu1A06wrNftyjz6CM7V/9K5Xm7bzBY1lzjg1h5HssXMItL8imWp6MmvlCjFS26ore0Rl xBhPElxGluewFx/9SMq8Zw5elqvM+/oGH4eJ+PImRjXQjYMzS1FNIPReQ3MaRbjyaDRU U17Q== X-Gm-Message-State: AO0yUKWdaZuIq+7URZlZvqU1dpvMBpPXqKveubYGry08HtferO3qT+iL 7825yNmwGgYUfSq21duuyINkBg== X-Google-Smtp-Source: AK7set+9TmZNqzYd+qlWo/KxKxwystgsk67yWtkfaeiArceRtBW2JX+3k+aWeo8cfu/+upasRFTHJw== X-Received: by 2002:a05:6a20:3b26:b0:da:1b99:34f0 with SMTP id c38-20020a056a203b2600b000da1b9934f0mr11987345pzh.39.1679951072029; Mon, 27 Mar 2023 14:04:32 -0700 (PDT) Received: from p14s ([2604:3d09:148c:c800:ad52:968f:ad4a:52d2]) by smtp.gmail.com with ESMTPSA id 25-20020aa79159000000b0062bc045bf4fsm6212065pfi.19.2023.03.27.14.04.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Mar 2023 14:04:31 -0700 (PDT) Date: Mon, 27 Mar 2023 15:04:29 -0600 From: Mathieu Poirier To: MD Danish Anwar Cc: "Andrew F. Davis" , Suman Anna , Roger Quadros , Vignesh Raghavendra , Tero Kristo , Bjorn Andersson , Santosh Shilimkar , Nishanth Menon , linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, srk@ti.com, devicetree@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v5 5/5] soc: ti: pruss: Add helper functions to get/set PRUSS_CFG_GPMUX Message-ID: <20230327210429.GD3158115@p14s> References: <20230323062451.2925996-1-danishanwar@ti.com> <20230323062451.2925996-6-danishanwar@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230323062451.2925996-6-danishanwar@ti.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Mar 23, 2023 at 11:54:51AM +0530, MD Danish Anwar wrote: > From: Tero Kristo > > Add two new helper functions pruss_cfg_get_gpmux() & pruss_cfg_set_gpmux() > to get and set the GP MUX mode for programming the PRUSS internal wrapper > mux functionality as needed by usecases. > > Co-developed-by: Suman Anna > Signed-off-by: Suman Anna > Signed-off-by: Tero Kristo > Co-developed-by: Grzegorz Jaszczyk > Signed-off-by: Grzegorz Jaszczyk > Signed-off-by: Puranjay Mohan > Signed-off-by: MD Danish Anwar > Reviewed-by: Roger Quadros > --- > drivers/soc/ti/pruss.c | 44 ++++++++++++++++++++++++++++++++ > include/linux/remoteproc/pruss.h | 30 ++++++++++++++++++++++ > 2 files changed, 74 insertions(+) > > diff --git a/drivers/soc/ti/pruss.c b/drivers/soc/ti/pruss.c > index ac415442e85b..3aa3c38c6c79 100644 > --- a/drivers/soc/ti/pruss.c > +++ b/drivers/soc/ti/pruss.c > @@ -239,6 +239,50 @@ int pruss_cfg_xfr_enable(struct pruss *pruss, enum pru_type pru_type, > } > EXPORT_SYMBOL_GPL(pruss_cfg_xfr_enable); > > +/** > + * pruss_cfg_get_gpmux() - get the current GPMUX value for a PRU device > + * @pruss: pruss instance > + * @pru_id: PRU identifier (0-1) > + * @mux: pointer to store the current mux value into > + * > + * Return: 0 on success, or an error code otherwise > + */ > +int pruss_cfg_get_gpmux(struct pruss *pruss, enum pruss_pru_id pru_id, u8 *mux) > +{ > + int ret = 0; > + u32 val; > + > + if (pru_id < 0 || pru_id >= PRUSS_NUM_PRUS) > + return -EINVAL; > + > + ret = pruss_cfg_read(pruss, PRUSS_CFG_GPCFG(pru_id), &val); > + if (!ret) > + *mux = (u8)((val & PRUSS_GPCFG_PRU_MUX_SEL_MASK) >> > + PRUSS_GPCFG_PRU_MUX_SEL_SHIFT); What happens if @mux is NULL? Thanks, Mathieu > + return ret; > +} > +EXPORT_SYMBOL_GPL(pruss_cfg_get_gpmux); > + > +/** > + * pruss_cfg_set_gpmux() - set the GPMUX value for a PRU device > + * @pruss: pruss instance > + * @pru_id: PRU identifier (0-1) > + * @mux: new mux value for PRU > + * > + * Return: 0 on success, or an error code otherwise > + */ > +int pruss_cfg_set_gpmux(struct pruss *pruss, enum pruss_pru_id pru_id, u8 mux) > +{ > + if (mux >= PRUSS_GP_MUX_SEL_MAX || > + pru_id < 0 || pru_id >= PRUSS_NUM_PRUS) > + return -EINVAL; > + > + return pruss_cfg_update(pruss, PRUSS_CFG_GPCFG(pru_id), > + PRUSS_GPCFG_PRU_MUX_SEL_MASK, > + (u32)mux << PRUSS_GPCFG_PRU_MUX_SEL_SHIFT); > +} > +EXPORT_SYMBOL_GPL(pruss_cfg_set_gpmux); > + > static void pruss_of_free_clk_provider(void *data) > { > struct device_node *clk_mux_np = data; > diff --git a/include/linux/remoteproc/pruss.h b/include/linux/remoteproc/pruss.h > index bb001f712980..42f1586c62ac 100644 > --- a/include/linux/remoteproc/pruss.h > +++ b/include/linux/remoteproc/pruss.h > @@ -16,6 +16,24 @@ > > #define PRU_RPROC_DRVNAME "pru-rproc" > > +/* > + * enum pruss_gp_mux_sel - PRUSS GPI/O Mux modes for the > + * PRUSS_GPCFG0/1 registers > + * > + * NOTE: The below defines are the most common values, but there > + * are some exceptions like on 66AK2G, where the RESERVED and MII2 > + * values are interchanged. Also, this bit-field does not exist on > + * AM335x SoCs > + */ > +enum pruss_gp_mux_sel { > + PRUSS_GP_MUX_SEL_GP = 0, > + PRUSS_GP_MUX_SEL_ENDAT, > + PRUSS_GP_MUX_SEL_RESERVED, > + PRUSS_GP_MUX_SEL_SD, > + PRUSS_GP_MUX_SEL_MII2, > + PRUSS_GP_MUX_SEL_MAX, > +}; > + > /* > * enum pruss_gpi_mode - PRUSS GPI configuration modes, used > * to program the PRUSS_GPCFG0/1 registers > @@ -110,6 +128,8 @@ int pruss_cfg_gpimode(struct pruss *pruss, enum pruss_pru_id pru_id, > int pruss_cfg_miirt_enable(struct pruss *pruss, bool enable); > int pruss_cfg_xfr_enable(struct pruss *pruss, enum pru_type pru_type, > bool enable); > +int pruss_cfg_get_gpmux(struct pruss *pruss, enum pruss_pru_id pru_id, u8 *mux); > +int pruss_cfg_set_gpmux(struct pruss *pruss, enum pruss_pru_id pru_id, u8 mux); > > #else > > @@ -152,6 +172,16 @@ static inline int pruss_cfg_xfr_enable(struct pruss *pruss, > return ERR_PTR(-EOPNOTSUPP); > } > > +static inline int pruss_cfg_get_gpmux(struct pruss *pruss, enum pruss_pru_id pru_id, u8 *mux) > +{ > + return ERR_PTR(-EOPNOTSUPP); > +} > + > +static inline int pruss_cfg_set_gpmux(struct pruss *pruss, enum pruss_pru_id pru_id, u8 mux) > +{ > + return ERR_PTR(-EOPNOTSUPP); > +} > + > #endif /* CONFIG_TI_PRUSS */ > > #if IS_ENABLED(CONFIG_PRU_REMOTEPROC) > -- > 2.25.1 >