From: Tony Lindgren <tony@atomide.com>
To: Andreas Kemnade <andreas@kemnade.info>
Cc: "Andrew Davis" <afd@ti.com>, "Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Benoît Cousson" <bcousson@baylibre.com>,
"Colin Foster" <colin.foster@in-advantage.com>,
"Olof Johansson" <olof@lixom.net>,
"Arnd Bergmann" <arnd@arndb.de>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC 1/2] ARM: dts: omap: Drop ti,omap36xx compatible
Date: Tue, 28 Mar 2023 10:08:44 +0300 [thread overview]
Message-ID: <20230328070844.GN7501@atomide.com> (raw)
In-Reply-To: <20230328090603.317196c7@aktux>
* Andreas Kemnade <andreas@kemnade.info> [230328 07:06]:
> On Tue, 28 Mar 2023 08:01:15 +0300
> Tony Lindgren <tony@atomide.com> wrote:
>
> > * Andreas Kemnade <andreas@kemnade.info> [230327 19:18]:
> > > On Thu, 16 Feb 2023 09:33:38 -0600
> > > Andrew Davis <afd@ti.com> wrote:
> > >
> > > > This was not matched anywhere and provides no additional information.
> > > >
> > > > Signed-off-by: Andrew Davis <afd@ti.com>
> > > > ---
> > > > arch/arm/boot/dts/omap3-beagle-xm.dts | 2 +-
> > > > arch/arm/boot/dts/omap3-cm-t3730.dts | 2 +-
> > > > arch/arm/boot/dts/omap3-igep0020-rev-f.dts | 2 +-
> > > > arch/arm/boot/dts/omap3-igep0020.dts | 2 +-
> > > > arch/arm/boot/dts/omap3-igep0030-rev-g.dts | 2 +-
> > > > arch/arm/boot/dts/omap3-igep0030.dts | 2 +-
> > > > arch/arm/boot/dts/omap3-lilly-dbb056.dts | 2 +-
> > > > arch/arm/boot/dts/omap3-n9.dts | 2 +-
> > > > arch/arm/boot/dts/omap3-n950.dts | 2 +-
> > > > arch/arm/boot/dts/omap3-overo-storm-alto35.dts | 2 +-
> > > > arch/arm/boot/dts/omap3-overo-storm-chestnut43.dts | 2 +-
> > > > arch/arm/boot/dts/omap3-overo-storm-gallop43.dts | 2 +-
> > > > arch/arm/boot/dts/omap3-overo-storm-palo35.dts | 2 +-
> > > > arch/arm/boot/dts/omap3-overo-storm-palo43.dts | 2 +-
> > > > arch/arm/boot/dts/omap3-overo-storm-summit.dts | 2 +-
> > > > arch/arm/boot/dts/omap3-overo-storm-tobi.dts | 2 +-
> > > > arch/arm/boot/dts/omap3-overo-storm-tobiduo.dts | 2 +-
> > > > arch/arm/boot/dts/omap3-pandora-1ghz.dts | 2 +-
> > > > arch/arm/boot/dts/omap3-sbc-t3730.dts | 2 +-
> > > > arch/arm/boot/dts/omap3-sniper.dts | 2 +-
> > > > arch/arm/boot/dts/omap3-zoom3.dts | 2 +-
> > > > 21 files changed, 21 insertions(+), 21 deletions(-)
> > > >
> > > hmm, we have
> > > drivers/clk/ti/dpll.c: of_machine_is_compatible("ti,omap36xx"))
> > >
> > > but that is more completely
> > > if ((of_machine_is_compatible("ti,omap3630") ||
> > > of_machine_is_compatible("ti,omap36xx")) &&
> > >
> > > so missing omap36xx will not harm if 3630 is there. SO this should
> > > be probably ok.
> >
> > Looks like we still have these that should be patched away first:
> >
> > drivers/cpufreq/ti-cpufreq.c- { .compatible = "ti,omap34xx", .data = &omap34xx_soc_data, },
> > drivers/cpufreq/ti-cpufreq.c: { .compatible = "ti,omap36xx", .data = &omap36xx_soc_data, },
> >
> seen that but there is also
> { .compatible = "ti,omap3430", .data = &omap34xx_soc_data, },
> { .compatible = "ti,omap3630", .data = &omap36xx_soc_data, },
>
> so, no trouble will appear when omap36xx is removed.
Oh OK, thanks for pointing that out, looks like I missed it. Seems like
we should apply this patch already if no issues.
Regards,
Tony
next prev parent reply other threads:[~2023-03-28 7:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 15:33 [RFC 0/2] Convert omap.txt to DT schema Andrew Davis
2023-02-16 15:33 ` [RFC 1/2] ARM: dts: omap: Drop ti,omap36xx compatible Andrew Davis
2023-03-27 19:18 ` Andreas Kemnade
2023-03-28 5:01 ` Tony Lindgren
2023-03-28 7:06 ` Andreas Kemnade
2023-03-28 7:08 ` Tony Lindgren [this message]
2023-03-28 7:27 ` Tony Lindgren
2023-02-16 15:33 ` [RFC 2/2] WIP: dt-bindings: omap: Convert omap.txt to yaml Andrew Davis
2023-02-16 16:08 ` H. Nikolaus Schaller
2023-02-16 16:19 ` Andrew Davis
2023-02-16 16:43 ` H. Nikolaus Schaller
2023-02-16 16:41 ` Rob Herring
2023-02-16 17:30 ` Andrew Davis
2023-02-17 5:48 ` [RFC 0/2] Convert omap.txt to DT schema Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230328070844.GN7501@atomide.com \
--to=tony@atomide.com \
--cc=afd@ti.com \
--cc=andreas@kemnade.info \
--cc=arnd@arndb.de \
--cc=bcousson@baylibre.com \
--cc=colin.foster@in-advantage.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).