From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69C6DC77B61 for ; Tue, 28 Mar 2023 09:39:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230269AbjC1JjH (ORCPT ); Tue, 28 Mar 2023 05:39:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230199AbjC1JjF (ORCPT ); Tue, 28 Mar 2023 05:39:05 -0400 Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CEB5B134 for ; Tue, 28 Mar 2023 02:39:03 -0700 (PDT) Received: by mail-pf1-x42b.google.com with SMTP id g7so7554037pfu.2 for ; Tue, 28 Mar 2023 02:39:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679996343; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=9xwdE2IE7PNZO4yNNxVXzXNCrW6RVKY2tviFY/6w78Q=; b=TSY/B0ZRhgYwqc6csVXym8zms317WIvtdacvoLJ8+7m5Myi18vu+5cFWBAzYGX2Hin DB5g33pihRKOQxoLUPq/PLYkPtcQPsbF9Csl5saA1w/pta117XswrEgrFN3gfp2J2kEF oR5OKwS4va6jvBx1tfc67nm9h0ckluQGl2yyyTVogDhvXnoq6NM1OZ+ckJ2V42aYqCfG 0FLpwnDGE6blXnGA8AXBjFVMMuQ+OAg4LL/QwFlQfQ6pSG8jbbwx6SzhvM+Q1sTxVgIM 8TD1ME8AvReeFWufxfqydo8AWwMOl7T5umd7VYT/e65/abw7ELV0FtJQ/rjqzxyLkwN/ ciDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679996343; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9xwdE2IE7PNZO4yNNxVXzXNCrW6RVKY2tviFY/6w78Q=; b=LYHUaqJTsgMaFuriwJmq1nO0/hp0d0cD1vDYtXEMjpnqAI0A70CUlJj5zAEZYJnB68 UPacVzULDcaostB7tHKVZ9h7iyPhK734FIuoJdWlFu2Nq2mfvsx/9cw9fLtMADRp2wzW s+FQBIER/DSMO9LLF3/d5/By6q7CIr9Jt3+q8UrDCZw5WwLilz4qIve/0Ok7gYFSsEzo 5OU/OO1Fq0OyL6Gl/+ufyaQTP+u9dZjmsA4iTySeXbDkmxM5Pg9QBJUo+mTtWAspRb/C VeNdx7ge5lXHIGbwOC316vSEMbwW1C+lrqtgfPPam9/Q5uCM4U7hAKE0MppstT7o6AXx mmSA== X-Gm-Message-State: AAQBX9cVnVpdgu4XxHsUNJmTiQ6QgCmTqi//qodKQEOw6tPJ/jpeY8Az cu8mC43VXLAaKvLHFDUHVwgwwQzz/FS+V3nKuA== X-Google-Smtp-Source: AKy350bHDX3Rrj57zUrO/5RLT7vUI0eFxDpGfCXLQUU0RNc8bm08CmNKN9NMIR+qBrhCc73UDpa1EQ== X-Received: by 2002:a62:1c57:0:b0:624:f46:7256 with SMTP id c84-20020a621c57000000b006240f467256mr15126001pfc.21.1679996343067; Tue, 28 Mar 2023 02:39:03 -0700 (PDT) Received: from thinkpad ([117.193.212.166]) by smtp.gmail.com with ESMTPSA id a23-20020a62bd17000000b005a91d570972sm18330448pff.41.2023.03.28.02.38.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Mar 2023 02:39:02 -0700 (PDT) Date: Tue, 28 Mar 2023 15:08:53 +0530 From: Manivannan Sadhasivam To: Johan Hovold Cc: andersson@kernel.org, Thinh.Nguyen@synopsys.com, gregkh@linuxfoundation.org, mathias.nyman@intel.com, konrad.dybcio@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 1/5] arm64: dts: qcom: sc8280xp: Add missing dwc3 quirks Message-ID: <20230328093853.GA5695@thinkpad> References: <20230325165217.31069-1-manivannan.sadhasivam@linaro.org> <20230325165217.31069-2-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Mar 28, 2023 at 10:54:53AM +0200, Johan Hovold wrote: > On Sat, Mar 25, 2023 at 10:22:13PM +0530, Manivannan Sadhasivam wrote: > > Add missing quirks for the USB DWC3 IP. > > This is not an acceptable commit message generally and certainly not for > something that you have tagged for stable. > > At a minimum, you need to describe why these are needed and what the > impact is. > I can certainly improve the commit message. But usually the quirks are copied from the downstream devicetree where qualcomm engineers would've added them based on the platform requirements. > Also, why are you sending as part of a series purporting to enable > runtime PM when it appears to be all about optimising specific gadget > applications? > It's not related to this series I agree but just wanted to group it with a series touching usb so that it won't get lost. I could respin it separately though in v2. > Did you confirm that the below makes any sense or has this just been > copied verbatim from the vendor devicetree (it looks like that)? > As you've mentioned, most of the quirks are for gadget mode which is not supported by the upstream supported boards. So I haven't really tested them but for I assumed that Qcom engineers did. > The fact that almost none of the qcom SoCs sets these also indicates > that something is not right here. > > > Cc: stable@vger.kernel.org # 5.20 > > Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform") > > Signed-off-by: Manivannan Sadhasivam > > --- > > arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 14 ++++++++++++++ > > 1 file changed, 14 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > > index 0d02599d8867..266a94c712aa 100644 > > --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > > +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > > @@ -3040,6 +3040,13 @@ usb_0_dwc3: usb@a600000 { > > iommus = <&apps_smmu 0x820 0x0>; > > phys = <&usb_0_hsphy>, <&usb_0_qmpphy QMP_USB43DP_USB3_PHY>; > > phy-names = "usb2-phy", "usb3-phy"; > > + snps,hird-threshold = /bits/ 8 <0x0>; > > + snps,usb2-gadget-lpm-disable; > > Here you are disabling LPM for gadget mode, which makes most of the > other properties entirely pointless. > > > + snps,is-utmi-l1-suspend; > > + snps,dis-u1-entry-quirk; > > + snps,dis-u2-entry-quirk; > > These appear to be used to optimise certain gadget application and > likely not something that should be set in a dtsi. > I will cross check these with Qcom and respin accordingly. - Mani > > + snps,has-lpm-erratum; > > + tx-fifo-resize; > > Same here. > > > port { > > usb_0_role_switch: endpoint { > > Johan -- மணிவண்ணன் சதாசிவம்