* [PATCH 1/2] arm64: dts: rockchip: Enable watchdog support for RK3588
2023-03-28 21:00 [PATCH 0/2] RK3588 watchdog support Shreeya Patel
@ 2023-03-28 21:00 ` Shreeya Patel
2023-03-28 21:00 ` [PATCH 2/2] dt-bindings: watchdog: rockchip: Add rockchip,rk3588-wdt string Shreeya Patel
2023-03-30 11:44 ` [PATCH 0/2] RK3588 watchdog support Heiko Stuebner
2 siblings, 0 replies; 9+ messages in thread
From: Shreeya Patel @ 2023-03-28 21:00 UTC (permalink / raw)
To: wim, linux, robh+dt, krzysztof.kozlowski+dt, jamie, heiko
Cc: linux-watchdog, devicetree, linux-kernel, linux-arm-kernel,
linux-rockchip, kernel, Shreeya Patel
Add DT node for watchdog support in RK3588.
Signed-off-by: Shreeya Patel <shreeya.patel@collabora.com>
---
arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
index 005cde61b4b2..20793f67c079 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
@@ -1226,6 +1226,14 @@ i2c5: i2c@fead0000 {
status = "disabled";
};
+ wdt: watchdog@feaf0000 {
+ compatible = "rockchip,rk3588-wdt", "snps,dw-wdt";
+ reg = <0x0 0xfeaf0000 0x0 0x100>;
+ clocks = <&cru TCLK_WDT0>, <&cru PCLK_WDT0>;
+ clock-names = "tclk", "pclk";
+ interrupts = <GIC_SPI 315 IRQ_TYPE_LEVEL_HIGH 0>;
+ };
+
spi0: spi@feb00000 {
compatible = "rockchip,rk3588-spi", "rockchip,rk3066-spi";
reg = <0x0 0xfeb00000 0x0 0x1000>;
--
2.30.2
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 2/2] dt-bindings: watchdog: rockchip: Add rockchip,rk3588-wdt string
2023-03-28 21:00 [PATCH 0/2] RK3588 watchdog support Shreeya Patel
2023-03-28 21:00 ` [PATCH 1/2] arm64: dts: rockchip: Enable watchdog support for RK3588 Shreeya Patel
@ 2023-03-28 21:00 ` Shreeya Patel
2023-03-28 21:15 ` Heiko Stübner
` (2 more replies)
2023-03-30 11:44 ` [PATCH 0/2] RK3588 watchdog support Heiko Stuebner
2 siblings, 3 replies; 9+ messages in thread
From: Shreeya Patel @ 2023-03-28 21:00 UTC (permalink / raw)
To: wim, linux, robh+dt, krzysztof.kozlowski+dt, jamie, heiko
Cc: linux-watchdog, devicetree, linux-kernel, linux-arm-kernel,
linux-rockchip, kernel, Shreeya Patel
Add rockchip,rk3588-wdt compatible string.
Signed-off-by: Shreeya Patel <shreeya.patel@collabora.com>
---
Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
index 92df6e453f64..e7a87ce94772 100644
--- a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
@@ -29,6 +29,7 @@ properties:
- rockchip,rk3368-wdt
- rockchip,rk3399-wdt
- rockchip,rk3568-wdt
+ - rockchip,rk3588-wdt
- rockchip,rv1108-wdt
- const: snps,dw-wdt
--
2.30.2
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 2/2] dt-bindings: watchdog: rockchip: Add rockchip,rk3588-wdt string
2023-03-28 21:00 ` [PATCH 2/2] dt-bindings: watchdog: rockchip: Add rockchip,rk3588-wdt string Shreeya Patel
@ 2023-03-28 21:15 ` Heiko Stübner
2023-03-29 8:35 ` Krzysztof Kozlowski
2023-03-29 12:47 ` Guenter Roeck
2 siblings, 0 replies; 9+ messages in thread
From: Heiko Stübner @ 2023-03-28 21:15 UTC (permalink / raw)
To: wim, linux, robh+dt, krzysztof.kozlowski+dt, jamie, Shreeya Patel
Cc: linux-watchdog, devicetree, linux-kernel, linux-arm-kernel,
linux-rockchip, kernel, Shreeya Patel
Am Dienstag, 28. März 2023, 23:00:48 CEST schrieb Shreeya Patel:
> Add rockchip,rk3588-wdt compatible string.
>
> Signed-off-by: Shreeya Patel <shreeya.patel@collabora.com>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] dt-bindings: watchdog: rockchip: Add rockchip,rk3588-wdt string
2023-03-28 21:00 ` [PATCH 2/2] dt-bindings: watchdog: rockchip: Add rockchip,rk3588-wdt string Shreeya Patel
2023-03-28 21:15 ` Heiko Stübner
@ 2023-03-29 8:35 ` Krzysztof Kozlowski
2023-03-29 12:47 ` Guenter Roeck
2 siblings, 0 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-29 8:35 UTC (permalink / raw)
To: Shreeya Patel, wim, linux, robh+dt, krzysztof.kozlowski+dt, jamie,
heiko
Cc: linux-watchdog, devicetree, linux-kernel, linux-arm-kernel,
linux-rockchip, kernel
On 28/03/2023 23:00, Shreeya Patel wrote:
> Add rockchip,rk3588-wdt compatible string.
>
> Signed-off-by: Shreeya Patel <shreeya.patel@collabora.com>
> ---
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] dt-bindings: watchdog: rockchip: Add rockchip,rk3588-wdt string
2023-03-28 21:00 ` [PATCH 2/2] dt-bindings: watchdog: rockchip: Add rockchip,rk3588-wdt string Shreeya Patel
2023-03-28 21:15 ` Heiko Stübner
2023-03-29 8:35 ` Krzysztof Kozlowski
@ 2023-03-29 12:47 ` Guenter Roeck
2023-03-29 13:04 ` Heiko Stübner
2 siblings, 1 reply; 9+ messages in thread
From: Guenter Roeck @ 2023-03-29 12:47 UTC (permalink / raw)
To: Shreeya Patel
Cc: wim, robh+dt, krzysztof.kozlowski+dt, jamie, heiko,
linux-watchdog, devicetree, linux-kernel, linux-arm-kernel,
linux-rockchip, kernel
On Wed, Mar 29, 2023 at 02:30:48AM +0530, Shreeya Patel wrote:
> Add rockchip,rk3588-wdt compatible string.
>
> Signed-off-by: Shreeya Patel <shreeya.patel@collabora.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> index 92df6e453f64..e7a87ce94772 100644
> --- a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> @@ -29,6 +29,7 @@ properties:
> - rockchip,rk3368-wdt
> - rockchip,rk3399-wdt
> - rockchip,rk3568-wdt
> + - rockchip,rk3588-wdt
> - rockchip,rv1108-wdt
> - const: snps,dw-wdt
>
> --
> 2.30.2
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] dt-bindings: watchdog: rockchip: Add rockchip,rk3588-wdt string
2023-03-29 12:47 ` Guenter Roeck
@ 2023-03-29 13:04 ` Heiko Stübner
2023-03-29 21:52 ` Guenter Roeck
0 siblings, 1 reply; 9+ messages in thread
From: Heiko Stübner @ 2023-03-29 13:04 UTC (permalink / raw)
To: Shreeya Patel, Guenter Roeck
Cc: wim, robh+dt, krzysztof.kozlowski+dt, jamie, linux-watchdog,
devicetree, linux-kernel, linux-arm-kernel, linux-rockchip,
kernel
Hi Guenter,
Am Mittwoch, 29. März 2023, 14:47:34 CEST schrieb Guenter Roeck:
> On Wed, Mar 29, 2023 at 02:30:48AM +0530, Shreeya Patel wrote:
> > Add rockchip,rk3588-wdt compatible string.
> >
> > Signed-off-by: Shreeya Patel <shreeya.patel@collabora.com>
>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
just the usual question who is expected to pick up the binding patch?
Should I just take it together with the dts-patch or do we wait for
a watchdog-maintainer to pick up the binding alone?
Thanks
Heiko
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] dt-bindings: watchdog: rockchip: Add rockchip,rk3588-wdt string
2023-03-29 13:04 ` Heiko Stübner
@ 2023-03-29 21:52 ` Guenter Roeck
0 siblings, 0 replies; 9+ messages in thread
From: Guenter Roeck @ 2023-03-29 21:52 UTC (permalink / raw)
To: Heiko Stübner
Cc: Shreeya Patel, wim, robh+dt, krzysztof.kozlowski+dt, jamie,
linux-watchdog, devicetree, linux-kernel, linux-arm-kernel,
linux-rockchip, kernel
On Wed, Mar 29, 2023 at 03:04:52PM +0200, Heiko Stübner wrote:
> Hi Guenter,
>
> Am Mittwoch, 29. März 2023, 14:47:34 CEST schrieb Guenter Roeck:
> > On Wed, Mar 29, 2023 at 02:30:48AM +0530, Shreeya Patel wrote:
> > > Add rockchip,rk3588-wdt compatible string.
> > >
> > > Signed-off-by: Shreeya Patel <shreeya.patel@collabora.com>
> >
> > Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>
> just the usual question who is expected to pick up the binding patch?
> Should I just take it together with the dts-patch or do we wait for
> a watchdog-maintainer to pick up the binding alone?
I am ok with you taking both patches.
FTR:
Acked-by: Guenter Roeck <linux@roeck-us.net>
Guenter
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 0/2] RK3588 watchdog support
2023-03-28 21:00 [PATCH 0/2] RK3588 watchdog support Shreeya Patel
2023-03-28 21:00 ` [PATCH 1/2] arm64: dts: rockchip: Enable watchdog support for RK3588 Shreeya Patel
2023-03-28 21:00 ` [PATCH 2/2] dt-bindings: watchdog: rockchip: Add rockchip,rk3588-wdt string Shreeya Patel
@ 2023-03-30 11:44 ` Heiko Stuebner
2 siblings, 0 replies; 9+ messages in thread
From: Heiko Stuebner @ 2023-03-30 11:44 UTC (permalink / raw)
To: krzysztof.kozlowski+dt, linux, robh+dt, wim, jamie, Shreeya Patel
Cc: Heiko Stuebner, linux-kernel, linux-rockchip, linux-arm-kernel,
kernel, devicetree, linux-watchdog
On Wed, 29 Mar 2023 02:30:46 +0530, Shreeya Patel wrote:
> This patch series enables watchdog support for RK3588 and updates the
> DT bindings for the same.
>
> Shreeya Patel (2):
> arm64: dts: rockchip: Enable watchdog support for RK3588
> dt-bindings: watchdog: rockchip: Add rockchip,rk3588-wdt string
>
> [...]
Applied, thanks!
[1/2] arm64: dts: rockchip: Enable watchdog support for RK3588
commit: 932d139e4db18d535dea271df51db5216b8787b3
[2/2] dt-bindings: watchdog: rockchip: Add rockchip,rk3588-wdt string
commit: e1a234eb3d1507b942c25e5a5ae0d6fb9036f1ff
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 9+ messages in thread