From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@somainline.org>,
Jordan Crouse <jordan@cosmicpenguin.net>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Vivek Gautam <vivek.gautam@codeaurora.org>,
Vinod Koul <vkoul@kernel.org>, Rob Clark <robdclark@gmail.com>,
Stephen Boyd <sboyd@codeaurora.org>
Cc: Marijn Suijten <marijn.suijten@somainline.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Andy Gross <andy.gross@linaro.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>
Subject: [PATCH 1/4] arm64: dts: qcom: msm8998: Improve GPU OPP table
Date: Wed, 29 Mar 2023 21:17:28 +0200 [thread overview]
Message-ID: <20230329-topic-adreno_opp-v1-1-24d34ac6f007@linaro.org> (raw)
In-Reply-To: <20230329-topic-adreno_opp-v1-0-24d34ac6f007@linaro.org>
Add a newline before the first OPP subnode, remove useless
opp-supported-hw (there's only a single speed bin anyway) and replace
opp-level with required-opps to make sure the power domain level is
actually set, as opp-level is not the right property for this..
Furthermore, correct the levels that were incorrect before (confirmed
against downstream).
Round off frequencies that had uneven fluff on the last two digits.
To top if off, leave a note that we should really be scaling the
VDD GFX power domain coming from CPR4, which is not yet supported.
Scaling MX is still very important though and can be considered
valid for the time being - it's better if we scale at one of
two voltage rails than if we scaled none..
Fixes: 87cd46d68aea ("arm64: dts: qcom: msm8998: Configure Adreno GPU and related IOMMU")
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
arch/arm64/boot/dts/qcom/msm8998.dtsi | 39 +++++++++++++++--------------------
1 file changed, 17 insertions(+), 22 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi
index 09b222f363c2..11952f9ed9ae 100644
--- a/arch/arm64/boot/dts/qcom/msm8998.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi
@@ -1396,51 +1396,46 @@ adreno_gpu: gpu@5000000 {
interrupts = <0 300 IRQ_TYPE_LEVEL_HIGH>;
iommus = <&adreno_smmu 0>;
operating-points-v2 = <&gpu_opp_table>;
+ /* TODO: also scale VDDGFX with CPR4 */
power-domains = <&rpmpd MSM8998_VDDMX>;
status = "disabled";
gpu_opp_table: opp-table {
compatible = "operating-points-v2";
- opp-710000097 {
- opp-hz = /bits/ 64 <710000097>;
- opp-level = <RPM_SMD_LEVEL_TURBO>;
- opp-supported-hw = <0xff>;
+
+ opp-710000000 {
+ opp-hz = /bits/ 64 <710000000>;
+ required-opps = <&rpmpd_opp_turbo>;
};
- opp-670000048 {
- opp-hz = /bits/ 64 <670000048>;
- opp-level = <RPM_SMD_LEVEL_NOM_PLUS>;
- opp-supported-hw = <0xff>;
+ opp-670000000 {
+ opp-hz = /bits/ 64 <670000000>;
+ required-opps = <&rpmpd_opp_turbo>;
};
- opp-596000097 {
- opp-hz = /bits/ 64 <596000097>;
- opp-level = <RPM_SMD_LEVEL_NOM>;
- opp-supported-hw = <0xff>;
+ opp-596000000 {
+ opp-hz = /bits/ 64 <596000000>;
+ required-opps = <&rpmpd_opp_nom>;
};
- opp-515000097 {
- opp-hz = /bits/ 64 <515000097>;
- opp-level = <RPM_SMD_LEVEL_SVS_PLUS>;
- opp-supported-hw = <0xff>;
+ opp-515000000 {
+ opp-hz = /bits/ 64 <515000000>;
+ required-opps = <&rpmpd_opp_nom>;
};
opp-414000000 {
opp-hz = /bits/ 64 <414000000>;
- opp-level = <RPM_SMD_LEVEL_SVS>;
- opp-supported-hw = <0xff>;
+ required-opps = <&rpmpd_opp_svs>;
};
opp-342000000 {
opp-hz = /bits/ 64 <342000000>;
- opp-level = <RPM_SMD_LEVEL_LOW_SVS>;
- opp-supported-hw = <0xff>;
+ required-opps = <&rpmpd_opp_svs>;
};
opp-257000000 {
opp-hz = /bits/ 64 <257000000>;
- opp-level = <RPM_SMD_LEVEL_MIN_SVS>;
- opp-supported-hw = <0xff>;
+ required-opps = <&rpmpd_opp_svs>;
};
};
};
--
2.40.0
next prev parent reply other threads:[~2023-03-29 19:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 19:17 [PATCH 0/4] Improve some Adreno Device Tree nodes Konrad Dybcio
2023-03-29 19:17 ` Konrad Dybcio [this message]
2023-03-29 19:17 ` [PATCH 2/4] arm64: dts: qcom: msm8996: Pass VDDMX to gpu in power-domains Konrad Dybcio
2023-03-29 21:29 ` Dmitry Baryshkov
2023-03-29 19:17 ` [PATCH 3/4] arm64: dts: qcom: msm8996: Improve GPU OPP table Konrad Dybcio
2023-03-29 21:32 ` Dmitry Baryshkov
2023-03-30 10:57 ` Konrad Dybcio
2023-05-26 13:30 ` Konrad Dybcio
2023-05-26 13:51 ` Dmitry Baryshkov
2023-08-08 23:47 ` Konrad Dybcio
2023-03-29 19:17 ` [PATCH 4/4] arm64: dts: qcom: msm8916: " Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230329-topic-adreno_opp-v1-1-24d34ac6f007@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=andy.gross@linaro.org \
--cc=angelogioacchino.delregno@somainline.org \
--cc=devicetree@vger.kernel.org \
--cc=jordan@cosmicpenguin.net \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=robdclark@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=vivek.gautam@codeaurora.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).