[PATCH v3 0/4] Tegra DTS improvements

[PATCH v3 0/4] Tegra DTS improvements

[Svyatoslav Ryhel]

Path for mmc devices are replaced with labels for
better tree comprehension. CPU paths are replaced with
labels references as well. Fixed accelerometer mount
matrix for TF101. Added 266.5MHz peripheral opp node
for devices which need it.

---
Chandes from v2:
- dropped commits with labels additions
- added mmc path to laber reference switch
- added cpu path to label reference switch

Chandes from v1:
- added missing sign-off
---

Maxim Schwalm (1):
  ARM: tegra30: Use cpu* labels

Svyatoslav Ryhel (3):
  ARM: tegra: transformer: use labels for mmc in aliases
  ARM: tegra: asus-tf101: fix accelerometer mount matrix
  ARM: tegra30: peripherals: add 266.5MHz nodes

 arch/arm/boot/dts/tegra114-asus-tf701t.dts    | 12 +++++------
 arch/arm/boot/dts/tegra20-asus-tf101.dts      |  6 +++---
 .../dts/tegra30-asus-transformer-common.dtsi  | 12 +++++------
 .../arm/boot/dts/tegra30-peripherals-opp.dtsi | 20 +++++++++++++++++++
 arch/arm/boot/dts/tegra30.dtsi                |  5 +----
 5 files changed, 36 insertions(+), 19 deletions(-)

-- 
2.37.2

[PATCH v3 1/4] ARM: tegra: transformer: use labels for mmc in aliases

[Svyatoslav Ryhel]

Use phandle references for mmc instead of path in aliases.

Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
---
 arch/arm/boot/dts/tegra114-asus-tf701t.dts           | 12 ++++++------
 .../boot/dts/tegra30-asus-transformer-common.dtsi    | 12 ++++++------
 2 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/arch/arm/boot/dts/tegra114-asus-tf701t.dts b/arch/arm/boot/dts/tegra114-asus-tf701t.dts
index 84a3eb38e71d..3a420ac969ff 100644
--- a/arch/arm/boot/dts/tegra114-asus-tf701t.dts
+++ b/arch/arm/boot/dts/tegra114-asus-tf701t.dts
@@ -13,9 +13,9 @@ / {
 	chassis-type = "convertible";
 
 	aliases {
-		mmc0 = "/mmc@78000600"; /* eMMC */
-		mmc1 = "/mmc@78000400"; /* uSD slot */
-		mmc2 = "/mmc@78000000"; /* WiFi */
+		mmc0 = &sdmmc4; /* eMMC */
+		mmc1 = &sdmmc3; /* uSD slot */
+		mmc2 = &sdmmc1; /* WiFi */
 
 		rtc0 = &palmas;
 		rtc1 = "/rtc@7000e000";
@@ -605,12 +605,12 @@ i2s@70080300 {
 		};
 	};
 
-	mmc@78000000 {
+	sdmmc1: mmc@78000000 {
 		/* WiFi */
 	};
 
 	/* MicroSD card */
-	mmc@78000400 {
+	sdmmc3: mmc@78000400 {
 		status = "okay";
 
 		bus-width = <4>;
@@ -626,7 +626,7 @@ mmc@78000400 {
 		pinctrl-0 = <&sdmmc3_default>;
 	};
 
-	mmc@78000600 {
+	sdmmc4: mmc@78000600 {
 		/* eMMC */
 	};
 
diff --git a/arch/arm/boot/dts/tegra30-asus-transformer-common.dtsi b/arch/arm/boot/dts/tegra30-asus-transformer-common.dtsi
index 1861b2de2dc3..f32806f07989 100644
--- a/arch/arm/boot/dts/tegra30-asus-transformer-common.dtsi
+++ b/arch/arm/boot/dts/tegra30-asus-transformer-common.dtsi
@@ -12,9 +12,9 @@ / {
 	chassis-type = "convertible";
 
 	aliases {
-		mmc0 = "/mmc@78000600"; /* eMMC */
-		mmc1 = "/mmc@78000000"; /* uSD slot */
-		mmc2 = "/mmc@78000400"; /* WiFi */
+		mmc0 = &sdmmc4; /* eMMC */
+		mmc1 = &sdmmc1; /* uSD slot */
+		mmc2 = &sdmmc3; /* WiFi */
 
 		rtc0 = &pmic;
 		rtc1 = "/rtc@7000e000";
@@ -1388,7 +1388,7 @@ i2s@70080600 {		/* i2s3 */
 		};
 	};
 
-	mmc@78000000 {
+	sdmmc1: mmc@78000000 {
 		status = "okay";
 
 		/* FIXME: Full 208Mhz clock rate doesn't work reliably */
@@ -1401,7 +1401,7 @@ mmc@78000000 {
 		vqmmc-supply = <&vddio_usd>;	/* ldo3 */
 	};
 
-	mmc@78000400 {
+	sdmmc3: mmc@78000400 {
 		status = "okay";
 
 		#address-cells = <1>;
@@ -1431,7 +1431,7 @@ wifi@1 {
 		};
 	};
 
-	mmc@78000600 {
+	sdmmc4: mmc@78000600 {
 		status = "okay";
 		bus-width = <8>;
 		vmmc-supply = <&vcore_emmc>;
-- 
2.37.2

Re: [PATCH v3 1/4] ARM: tegra: transformer: use labels for mmc in aliases

[Svyatoslav Ryhel]

ср, 29 бер. 2023 р. о 12:04 Svyatoslav Ryhel <clamor95@gmail.com> пише:
>
> Use phandle references for mmc instead of path in aliases.
>
> Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
> ---
>  arch/arm/boot/dts/tegra114-asus-tf701t.dts           | 12 ++++++------
>  .../boot/dts/tegra30-asus-transformer-common.dtsi    | 12 ++++++------
>  2 files changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/arch/arm/boot/dts/tegra114-asus-tf701t.dts b/arch/arm/boot/dts/tegra114-asus-tf701t.dts
> index 84a3eb38e71d..3a420ac969ff 100644
> --- a/arch/arm/boot/dts/tegra114-asus-tf701t.dts
> +++ b/arch/arm/boot/dts/tegra114-asus-tf701t.dts
> @@ -13,9 +13,9 @@ / {
>         chassis-type = "convertible";
>
>         aliases {
> -               mmc0 = "/mmc@78000600"; /* eMMC */
> -               mmc1 = "/mmc@78000400"; /* uSD slot */
> -               mmc2 = "/mmc@78000000"; /* WiFi */
> +               mmc0 = &sdmmc4; /* eMMC */
> +               mmc1 = &sdmmc3; /* uSD slot */
> +               mmc2 = &sdmmc1; /* WiFi */
>
>                 rtc0 = &palmas;
>                 rtc1 = "/rtc@7000e000";
> @@ -605,12 +605,12 @@ i2s@70080300 {
>                 };
>         };
>
> -       mmc@78000000 {
> +       sdmmc1: mmc@78000000 {
>                 /* WiFi */
>         };
>
>         /* MicroSD card */
> -       mmc@78000400 {
> +       sdmmc3: mmc@78000400 {
>                 status = "okay";
>
>                 bus-width = <4>;
> @@ -626,7 +626,7 @@ mmc@78000400 {
>                 pinctrl-0 = <&sdmmc3_default>;
>         };
>
> -       mmc@78000600 {
> +       sdmmc4: mmc@78000600 {
>                 /* eMMC */
>         };
>
> diff --git a/arch/arm/boot/dts/tegra30-asus-transformer-common.dtsi b/arch/arm/boot/dts/tegra30-asus-transformer-common.dtsi
> index 1861b2de2dc3..f32806f07989 100644
> --- a/arch/arm/boot/dts/tegra30-asus-transformer-common.dtsi
> +++ b/arch/arm/boot/dts/tegra30-asus-transformer-common.dtsi
> @@ -12,9 +12,9 @@ / {
>         chassis-type = "convertible";
>
>         aliases {
> -               mmc0 = "/mmc@78000600"; /* eMMC */
> -               mmc1 = "/mmc@78000000"; /* uSD slot */
> -               mmc2 = "/mmc@78000400"; /* WiFi */
> +               mmc0 = &sdmmc4; /* eMMC */
> +               mmc1 = &sdmmc1; /* uSD slot */
> +               mmc2 = &sdmmc3; /* WiFi */
>
>                 rtc0 = &pmic;
>                 rtc1 = "/rtc@7000e000";
> @@ -1388,7 +1388,7 @@ i2s@70080600 {            /* i2s3 */
>                 };
>         };
>
> -       mmc@78000000 {
> +       sdmmc1: mmc@78000000 {
>                 status = "okay";
>
>                 /* FIXME: Full 208Mhz clock rate doesn't work reliably */
> @@ -1401,7 +1401,7 @@ mmc@78000000 {
>                 vqmmc-supply = <&vddio_usd>;    /* ldo3 */
>         };
>
> -       mmc@78000400 {
> +       sdmmc3: mmc@78000400 {
>                 status = "okay";
>
>                 #address-cells = <1>;
> @@ -1431,7 +1431,7 @@ wifi@1 {
>                 };
>         };
>
> -       mmc@78000600 {
> +       sdmmc4: mmc@78000600 {
>                 status = "okay";
>                 bus-width = <8>;
>                 vmmc-supply = <&vcore_emmc>;
> --
> 2.37.2
>

Hello Thierry!
For some reason this commit was not picked while all others in
the patchset were. May I know why and how to fix this?

Best regards,
Svyatoslav R.

[PATCH v3 2/4] ARM: tegra30: Use cpu* labels

[Svyatoslav Ryhel]

From: Maxim Schwalm <maxim.schwalm@gmail.com>

Replace cpu paths with labels since those already exist in tree.

Signed-off-by: Maxim Schwalm <maxim.schwalm@gmail.com>
Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
---
 arch/arm/boot/dts/tegra30.dtsi | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/tegra30.dtsi b/arch/arm/boot/dts/tegra30.dtsi
index b6fcac6016e0..9cba67b54111 100644
--- a/arch/arm/boot/dts/tegra30.dtsi
+++ b/arch/arm/boot/dts/tegra30.dtsi
@@ -1283,10 +1283,7 @@ pmu {
 			     <GIC_SPI 145 IRQ_TYPE_LEVEL_HIGH>,
 			     <GIC_SPI 146 IRQ_TYPE_LEVEL_HIGH>,
 			     <GIC_SPI 147 IRQ_TYPE_LEVEL_HIGH>;
-		interrupt-affinity = <&{/cpus/cpu@0}>,
-				     <&{/cpus/cpu@1}>,
-				     <&{/cpus/cpu@2}>,
-				     <&{/cpus/cpu@3}>;
+		interrupt-affinity = <&cpu0>, <&cpu1>, <&cpu2>, <&cpu3>;
 	};
 
 	thermal-zones {
-- 
2.37.2

Re: (subset) [PATCH v3 2/4] ARM: tegra30: Use cpu* labels

[Thierry Reding]

From: Thierry Reding <treding@nvidia.com>

On Wed, 29 Mar 2023 12:04:01 +0300, Svyatoslav Ryhel wrote:
> From: Maxim Schwalm <maxim.schwalm@gmail.com>
> 
> Replace cpu paths with labels since those already exist in tree.
> 
> 

Applied, thanks!

[2/4] ARM: tegra30: Use cpu* labels
      (no commit info)

Best regards,
-- 
Thierry Reding <treding@nvidia.com>

[PATCH v3 3/4] ARM: tegra: asus-tf101: fix accelerometer mount matrix

[Svyatoslav Ryhel]

Accelerometer mount matrix used in tf101 downstream is inverted.
This new matrix was generated on actual device using calibration
script, like on other transformers.

Tested-by: Robert Eckelmann <longnoserob@gmail.com>
Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
---
 arch/arm/boot/dts/tegra20-asus-tf101.dts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/tegra20-asus-tf101.dts b/arch/arm/boot/dts/tegra20-asus-tf101.dts
index 7b2969656ec9..dcb231f6e42d 100644
--- a/arch/arm/boot/dts/tegra20-asus-tf101.dts
+++ b/arch/arm/boot/dts/tegra20-asus-tf101.dts
@@ -577,9 +577,9 @@ accelerometer@f {
 					vdd-supply = <&vdd_1v8_sys>;
 					vddio-supply = <&vdd_1v8_sys>;
 
-					mount-matrix =	 "1",  "0",  "0",
-							 "0",  "1",  "0",
-							 "0",  "0",  "1";
+					mount-matrix =	"-1",  "0",  "0",
+							 "0", "-1",  "0",
+							 "0",  "0", "-1";
 				};
 			};
 		};
-- 
2.37.2

Re: (subset) [PATCH v3 3/4] ARM: tegra: asus-tf101: fix accelerometer mount matrix

[Thierry Reding]

From: Thierry Reding <treding@nvidia.com>

On Wed, 29 Mar 2023 12:04:02 +0300, Svyatoslav Ryhel wrote:
> Accelerometer mount matrix used in tf101 downstream is inverted.
> This new matrix was generated on actual device using calibration
> script, like on other transformers.
> 
> 

Applied, thanks!

[3/4] ARM: tegra: asus-tf101: fix accelerometer mount matrix
      (no commit info)

Best regards,
-- 
Thierry Reding <treding@nvidia.com>

[PATCH v3 4/4] ARM: tegra30: peripherals: add 266.5MHz nodes

[Svyatoslav Ryhel]

LG Optimus Vu (p895) and Optimus 4X HD (p880) have 266.5MHz RAM
clock and require this entry to work with it correctly.

Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
---
 .../arm/boot/dts/tegra30-peripherals-opp.dtsi | 20 +++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/arch/arm/boot/dts/tegra30-peripherals-opp.dtsi b/arch/arm/boot/dts/tegra30-peripherals-opp.dtsi
index d100a1a8b705..a2d557155114 100644
--- a/arch/arm/boot/dts/tegra30-peripherals-opp.dtsi
+++ b/arch/arm/boot/dts/tegra30-peripherals-opp.dtsi
@@ -210,6 +210,20 @@ opp-204000000-1250 {
 			opp-suspend;
 		};
 
+		opp-266500000-1000 {
+			opp-microvolt = <1000000 1000000 1350000>;
+			opp-hz = /bits/ 64 <266500000>;
+			opp-supported-hw = <0x0007>;
+			required-opps = <&core_opp_1000>;
+		};
+
+		opp-266500000-1250 {
+			opp-microvolt = <1250000 1250000 1350000>;
+			opp-hz = /bits/ 64 <266500000>;
+			opp-supported-hw = <0x0008>;
+			required-opps = <&core_opp_1250>;
+		};
+
 		opp-333500000-1000 {
 			opp-microvolt = <1000000 1000000 1350000>;
 			opp-hz = /bits/ 64 <333500000>;
@@ -424,6 +438,12 @@ opp-204000000 {
 			opp-suspend;
 		};
 
+		opp-266500000 {
+			opp-hz = /bits/ 64 <266500000>;
+			opp-supported-hw = <0x000F>;
+			opp-peak-kBps = <2132000>;
+		};
+
 		opp-333500000 {
 			opp-hz = /bits/ 64 <333500000>;
 			opp-supported-hw = <0x000F>;
-- 
2.37.2

Re: (subset) [PATCH v3 4/4] ARM: tegra30: peripherals: add 266.5MHz nodes

[Thierry Reding]

From: Thierry Reding <treding@nvidia.com>

On Wed, 29 Mar 2023 12:04:03 +0300, Svyatoslav Ryhel wrote:
> LG Optimus Vu (p895) and Optimus 4X HD (p880) have 266.5MHz RAM
> clock and require this entry to work with it correctly.
> 
> 

Applied, thanks!

[4/4] ARM: tegra30: peripherals: add 266.5MHz nodes
      (no commit info)

Best regards,
-- 
Thierry Reding <treding@nvidia.com>

Re: [PATCH v3 0/4] Tegra DTS improvements

[Thierry Reding]

From: Thierry Reding <treding@nvidia.com>

On Wed, 29 Mar 2023 12:03:59 +0300, Svyatoslav Ryhel wrote:
> Path for mmc devices are replaced with labels for
> better tree comprehension. CPU paths are replaced with
> labels references as well. Fixed accelerometer mount
> matrix for TF101. Added 266.5MHz peripheral opp node
> for devices which need it.
> 

Applied, thanks!

[1/4] ARM: tegra: transformer: use labels for mmc in aliases
      (no commit info)
[2/4] ARM: tegra30: Use cpu* labels
      (no commit info)
[3/4] ARM: tegra: asus-tf101: fix accelerometer mount matrix
      (no commit info)
[4/4] ARM: tegra30: peripherals: add 266.5MHz nodes
      (no commit info)

Best regards,
-- 
Thierry Reding <treding@nvidia.com>