From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62291C761AF for ; Wed, 29 Mar 2023 14:40:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230222AbjC2OkX (ORCPT ); Wed, 29 Mar 2023 10:40:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38836 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229704AbjC2OkF (ORCPT ); Wed, 29 Mar 2023 10:40:05 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D72AB5B8E; Wed, 29 Mar 2023 07:37:03 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4BB10B82105; Wed, 29 Mar 2023 14:36:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 39D49C433EF; Wed, 29 Mar 2023 14:36:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680100583; bh=GTgl/O6Eui3d3tW6bMCePAq+WtWAQCIjEIQN5bKQGYg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nDRgvs3EMmFPOm9DEWuZVcOpe6NSZKG0+WB0LNY3MBa/Jv3gmntEME0nk8jtatU+1 /3SNWzBtX8kN42r5qroG41cUmkfgi+oigh5OCgCqjEFQfTR5yE8L39L3zXRIpatfv/ xgvUsBGqdQAulgmcKg/t25jprTTZwwPZmweN8q5QSkp4iS6ugQHewbIYZNldN/jFEy jZ6YNxSBSg+qHRsOWo5qhUnMx7jewcTvu2iGxkhmglFubOuStC5Mm1/qMsUVYJZLKm rjIx0IWkPsgPWUgl1SX6s2uOw8BrJRHg5UQfictIcHyvQCjYMDNhi8d5a3F7Uxpnmd nw3mJ/287kOag== Date: Wed, 29 Mar 2023 15:36:15 +0100 From: Lee Jones To: "Sahin, Okan" Cc: Rob Herring , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Jonathan Cameron , Lars-Peter Clausen , Andy Shevchenko , Cosmin Tanislav , Stephen Boyd , Caleb Connolly , Lad Prabhakar , "Bolboaca, Ramona" , ChiYuan Huang , "Tilki, Ibrahim" , William Breathitt Gray , Arnd Bergmann , ChiaEn Wu , Haibo Chen , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-iio@vger.kernel.org" Subject: Re: [PATCH v6 5/5] mfd: max77541: Add ADI MAX77541/MAX77540 PMIC Support Message-ID: <20230329143615.GS2673958@google.com> References: <20230307112835.81886-1-okan.sahin@analog.com> <20230307112835.81886-6-okan.sahin@analog.com> <20230315175223.GI9667@google.com> <20230315175257.GJ9667@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, 28 Mar 2023, Sahin, Okan wrote: > >On Wed, 15 Mar 2023, Lee Jones wrote: > > > >> On Tue, 07 Mar 2023, Okan Sahin wrote: > >> > >> > MFD driver for MAX77541/MAX77540 to enable its sub devices. > >> > > >> > The MAX77541 is a multi-function devices. It includes buck converter > >> > and ADC. > >> > > >> > The MAX77540 is a high-efficiency buck converter with two 3A > >> > switching phases. > >> > > >> > They have same regmap except for ADC part of MAX77541. > >> > > >> > Signed-off-by: Okan Sahin > >> > --- > >> > drivers/mfd/Kconfig | 13 ++ > >> > drivers/mfd/Makefile | 1 + > >> > drivers/mfd/max77541.c | 224 > >+++++++++++++++++++++++++++++++++++ > >> > include/linux/mfd/max77541.h | 97 +++++++++++++++ > >> > 4 files changed, 335 insertions(+) > >> > create mode 100644 drivers/mfd/max77541.c create mode 100644 > >> > include/linux/mfd/max77541.h > >> > >> FYI: I'm not re-reviewing this since you've chosen to ignore some of > >> my previous review comments. Issues highlighted by review comments > >> don't just go away on resubmission. > > > >... and the subject is malformed. > > > >-- > >Lee Jones [李琼斯] > > Hi Lee, > > I am sorry if I missed your review comments, this was not my intention. I want to thank you for your contribution. Your feedbacks are very valuable, and I am trying to understand and fix each one before sending the patch. Indeed, I sorted your feedback on previous patches. As far as I know, I have fixed all of them, is there a problem with any of them that I fixed, or is there any missing review? From you, there were some comments like "why did you use this?", I suppose I need to respond them before sending following patches. I thought I should not bother the maintainers unnecessarily. I am sorry for them. Please ask your email client to line-wrap. Here is the part of the review you ignored: [...] > +static const struct chip_info chip[] = { Why do you need this require sub-structure? > + [MAX77540] = { > + .id = MAX77540, > + .n_devs = ARRAY_SIZE(max77540_devs), > + .devs = max77540_devs, > + }, > + [MAX77541] = { > + .id = MAX77541, > + .n_devs = ARRAY_SIZE(max77541_devs), > + .devs = max77541_devs, > + }, > +}; [...] > +static const struct of_device_id max77541_of_id[] = { > + { > + .compatible = "adi,max77540", > + .data = &chip[MAX77540], > + }, > + { > + .compatible = "adi,max77541", > + .data = &chip[MAX77541], > + }, > + { /* sentinel */ } > +}; > +MODULE_DEVICE_TABLE(of, max77541_of_id); > + > +static const struct i2c_device_id max77541_i2c_id[] = { > + { "max77540", (kernel_ulong_t)&chip[MAX77540] }, > + { "max77541", (kernel_ulong_t)&chip[MAX77541] }, Just 'MAX77540' is fine. > + { /* sentinel */ } Remove the comment, we know how terminators work. Same comments for max77541_of_id. -- Lee Jones [李琼斯]