From: Nishanth Menon <nm@ti.com>
To: Bhavya Kapoor <b-kapoor@ti.com>
Cc: Apurva Nandan <a-nandan@ti.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
"Kumar, Udit" <u-kumar1@ti.com>
Subject: Re: [PATCH] arm64: dts: ti: k3-j784s4-evm: Add eMMC mmc0 support
Date: Thu, 30 Mar 2023 13:27:35 -0500 [thread overview]
Message-ID: <20230330182735.2lkuplsqcjku5enh@unnoticed> (raw)
In-Reply-To: <8f4e8265-da64-1e53-e1ed-b925e0326cad@ti.com>
On 23:14-20230330, Bhavya Kapoor wrote:
>
> On 30/03/23 20:54, Nishanth Menon wrote:
> > On 11:50-20230330, Bhavya Kapoor wrote:
> >> On 27/03/23 14:01, Apurva Nandan wrote:
> >>> Add support for eMMC card connected to main sdhci0 instance.
> >>>
> >>> Signed-off-by: Apurva Nandan <a-nandan@ti.com>
> >> Reviewed-by: Bhavya Kapoor <b-kapoor@ti.com>
> >>
> >>> ---
> >>> arch/arm64/boot/dts/ti/k3-j784s4-evm.dts | 9 +++++++++
> >>> 1 file changed, 9 insertions(+)
> >>>
> >>> diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
> >>> index 7480f37e89e8..1622a01a4667 100644
> >>> --- a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
> >>> +++ b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
> >>> @@ -21,6 +21,7 @@ chosen {
> >>>
> >>> aliases {
> >>> serial2 = &main_uart8;
> >>> + mmc0 = &main_sdhci0;
> >>> mmc1 = &main_sdhci1;
> >>> i2c0 = &main_i2c0;
> >>> };
> >>> @@ -225,6 +226,14 @@ exp2: gpio@22 {
> >>> };
> >>> };
> >>>
> >>> +&main_sdhci0 {
> >>> + /* eMMC */
> >>> + status = "okay";
> >>> + non-removable;
> >>> + ti,driver-strength-ohm = <50>;
> >>> + disable-wp;
> >>> +};
> >>> +
> >>> &main_sdhci1 {
> >>> /* SD card */
> >>> status = "okay";
> >>> --
> >>> 2.34.1
> >> Looks correct to me.
> >
> > Don't you need pinmux?
> >
> Hi Nishanth, pinmux is not needed since there is no mux options for emmc pins (mmc0) in datasheet.
>
> -> Kindly refer to datasheet for same : https://www.ti.com/lit/ds/symlink/tda4vh-q1.pdf?ts=1680197698102&ref_url=https%253A%252F%252Fwww.ti.com%252Fproduct%252FTDA4VH-Q1%253FkeyMatch%253DTDA4VH%2BDATASHEET
Aah, yes - thanks for clarifying.
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
next prev parent reply other threads:[~2023-03-30 18:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 8:31 [PATCH] arm64: dts: ti: k3-j784s4-evm: Add eMMC mmc0 support Apurva Nandan
2023-03-30 6:20 ` Bhavya Kapoor
2023-03-30 15:24 ` Nishanth Menon
2023-03-30 17:44 ` Bhavya Kapoor
2023-03-30 18:27 ` Nishanth Menon [this message]
2023-03-30 22:05 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230330182735.2lkuplsqcjku5enh@unnoticed \
--to=nm@ti.com \
--cc=a-nandan@ti.com \
--cc=b-kapoor@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=u-kumar1@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox