Re: [PATCH] arm64: dts: ti: k3-j784s4-evm: Add eMMC mmc0 support

Nishanth Menon
2023-03-30T15:42:24Z

On 11:50-20230330, Bhavya Kapoor wrote:
>
> On 27/03/23 14:01, Apurva Nandan wrote:
> > Add support for eMMC card connected to main sdhci0 instance.
> >
> > Signed-off-by: Apurva Nandan <a-nandan@ti.com>
>
> Reviewed-by: Bhavya Kapoor <b-kapoor@ti.com>
>
> > ---
> > arch/arm64/boot/dts/ti/k3-j784s4-evm.dts | 9 +++++++++
> > 1 file changed, 9 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
> > index 7480f37e89e8..1622a01a4667 100644
> > --- a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
> > +++ b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
> > @@ -21,6 +21,7 @@ chosen {
> >
> > aliases {
> > serial2 = &main_uart8;
> > + mmc0 = &main_sdhci0;
> > mmc1 = &main_sdhci1;
> > i2c0 = &main_i2c0;
> > };
> > @@ -225,6 +226,14 @@ exp2: gpio@22 {
> > };
> > };
> >
> > +&main_sdhci0 {
> > + /* eMMC */
> > + status = "okay";
> > + non-removable;
> > + ti,driver-strength-ohm = <50>;
> > + disable-wp;
> > +};
> > +
> > &main_sdhci1 {
> > /* SD card */
> > status = "okay";
> > --
> > 2.34.1
> Looks correct to me.

Don't you need pinmux?